From: Thomas Monjalon <thomas@monjalon.net>
To: oulijun <oulijun@huawei.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: arybchenko@solarflare.com, dev@dpdk.org, linuxarm@openeuler.org
Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini
Date: Fri, 29 Jan 2021 09:57:02 +0100 [thread overview]
Message-ID: <3445400.gcINu9pssS@thomas> (raw)
In-Reply-To: <5e75c811-c3ef-486a-471b-eeabde28bd7b@intel.com>
29/01/2021 09:46, Ferruh Yigit:
> On 1/29/2021 1:13 AM, oulijun wrote:
> > 在 2021/1/28 22:12, Thomas Monjalon 写道:
> >> 28/01/2021 13:43, Lijun Ou:
> >>> The hns3 PMD add FEC features implementation in 20.11.
> >>> Therefore, need to update the hns3.ini for supporting.
> >>>
> >>> Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> >>> ---
> >>> doc/guides/nics/features/hns3.ini | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/doc/guides/nics/features/hns3.ini
> >>> b/doc/guides/nics/features/hns3.ini
> >>> index a467396..4ea568c 100644
> >>> --- a/doc/guides/nics/features/hns3.ini
> >>> +++ b/doc/guides/nics/features/hns3.ini
> >>> @@ -39,5 +39,6 @@ Stats per queue = Y
> >>> FW version = Y
> >>> Registers dump = Y
> >>> Multiprocess aware = Y
> >>> +FEC = Y
> >>
> >> Please don't use tabs but only spaces in such .ini file.
> >>
> > OK， I will fix it
> >> Can it be squashed with the commit adding the feature in default.ini?
> > Do you think patch[1/5] is merged into one ? I took ferruh.yigit's advice.
>
> Both OK to me, according Thomas' suggestion 1/5, 2/5 & 3/5 can be merged.
Yes please. All three patches have the same intent: add FEC to features doc.
next prev parent reply other threads:[~2021-01-29 8:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 13:43 [dpdk-dev] [PATCH 0/3] update doc for hns3 Lijun Ou
2021-01-20 13:43 ` [dpdk-dev] [PATCH 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-28 0:20 ` Ferruh Yigit
2021-01-28 0:21 ` Ferruh Yigit
2021-01-28 1:55 ` oulijun
2021-01-28 9:14 ` Thomas Monjalon
2021-01-20 13:43 ` [dpdk-dev] [PATCH 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-28 0:25 ` Ferruh Yigit
2021-01-20 13:43 ` [dpdk-dev] [PATCH 3/3] doc: fix hns3 rst Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 0/5] update doc for hns3 Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 1/5] doc: add FEC in NIC features Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 2/5] net/hns3: add FEC feature for hns3.ini Lijun Ou
2021-01-28 14:12 ` Thomas Monjalon
2021-01-29 1:13 ` oulijun
2021-01-29 8:46 ` Ferruh Yigit
2021-01-29 8:57 ` Thomas Monjalon [this message]
2021-01-29 9:10 ` oulijun
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 3/5] net/cxgbe: add FEC feature for cxgbe.ini Lijun Ou
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 4/5] doc: update release notes for hns3 Lijun Ou
2021-01-28 14:46 ` Ferruh Yigit
2021-01-29 1:28 ` oulijun
2021-01-29 8:48 ` Ferruh Yigit
2021-01-28 12:43 ` [dpdk-dev] [PATCH v2 5/5] doc: fix hns3 rst Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 1/3] doc: add FEC in NIC features Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 2/3] doc: update release notes for hns3 Lijun Ou
2021-01-29 9:22 ` [dpdk-dev] [PATCH v3 3/3] doc: fix hns3 rst Lijun Ou
2021-01-29 11:57 ` [dpdk-dev] [PATCH v3 0/3] update doc for hns3 Ferruh Yigit
2021-02-03 9:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3445400.gcINu9pssS@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@openeuler.org \
--cc=oulijun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.