From mboxrd@z Thu Jan  1 00:00:00 1970
From: jim miro <daliroot@yahoo.com>
Subject: Re: error compiling kvm-72 not there with kvm-69 - link kernel 2.6.26
Date: Wed, 6 Aug 2008 23:46:44 -0700 (PDT)
Message-ID: <344840.96077.qm@web39505.mail.mud.yahoo.com>
Reply-To: daliroot@yahoo.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from web39505.mail.mud.yahoo.com ([209.191.106.89]:22836 "HELO
	web39505.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1752953AbYHGGrH convert rfc822-to-8bit
	(ORCPT <rfc822;kvm@vger.kernel.org>); Thu, 7 Aug 2008 02:47:07 -0400
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


If I remove the "flags" parameter from the call to anon_inode_getfd in =
the function kvm_anon_inode_getfd=20
It compiles but I get a warning.

 CC [M]  /usr/src/kvm-72/kernel/anon_inodes.o
/usr/src/kvm-72/kernel/anon_inodes.c: In function =E2=80=98kvm_anon_ino=
de_getfd=E2=80=99:
/usr/src/kvm-72/kernel/anon_inodes.c:254: warning: passing argument 2 o=
f =E2=80=98anon_inode_getfd=E2=80=99 from incompatible pointer type
  CC [M]  /usr/src/kvm-72/kernel/irq.o

So...
its late and I won't have time to try it tonight but there is a coding =
error there.

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,26)

int kvm_anon_inode_getfd(const char *name,
			 const struct file_operations *fops,
			 void *priv, int flags)
{
	int r;
	int fd;
	struct inode *inode;
	struct file *file;

	r =3D anon_inode_getfd(&fd, &inode, &file, name, fops, priv);
	if (r < 0)
		return r;
	return fd;
}

#else

int kvm_anon_inode_getfd(const char *name,
			 const struct file_operations *fops,
			 void *priv, int flags)
{
	return anon_inode_getfd(name, &fops, priv, flags);
}                                                  ^^^error=20

#endif



     =20