From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, Jiawen Wu <jiawenwu@trustnetic.com>,
Xingui Yang <yangxingui@huawei.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Zaiyu Wang <zaiyuwang@trustnetic.com>,
Christian Koue Muf <ckm@napatech.com>,
Serhii Iliushyk <sil-plv@napatech.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Jian Wang <jianwang@trustnetic.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Sunil Kumar Kori <skori@marvell.com>
Subject: Re: [PATCH] drivers/net: fix Tx packet prepare
Date: Wed, 19 Nov 2025 14:44:04 +0100 [thread overview]
Message-ID: <3449306.jE0xQCEvom@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F65575@smartserver.smartshare.dk>
19/11/2025 14:19, Morten Brørup:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, 19 November 2025 14.04
> >
> > After removing callback checks from ethdev fast path,
> > some drivers crashed because tx_pkt_prepare was set to NULL.
> >
> > Some drivers (hns3, ngbe, txgbe) need to use
> > rte_eth_tx_pkt_prepare_dummy
> > when configuring queues.
> > Other drivers (ntnic, softnic) does not need to set tx_pkt_prepare
> > as it was set by eth_dev_set_dummy_fops() called by
> > rte_eth_dev_allocate().
> >
> > Bugzilla ID: 1834
> > Fixes: 066f3d9cc21c ("ethdev: remove callback checks from fast path")
> >
> > Reported-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> Searching for "tx_pkt_prepare = NULL;" finds a few more, but they are all in driver cleanup functions, so...
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Yes I am working on the cleanup side.
But there is no bug in cleanup, it will be a cleanup of cleanup ;)
So cleanup will be handled after 25.11 release.
next prev parent reply other threads:[~2025-11-19 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:03 [PATCH] drivers/net: fix Tx packet prepare Thomas Monjalon
2025-11-19 13:19 ` Morten Brørup
2025-11-19 13:44 ` Thomas Monjalon [this message]
2025-11-19 13:50 ` Morten Brørup
2025-11-20 1:57 ` Jiawen Wu
2025-11-20 5:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3449306.jE0xQCEvom@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ckm@napatech.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=mb@smartsharesystems.com \
--cc=sil-plv@napatech.com \
--cc=skori@marvell.com \
--cc=yangxingui@huawei.com \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.