Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100

[Thomas Monjalon <thomas@monjalon.net>]

08/06/2020 18:46, Bruce Richardson:
> Rather than continuing to recommend an 80-char line limit, let's take a hint
> from the Linux kernel[1] and aim for an 100-char recommended limit instead.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> -length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
> +length=${DPDK_CHECKPATCH_LINE_LENGTH:-100}

This is my personnal settings for years.

[...]
> -Line length is recommended to be not more than 80 characters, including comments.
> +Line length is recommended to be not more than 100 characters, including comments.

I think lines of 80 characters are reasonnable,
but I would not reject a patch because few lines are between 80 and 100.

I would reword the doc to reflect that flexibility:
"
Line length is recommended to be not more than 80 characters, including comments.
The hard limit is 100 characters.
"