From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Kieran Bingham Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API Date: Fri, 14 Jul 2017 02:04:06 +0300 Message-ID: <3451025.QtdIjcAE8v@avalon> In-Reply-To: <915884a5-e69d-b821-4a53-afa73a03c233@gmail.com> References: <20170626181226.29575-1-laurent.pinchart+renesas@ideasonboard.com> <20170626181226.29575-7-laurent.pinchart+renesas@ideasonboard.com> <915884a5-e69d-b821-4a53-afa73a03c233@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-ID: Hi Kieran, On Thursday 13 Jul 2017 14:16:03 Kieran Bingham wrote: > On 26/06/17 19:12, Laurent Pinchart wrote: > > In the H3 ES2.0 SoC the VSP2-DL instance has two connections to DU > > channels that need to be configured independently. Extend the VSP-DU API > > with a pipeline index to identify which pipeline the caller wants to > > operate on. > > > > Signed-off-by: Laurent Pinchart > > > > A bit of comment merge between this and the next patch but it's minor and > not worth the effort to change that ... so I'll happily ignore it if you do > :) > > Reviewed-by: Kieran Bingham > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 ++++++------ > > drivers/media/platform/vsp1/vsp1_drm.c | 32 +++++++++++++++++++-------- > > include/media/vsp1.h | 10 ++++++---- > > 3 files changed, 34 insertions(+), 20 deletions(-) [snip] > > diff --git a/drivers/media/platform/vsp1/vsp1_drm.c > > b/drivers/media/platform/vsp1/vsp1_drm.c index c72d021ff820..daaafe7885fa > > 100644 > > --- a/drivers/media/platform/vsp1/vsp1_drm.c > > +++ b/drivers/media/platform/vsp1/vsp1_drm.c > > @@ -58,21 +58,26 @@ EXPORT_SYMBOL_GPL(vsp1_du_init); > > /** > > * vsp1_du_setup_lif - Setup the output part of the VSP pipeline > > * @dev: the VSP device > > + * @pipe_index: the DRM pipeline index > > * @cfg: the LIF configuration > > * > > * Configure the output part of VSP DRM pipeline for the given frame > > @cfg.width > > - * and @cfg.height. This sets up formats on the BRU source pad, the WPF0 > > sink > > - * and source pads, and the LIF sink pad. > > + * and @cfg.height. This sets up formats on the blend unit (BRU or BRS) > > source > > + * pad, the WPF sink and source pads, and the LIF sink pad. > > * > > - * As the media bus code on the BRU source pad is conditioned by the > > - * configuration of the BRU sink 0 pad, we also set up the formats on all > > BRU > > + * The @pipe_index argument selects which DRM pipeline to setup. The > > number of > > + * available pipelines depend on the VSP instance. > > + * > > + * As the media bus code on the blend unit source pad is conditioned by > > the > > + * configuration of its sink 0 pad, we also set up the formats on all > > blend unit > > * sinks, even if the configuration will be overwritten later by > > - * vsp1_du_setup_rpf(). This ensures that the BRU configuration is set to > > a well > > - * defined state. > > + * vsp1_du_setup_rpf(). This ensures that the blend unit configuration is > > set to > > + * a well defined state. > > I presume those comment updates for the BRU/ blend-unit configuration are > actually for the next patch - but I don't think it matters here - and isn't > worth the effort to move the hunks. Too late, I've fixed it already :-) Thanks for pointing it out. > It all reads OK. > > > * > > * Return 0 on success or a negative error code on failure. > > */ > > -int vsp1_du_setup_lif(struct device *dev, const struct vsp1_du_lif_config > > *cfg) > > +int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index, > > + const struct vsp1_du_lif_config *cfg) > > { > > struct vsp1_device *vsp1 = dev_get_drvdata(dev); > > struct vsp1_pipeline *pipe = &vsp1->drm->pipe; [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API Date: Fri, 14 Jul 2017 02:04:06 +0300 Message-ID: <3451025.QtdIjcAE8v@avalon> References: <20170626181226.29575-1-laurent.pinchart+renesas@ideasonboard.com> <20170626181226.29575-7-laurent.pinchart+renesas@ideasonboard.com> <915884a5-e69d-b821-4a53-afa73a03c233@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68A2A6E19A for ; Thu, 13 Jul 2017 23:04:03 +0000 (UTC) In-Reply-To: <915884a5-e69d-b821-4a53-afa73a03c233@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gVGh1cnNkYXkgMTMgSnVsIDIwMTcgMTQ6MTY6MDMgS2llcmFuIEJpbmdo YW0gd3JvdGU6Cj4gT24gMjYvMDYvMTcgMTk6MTIsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4g PiBJbiB0aGUgSDMgRVMyLjAgU29DIHRoZSBWU1AyLURMIGluc3RhbmNlIGhhcyB0d28gY29ubmVj dGlvbnMgdG8gRFUKPiA+IGNoYW5uZWxzIHRoYXQgbmVlZCB0byBiZSBjb25maWd1cmVkIGluZGVw ZW5kZW50bHkuIEV4dGVuZCB0aGUgVlNQLURVIEFQSQo+ID4gd2l0aCBhIHBpcGVsaW5lIGluZGV4 IHRvIGlkZW50aWZ5IHdoaWNoIHBpcGVsaW5lIHRoZSBjYWxsZXIgd2FudHMgdG8KPiA+IG9wZXJh dGUgb24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IExhdXJlbnQgUGluY2hhcnQKPiA+IDxsYXVy ZW50LnBpbmNoYXJ0K3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPiBBIGJpdCBvZiBjb21t ZW50IG1lcmdlIGJldHdlZW4gdGhpcyBhbmQgdGhlIG5leHQgcGF0Y2ggYnV0IGl0J3MgbWlub3Ig YW5kCj4gbm90IHdvcnRoIHRoZSBlZmZvcnQgdG8gY2hhbmdlIHRoYXQgLi4uIHNvIEknbGwgaGFw cGlseSBpZ25vcmUgaXQgaWYgeW91IGRvCj4gOikKPiAKPiBSZXZpZXdlZC1ieTogS2llcmFuIEJp bmdoYW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KPiAKPiA+IC0t LQo+ID4gCj4gPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYyAgfCAxMiAr KysrKystLS0tLS0KPiA+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0uYyB8 IDMyICsrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ID4gIGluY2x1ZGUvbWVkaWEvdnNwMS5o ICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKysrLS0tLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwg MzQgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCgpbc25pcF0KCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMKPiA+IGIvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMgaW5kZXggYzcyZDAyMWZmODIwLi5kYWFhZmU3 ODg1ZmEKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3Zz cDFfZHJtLmMKPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5j Cj4gPiBAQCAtNTgsMjEgKzU4LDI2IEBAIEVYUE9SVF9TWU1CT0xfR1BMKHZzcDFfZHVfaW5pdCk7 Cj4gPiAgLyoqCj4gPiAgICogdnNwMV9kdV9zZXR1cF9saWYgLSBTZXR1cCB0aGUgb3V0cHV0IHBh cnQgb2YgdGhlIFZTUCBwaXBlbGluZQo+ID4gICAqIEBkZXY6IHRoZSBWU1AgZGV2aWNlCj4gPiAr ICogQHBpcGVfaW5kZXg6IHRoZSBEUk0gcGlwZWxpbmUgaW5kZXgKPiA+ICAgKiBAY2ZnOiB0aGUg TElGIGNvbmZpZ3VyYXRpb24KPiA+ICAgKgo+ID4gICAqIENvbmZpZ3VyZSB0aGUgb3V0cHV0IHBh cnQgb2YgVlNQIERSTSBwaXBlbGluZSBmb3IgdGhlIGdpdmVuIGZyYW1lCj4gPiAgIEBjZmcud2lk dGgKPiA+IC0gKiBhbmQgQGNmZy5oZWlnaHQuIFRoaXMgc2V0cyB1cCBmb3JtYXRzIG9uIHRoZSBC UlUgc291cmNlIHBhZCwgdGhlIFdQRjAKPiA+IHNpbmsKPiA+IC0gKiBhbmQgc291cmNlIHBhZHMs IGFuZCB0aGUgTElGIHNpbmsgcGFkLgo+ID4gKyAqIGFuZCBAY2ZnLmhlaWdodC4gVGhpcyBzZXRz IHVwIGZvcm1hdHMgb24gdGhlIGJsZW5kIHVuaXQgKEJSVSBvciBCUlMpCj4gPiBzb3VyY2UKPiA+ ICsgKiBwYWQsIHRoZSBXUEYgc2luayBhbmQgc291cmNlIHBhZHMsIGFuZCB0aGUgTElGIHNpbmsg cGFkLgo+ID4gICAqCj4gPiAtICogQXMgdGhlIG1lZGlhIGJ1cyBjb2RlIG9uIHRoZSBCUlUgc291 cmNlIHBhZCBpcyBjb25kaXRpb25lZCBieSB0aGUKPiA+IC0gKiBjb25maWd1cmF0aW9uIG9mIHRo ZSBCUlUgc2luayAwIHBhZCwgd2UgYWxzbyBzZXQgdXAgdGhlIGZvcm1hdHMgb24gYWxsCj4gPiBC UlUKPiA+ICsgKiBUaGUgQHBpcGVfaW5kZXggYXJndW1lbnQgc2VsZWN0cyB3aGljaCBEUk0gcGlw ZWxpbmUgdG8gc2V0dXAuIFRoZQo+ID4gbnVtYmVyIG9mCj4gPiArICogYXZhaWxhYmxlIHBpcGVs aW5lcyBkZXBlbmQgb24gdGhlIFZTUCBpbnN0YW5jZS4KPiA+ICsgKgo+ID4gKyAqIEFzIHRoZSBt ZWRpYSBidXMgY29kZSBvbiB0aGUgYmxlbmQgdW5pdCBzb3VyY2UgcGFkIGlzIGNvbmRpdGlvbmVk IGJ5Cj4gPiB0aGUKPiA+ICsgKiBjb25maWd1cmF0aW9uIG9mIGl0cyBzaW5rIDAgcGFkLCB3ZSBh bHNvIHNldCB1cCB0aGUgZm9ybWF0cyBvbiBhbGwKPiA+IGJsZW5kIHVuaXQKPiA+ICAgKiBzaW5r cywgZXZlbiBpZiB0aGUgY29uZmlndXJhdGlvbiB3aWxsIGJlIG92ZXJ3cml0dGVuIGxhdGVyIGJ5 Cj4gPiAtICogdnNwMV9kdV9zZXR1cF9ycGYoKS4gVGhpcyBlbnN1cmVzIHRoYXQgdGhlIEJSVSBj b25maWd1cmF0aW9uIGlzIHNldCB0bwo+ID4gYSB3ZWxsCj4gPiAtICogZGVmaW5lZCBzdGF0ZS4K PiA+ICsgKiB2c3AxX2R1X3NldHVwX3JwZigpLiBUaGlzIGVuc3VyZXMgdGhhdCB0aGUgYmxlbmQg dW5pdCBjb25maWd1cmF0aW9uIGlzCj4gPiBzZXQgdG8KPiA+ICsgKiBhIHdlbGwgZGVmaW5lZCBz dGF0ZS4KPiAKPiBJIHByZXN1bWUgdGhvc2UgY29tbWVudCB1cGRhdGVzIGZvciB0aGUgQlJVLyBi bGVuZC11bml0IGNvbmZpZ3VyYXRpb24gYXJlCj4gYWN0dWFsbHkgZm9yIHRoZSBuZXh0IHBhdGNo IC0gYnV0IEkgZG9uJ3QgdGhpbmsgaXQgbWF0dGVycyBoZXJlIC0gYW5kIGlzbid0Cj4gd29ydGgg dGhlIGVmZm9ydCB0byBtb3ZlIHRoZSBodW5rcy4KClRvbyBsYXRlLCBJJ3ZlIGZpeGVkIGl0IGFs cmVhZHkgOi0pIFRoYW5rcyBmb3IgcG9pbnRpbmcgaXQgb3V0LgoKPiBJdCBhbGwgcmVhZHMgT0su Cj4gCj4gPiAgICoKPiA+ICAgKiBSZXR1cm4gMCBvbiBzdWNjZXNzIG9yIGEgbmVnYXRpdmUgZXJy b3IgY29kZSBvbiBmYWlsdXJlLgo+ID4gICAqLwo+ID4gLWludCB2c3AxX2R1X3NldHVwX2xpZihz dHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0IHN0cnVjdCB2c3AxX2R1X2xpZl9jb25maWcKPiA+ICpj ZmcpCj4gPiAraW50IHZzcDFfZHVfc2V0dXBfbGlmKHN0cnVjdCBkZXZpY2UgKmRldiwgdW5zaWdu ZWQgaW50IHBpcGVfaW5kZXgsCj4gPiArCQkgICAgICBjb25zdCBzdHJ1Y3QgdnNwMV9kdV9saWZf Y29uZmlnICpjZmcpCj4gPiAgewo+ID4gIAlzdHJ1Y3QgdnNwMV9kZXZpY2UgKnZzcDEgPSBkZXZf Z2V0X2RydmRhdGEoZGV2KTsKPiA+ICAJc3RydWN0IHZzcDFfcGlwZWxpbmUgKnBpcGUgPSAmdnNw MS0+ZHJtLT5waXBlOwoKW3NuaXBdCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=