From: Thomas Monjalon <thomas@monjalon.net>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Ergin, Mesut A" <mesut.a.ergin@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx
Date: Wed, 22 May 2019 16:05:04 +0200 [thread overview]
Message-ID: <3457411.zOjnD88UkL@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com>
Hi,
22/05/2019 13:01, Ananyev, Konstantin:
> > As far as I can see, passing FDIR configuration via the rte_eth_conf struct:
> > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. DEPRECATED */
> > was deprecated. I suspect in favor of the late binding design mentioned, but
> > again, I don't know the history on that. IMO, this made devargs a better choice.
>
> Ok, then it looks like there is a flaw in ethdev level API that needs to be fixed:
> We deprecated old way to request FD usage without introducing new one.
> CC-ing to ethdev maintainers -
> Guys is there a new way to request FD enablement, instead of deprecated fdir_config?
> Seems like not, unless I missed something obvious.
> If not, then we probably need either to re-deprecate fdir_config, or introduce some new method.
> My first thought would be to add new DEV_RX_OFFLOAD_* flag(s).
> Does it make sense?
Sorry,I have not read the full thread so I may be out of topic.
Please be aware that the flow director API is deprecated in favor
of the more generic rte_flow API.
next prev parent reply other threads:[~2019-05-22 14:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 4:28 [dpdk-dev] [PATCH 0/3] net/i40e: improve rte_flow offload with MARK + RSS Mesut Ali Ergin
2019-05-16 4:28 ` [dpdk-dev] [PATCH 1/3] net/i40e: add support for MARK + RSS action in rte_flow Mesut Ali Ergin
2019-05-22 12:30 ` Zhang, Qi Z
2019-05-16 4:28 ` [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx Mesut Ali Ergin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 21:26 ` Ergin, Mesut A
2019-05-20 8:29 ` Ananyev, Konstantin
2019-05-20 17:53 ` Ergin, Mesut A
2019-05-20 23:11 ` Ananyev, Konstantin
2019-05-21 16:33 ` Ergin, Mesut A
2019-05-21 17:20 ` Ananyev, Konstantin
2019-05-21 20:55 ` Ergin, Mesut A
2019-05-22 11:01 ` Ananyev, Konstantin
2019-05-22 14:05 ` Thomas Monjalon [this message]
2019-05-22 14:32 ` Zhang, Qi Z
2019-05-23 13:10 ` Jerin Jacob Kollanukkaran
2019-05-23 17:54 ` Ergin, Mesut A
2019-05-16 4:28 ` [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance Mesut Ali Ergin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 20:57 ` Ergin, Mesut A
2019-05-22 12:42 ` Zhang, Qi Z
2019-05-23 18:25 ` Ergin, Mesut A
2019-05-24 2:39 ` Zhang, Qi Z
2019-05-24 18:08 ` Ergin, Mesut A
2019-05-25 11:29 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3457411.zOjnD88UkL@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mesut.a.ergin@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.