Re: [PATCH][2.4] generic support for systems with more than 8 CPUs (2/2)

["Martin J. Bligh" <mbligh@aracnet.com>]

> +#ifdef CONFIG_X86_CLUSTERED_APIC
> +	/*
> +	 * Switch to Physical destination mode in case of generic
> +	 * more than 8 CPU system, which has xAPIC support
> +	 */
> +#define FLAT_APIC_CPU_MAX	8
> +	if ((clustered_apic_mode == CLUSTERED_APIC_NONE) &&
> +	    (xapic_support) &&
> +	    (num_processors > FLAT_APIC_CPU_MAX)) {
> +		clustered_apic_mode = CLUSTERED_APIC_XAPIC;
> +		apic_broadcast_id = APIC_BROADCAST_ID_XAPIC;
> +		int_dest_addr_mode = APIC_DEST_PHYSICAL;
> +		int_delivery_mode = dest_Fixed;
> +		esr_disable = 1;
> +	}
> +#endif

If you could stick the #define up in a header file somewhere, would
be more standard / neater. Otherwise that looks good to me ...

Thanks for cleaning all this stuff up - the new set is much less
invasive, and easier to read than the last set ;-)

M.