From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:37330 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964811AbcDYVKw (ORCPT ); Mon, 25 Apr 2016 17:10:52 -0400 From: Laurent Pinchart To: Sergei Shtylyov Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits Date: Tue, 26 Apr 2016 00:11:15 +0300 Message-ID: <3463066.Db4xpr3SQR@avalon> In-Reply-To: <2036550.BKBaf2zquB@wasted.cogentembedded.com> References: <2036550.BKBaf2zquB@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, Thank you for the patch. On Saturday 23 Apr 2016 01:56:07 Sergei Shtylyov wrote: > The TCNE2 bit of the DEFR6 register was renamed to TCNE1 in the R-Car gen2 > manuals -- which makes more sense as that bit controls whether DU1, not > DU2 is connected to TCON. > > While at it, add the TCNE0 bit which controls whether DU0 is connected to > TCON. > > Based on the large patch by Andrey Gusakov > . > > Signed-off-by: Andrey Gusakov > Signed-off-by: Sergei Shtylyov Acked-by: Laurent Pinchart and applied to my tree. > --- > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. > > drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > Index: linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h > =================================================================== > --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_regs.h > +++ linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h > @@ -195,9 +195,10 @@ > #define DEFR6_ODPM12_DISP (2 << 8) > #define DEFR6_ODPM12_CDE (3 << 8) > #define DEFR6_ODPM12_MASK (3 << 8) > -#define DEFR6_TCNE2 (1 << 6) > +#define DEFR6_TCNE1 (1 << 6) > +#define DEFR6_TCNE0 (1 << 4) > #define DEFR6_MLOS1 (1 << 2) > -#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE2) > +#define DEFR6_DEFAULT (DEFR6_CODE | DEFR6_TCNE1) > > /* ------------------------------------------------------------------------ > * R8A7790-only Control Registers -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits Date: Tue, 26 Apr 2016 00:11:15 +0300 Message-ID: <3463066.Db4xpr3SQR@avalon> References: <2036550.BKBaf2zquB@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09E056E68F for ; Mon, 25 Apr 2016 21:10:52 +0000 (UTC) In-Reply-To: <2036550.BKBaf2zquB@wasted.cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBTYXR1cmRheSAyMyBBcHIg MjAxNiAwMTo1NjowNyBTZXJnZWkgU2h0eWx5b3Ygd3JvdGU6Cj4gVGhlICBUQ05FMiBiaXQgIG9m IHRoZSBERUZSNiByZWdpc3RlciB3YXMgcmVuYW1lZCB0byBUQ05FMSBpbiB0aGUgUi1DYXIgZ2Vu Mgo+IG1hbnVhbHMgLS0gd2hpY2ggbWFrZXMgbW9yZSAgc2Vuc2UgYXMgdGhhdCBiaXQgY29udHJv bHMgd2hldGhlciBEVTEsIG5vdAo+IERVMiBpcyBjb25uZWN0ZWQgdG8gVENPTi4KPiAKPiBXaGls ZSBhdCBpdCwgYWRkIHRoZSBUQ05FMCBiaXQgd2hpY2ggY29udHJvbHMgd2hldGhlciBEVTAgaXMg Y29ubmVjdGVkIHRvCj4gVENPTi4KPiAKPiBCYXNlZCBvbiB0aGUgbGFyZ2UgcGF0Y2ggYnkgQW5k cmV5IEd1c2Frb3YKPiA8YW5kcmV5Lmd1c2Frb3ZAY29nZW50ZW1iZWRkZWQuY29tPi4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBBbmRyZXkgR3VzYWtvdiA8YW5kcmV5Lmd1c2Frb3ZAY29nZW50ZW1iZWRk ZWQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNlcmdlaSBTaHR5bHlvdiA8c2VyZ2VpLnNodHlseW92 QGNvZ2VudGVtYmVkZGVkLmNvbT4KCkFja2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CgphbmQgYXBwbGllZCB0byBteSB0cmVlLgoKPiAt LS0KPiBUaGUgcGF0Y2ggaXMgYWdhaW5zdCBEYXZpZCBBaXJsaWUncyAnbGludXguZ2l0JyByZXBv J3MgJ2RybS1uZXh0JyBicmFuY2guCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfcmVncy5oIHwgICAgNSArKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+IAo+IEluZGV4OiBsaW51eC9kcml2ZXJzL2dwdS9kcm0vcmNhci1k dS9yY2FyX2R1X3JlZ3MuaAo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiAtLS0gbGludXgub3JpZy9kcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X3JlZ3MuaAo+ICsrKyBsaW51eC9kcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X3JlZ3MuaAo+IEBAIC0xOTUsOSArMTk1LDEwIEBACj4gICNkZWZpbmUg REVGUjZfT0RQTTEyX0RJU1AJKDIgPDwgOCkKPiAgI2RlZmluZSBERUZSNl9PRFBNMTJfQ0RFCSgz IDw8IDgpCj4gICNkZWZpbmUgREVGUjZfT0RQTTEyX01BU0sJKDMgPDwgOCkKPiAtI2RlZmluZSBE RUZSNl9UQ05FMgkJKDEgPDwgNikKPiArI2RlZmluZSBERUZSNl9UQ05FMQkJKDEgPDwgNikKPiAr I2RlZmluZSBERUZSNl9UQ05FMAkJKDEgPDwgNCkKPiAgI2RlZmluZSBERUZSNl9NTE9TMQkJKDEg PDwgMikKPiAtI2RlZmluZSBERUZSNl9ERUZBVUxUCQkoREVGUjZfQ09ERSB8IERFRlI2X1RDTkUy KQo+ICsjZGVmaW5lIERFRlI2X0RFRkFVTFQJCShERUZSNl9DT0RFIHwgREVGUjZfVENORTEpCj4g Cj4gIC8qIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgKiBSOEE3NzkwLW9ubHkgQ29udHJvbCBSZWdpc3Rl cnMKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==