From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line Date: Wed, 28 May 2014 13:24:51 +0200 Message-ID: <3463654.chnlgr18TH@xps13> References: <1589072.KAuytnYNqt@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Burakov, Anatoly" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-28 10:35, Burakov, Anatoly: > Hi Thomas, > > > > + } > > > > > > else if (!strcmp(lgopts[option_index].name, > > > > OPT_CREATE_UIO_DEV)) > > > > another code style issue reported by checkpatch.pl ;) > > > > But it should be fixed by removing this code as Stephen suggests. > > I'm not sure this could should be removed. Igb_uio allows to pick interrupt > mode, so why not VFIO? I've modified my code to try all interrupt modes if > nothing was explicitly specified, but why should that preclude the user > from selecting a specific interrupt type if he so desires? > > As for the style error - the whole chunk of code uses the same style there, > so either we fix all of that (in a separate patch?), or leave it as it is. OK to leave it as is. But please, let's try to keep a clean code style. About existing code style issues, separated patches for cleaning should be well accepted. Thanks -- Thomas