All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Chun-Tse Shao <ctshao@google.com>,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	namhyung@kernel.org
Cc: alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	adrian.hunter@intel.com, james.clark@linaro.org,
	afaerber@suse.de, mani@kernel.org, thomas.falcon@intel.com,
	irogers@google.com, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] perf vendor events intel: Fix Novalake CPUID regex in mapfile.csv
Date: Tue, 4 Aug 2026 09:25:12 +0800	[thread overview]
Message-ID: <34636d29-febf-47c8-91c3-089a507cfdfb@linux.intel.com> (raw)
In-Reply-To: <20260803215028.834556-1-ctshao@google.com>

LGTM. Thanks.

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

On 8/4/2026 5:50 AM, Chun-Tse Shao wrote:
> Based on offline discussion with Intel in
> lore.kernel.org/20260715211144.3144895-1-ctshao@google.com, we decided
> to drop the leading zero from Nova Lake models 0x01 and 0x03 in
> mapfile.csv to match single-digit model numbers without zero padding
> (GenuineIntel-18-[13]).
>
> The updated mapfile entry was published in:
> github.com/intel/perfmon/commit/00167baed45ac3b2708e89dbf1b9ce4769e9d115
>
> Signed-off-by: Chun-Tse Shao <ctshao@google.com>
> ---
>  tools/perf/pmu-events/arch/x86/mapfile.csv | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
> index 8e4ee898942c..e5d90825041b 100644
> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
> @@ -39,7 +39,7 @@ GenuineIntel-6-8[CD],v1.19,tigerlake,core
>  GenuineIntel-6-2C,v5,westmereep-dp,core
>  GenuineIntel-6-25,v4,westmereep-sp,core
>  GenuineIntel-6-2F,v4,westmereex,core
> -GenuineIntel-18-0[13],v1.00,novalake,core
> +GenuineIntel-18-[13],v1.00,novalake,core
>  AuthenticAMD-23-([12][0-9A-F]|[0-9A-F]),v2,amdzen1,core
>  AuthenticAMD-23-[[:xdigit:]]+,v1,amdzen2,core
>  AuthenticAMD-25-([245][[:xdigit:]]|[[:xdigit:]]),v1,amdzen3,core

  reply	other threads:[~2026-08-04  1:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 21:50 [PATCH v1 1/1] perf vendor events intel: Fix Novalake CPUID regex in mapfile.csv Chun-Tse Shao
2026-08-04  1:25 ` Mi, Dapeng [this message]
2026-08-05 18:28 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34636d29-febf-47c8-91c3-089a507cfdfb@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=afaerber@suse.de \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ctshao@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.