Re: [PATCH] examples/flow_filtering: fix destination IP mask

[Thomas Monjalon <thomas@monjalon.net>]

10/03/2025 07:48, Shani Peretz:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 12/01/2025 08:52, Shani Peretz:
> > > This patch corrects the destination IP address mask to restore the
> > > previous implementation's behavior.
> > >
> > > Also it fixes a misuse of rte_flow_item_tcp struct.
> > > Replace it with the appropriate rte_flow_item_ipv4 struct, as the code
> > > in this context filters ipv4 traffic.
> > >
> > > Fixes: 16158f349000 ("examples/flow_filtering: introduce use cases
> > > snippets")
> > >
> > > Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> > [...]
> > > @@ -77,7 +77,7 @@ snippet_ipv4_flow_create_actions_template(uint16_t
> > port_id, struct rte_flow_erro
> > >       };
> > >
> > >       tactions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE;
> > > -     tactions[0].type = RTE_FLOW_ACTION_TYPE_END;
> > > +     tactions[1].type = RTE_FLOW_ACTION_TYPE_END;
> > 
> > It is a revert of this recent commit:
> > https://git.dpdk.org/dpdk/commit/?id=7d73fa47f4
> > 
> > Do you confirm you want to keep RTE_FLOW_ACTION_TYPE_QUEUE here?
> > 
> 
> Yes to be consistent with the non-template API.

Applied, thanks.