Re: [PATCH 3/4] ARM: shmobile: r8a7790: add I2C support

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Morimoto-san,

On Sunday 01 December 2013 17:32:37 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > > @@ -76,6 +97,10 @@ void __init r8a7790_pinmux_init(void)
> > > 
> > >  	r8a7790_register_gpio(3);
> > >  	r8a7790_register_gpio(4);
> > >  	r8a7790_register_gpio(5);
> > > 
> > > +	r8a7790_register_i2c(0);
> > > +	r8a7790_register_i2c(1);
> > > +	r8a7790_register_i2c(2);
> > > +	r8a7790_register_i2c(3);
> > > 
> > >  }
> > 
> > I might be wrong, but I believe we have been requested to add new devices
> > directly to the board-*.c files, not to the setup-*.c files.
> 
> It depends on device.
> I2C host doesn't request board/platform information,
> so, setup-xxxx.c is fine.
> Please check other setup-xxx.c

Sure, that's how it's currently done for other SoCs, but I thought we were 
asked to change that for new patches. I might be wrong, Magnus, Simon, could 
you please comment on this ?

-- 
Regards,

Laurent Pinchart