From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55B1C2F23 for ; Tue, 8 Feb 2022 13:56:34 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id f17so20537988edd.2 for ; Tue, 08 Feb 2022 05:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=o66uVybAfrBRcV0gBzAqSGyDxUnpGYlHK6KCm3kDwxiHu/vRA1m8J/dYohiL3n9Za5 MNrgvt72faoBRIFZPnmPPkrpxBvIcVIC0Pe+B/ByL85ExHwZYANJGS49c3khtXizgw1O cO5aFXwKsWjEE2MikbNR20nt5n5TT5KYggztdM2PfQ7yVHPg73GnLtGqPjGitNbMV4xJ z6k9+ba9gGTqK9cBX6+1qtiuEz4kFSooOoikQFPW5XWikQzezt0GGj3RfhUcAzz+NrMv gaiowJoGdJg3jm1tCVIGng+x1X2/JeEmmPvvTqfBESM0r84x7GdJ3rdtt/KeNL+V2IXw JhqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=wVVUPPrxcoYBfWEzCbmmFN1x+ySjsw4r0Sw2TNlXzaJDgxF53UQZff+sESdKP1mRMC QS/F/Q6YgVzpO64u95rg64cyptckWtjSCBMevnK8gdSSY0SfOZBzfS6I6gZoqDgMDnnt WtnRCjafHUDXdVXyeVCiuWcqDes/Yy/oMEe2kP+YvYCaPsxlK665wtsQgR7fOVxt7sti 0z4g3NH5iTJfWWwkc+v33/1kPTFNpoRGkeBmyvk+Vo+lSkyIQcWQ4wbFIv9OJC6IUMWY LKXN51mcI29IWGVph19RXHQwS/iB523mgN6r1osXj6al/ZvPFeY9RKDutbonzj8nBU+p 7HvA== X-Gm-Message-State: AOAM530jF989XghiSYAt78x53FoPuGX7XB8+ruNbXwd/QRCFse3Z8RID f/LAAwSFrS2cGipijuvKFtE= X-Google-Smtp-Source: ABdhPJz3LX7wIZPAbp6gWO8Drhb3MvhaAYJoOWHVG2tsxZV9Z+BCcBLk/+m7XzGikZs67sbnnktU/w== X-Received: by 2002:aa7:c043:: with SMTP id k3mr4546167edo.184.1644328592616; Tue, 08 Feb 2022 05:56:32 -0800 (PST) Received: from jernej-laptop.localnet (89-212-178-211.dynamic.t-2.net. [89.212.178.211]) by smtp.gmail.com with ESMTPSA id t8sm1620679eji.94.2022.02.08.05.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 05:56:32 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Daniel Vetter , David Airlie , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai Subject: Re: [PATCH 18/23] drm/sun4i: layer: Remove redundant zpos initialisation Date: Tue, 08 Feb 2022 14:56:29 +0100 Message-ID: <3469895.R56niFO833@jernej-laptop> In-Reply-To: <20220207163515.1038648-19-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-19-maxime@cerno.tech> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Maxime, Dne ponedeljek, 07. februar 2022 ob 17:35:10 CET je Maxime Ripard napisal(a): > The sun4i KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in sun4i_backend_layer_reset(). > However, the helpers have been adjusted to set it properly at reset, so > this is not needed anymore. > > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE133C433F5 for ; Tue, 8 Feb 2022 13:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yq565k6+L3mHgWQi5IkSI991R1DgYDGojYHQnY1WNXY=; b=JVHoELxz9/qXC9 LWiX5uIIo2nJ+IS+wqp1SQ2K1B7kAVmpi2dbApEB9lL2kpHBQvijVGhBdzMAYXYi19+NcK6FQN++i qxPiGa3+HV+rRFnmmN1QZ3VUbOHrw/ic59KBQMUPQCz21d44VKIoH252UCiMYvwKKRm8E8w8xesK4 XWTZtzTqyHs3h67B3LyLg1DsTTPq7Icj2OvaAvKiLhv487XnefWgjQTLBqkGjdTny+Ij6cS3cdxoW iulgIIREMDZr1kdhC4zYrwzUxGkbIAzFROcZmf6Mdws6wlvrVcGD5bCDFzUmSrQVzirgK/j0mHPKA SSwUBg7zUMooTc869egA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHQz1-00EDxD-0S; Tue, 08 Feb 2022 13:56:39 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHQyy-00EDwA-12 for linux-arm-kernel@lists.infradead.org; Tue, 08 Feb 2022 13:56:37 +0000 Received: by mail-ed1-x52f.google.com with SMTP id ch26so1254535edb.12 for ; Tue, 08 Feb 2022 05:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=o66uVybAfrBRcV0gBzAqSGyDxUnpGYlHK6KCm3kDwxiHu/vRA1m8J/dYohiL3n9Za5 MNrgvt72faoBRIFZPnmPPkrpxBvIcVIC0Pe+B/ByL85ExHwZYANJGS49c3khtXizgw1O cO5aFXwKsWjEE2MikbNR20nt5n5TT5KYggztdM2PfQ7yVHPg73GnLtGqPjGitNbMV4xJ z6k9+ba9gGTqK9cBX6+1qtiuEz4kFSooOoikQFPW5XWikQzezt0GGj3RfhUcAzz+NrMv gaiowJoGdJg3jm1tCVIGng+x1X2/JeEmmPvvTqfBESM0r84x7GdJ3rdtt/KeNL+V2IXw JhqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=6PWUAhP9D65LOCU8WhwOps0Q9IeZ8nnAy6Z0Agut3WuXswq5raI8fNNSkn0EAgqPfz Ej+Wfz4xpT3tvsM7AQ7+rAxYCx6wYT8WcGiQ8M1nhHu0i3xEm9XGXd/vkQ3VNmja5aOw Loo9Q7ZiAcK1h9OYoBZMY5sbKn2Bp2CEiBi+utFJau1qR1NGUGaEuWhc8LtyL6T0Asc1 RsCmmHwhG/AKVnE/QDZIp92PgUBIW0LTzq8ZUUXfZq3EbYbFOXsHCFJG7zfK3+zYJHXn B4A5IADEev/EKwuzCZv5KUQa3GZT1iwD3Krq7J3cjUTHWi6V7vfpWS3AGPiRGGD6xmWt xP1g== X-Gm-Message-State: AOAM531JCBAFxT3xJvfmJ39OpmBdfm7K4mweVBhobfKT6g0VlDUyK1EI r/Y2wLSfx5qjs5W3iptj3Ko= X-Google-Smtp-Source: ABdhPJz3LX7wIZPAbp6gWO8Drhb3MvhaAYJoOWHVG2tsxZV9Z+BCcBLk/+m7XzGikZs67sbnnktU/w== X-Received: by 2002:aa7:c043:: with SMTP id k3mr4546167edo.184.1644328592616; Tue, 08 Feb 2022 05:56:32 -0800 (PST) Received: from jernej-laptop.localnet (89-212-178-211.dynamic.t-2.net. [89.212.178.211]) by smtp.gmail.com with ESMTPSA id t8sm1620679eji.94.2022.02.08.05.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 05:56:32 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Daniel Vetter , David Airlie , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai Subject: Re: [PATCH 18/23] drm/sun4i: layer: Remove redundant zpos initialisation Date: Tue, 08 Feb 2022 14:56:29 +0100 Message-ID: <3469895.R56niFO833@jernej-laptop> In-Reply-To: <20220207163515.1038648-19-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-19-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_055636_113553_46625ABD X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, Dne ponedeljek, 07. februar 2022 ob 17:35:10 CET je Maxime Ripard napisal(a): > The sun4i KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in sun4i_backend_layer_reset(). > However, the helpers have been adjusted to set it properly at reset, so > this is not needed anymore. > > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3E88C433EF for ; Tue, 8 Feb 2022 13:56:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 902DE10E4C6; Tue, 8 Feb 2022 13:56:35 +0000 (UTC) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B16810E587 for ; Tue, 8 Feb 2022 13:56:34 +0000 (UTC) Received: by mail-ed1-x52b.google.com with SMTP id eg42so21849696edb.7 for ; Tue, 08 Feb 2022 05:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=o66uVybAfrBRcV0gBzAqSGyDxUnpGYlHK6KCm3kDwxiHu/vRA1m8J/dYohiL3n9Za5 MNrgvt72faoBRIFZPnmPPkrpxBvIcVIC0Pe+B/ByL85ExHwZYANJGS49c3khtXizgw1O cO5aFXwKsWjEE2MikbNR20nt5n5TT5KYggztdM2PfQ7yVHPg73GnLtGqPjGitNbMV4xJ z6k9+ba9gGTqK9cBX6+1qtiuEz4kFSooOoikQFPW5XWikQzezt0GGj3RfhUcAzz+NrMv gaiowJoGdJg3jm1tCVIGng+x1X2/JeEmmPvvTqfBESM0r84x7GdJ3rdtt/KeNL+V2IXw JhqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1KYUsCDR1iSxVxCml/jhw/hl2p2+gvmglE1tOJdZtqM=; b=UnY5uNYkniahMWrJJvVWfZTp1ifQiXInw4tcujfzlo6dwPhi3yxbhUf6Wxz1yn0ec8 +UfXeO9AXr1VtNnxmUuyUj8iPmub29ZVNH0OvrliOF1xPFrH4Gj4UgbkLANDbm+SyYTG XzBVymD7JPueyzylUB4eKsqxN8cDZ2FaOSCMnsPxVnO/Zytk5y4x5VdN/+D+u8qs1G+J sK+ojzv+gV1kIROz4Dl2A3vfRZf9ywbMDGctkG1S+VIlEGMnpOAnteWS8di9/G3sJ4rw H5wIaetBdsGoLO0fXzdAYNF2m1kBXM2lz2nKxtVCgIE+rdI5GtzdepfLMUwQaGKYXHFu l77A== X-Gm-Message-State: AOAM530rafaWNadkMyZw7OhwsQU+LJweF7bUlMQ4MRX//KQMMjvk9mkT FedNjpB1z3HX2vtCz2R7KAo= X-Google-Smtp-Source: ABdhPJz3LX7wIZPAbp6gWO8Drhb3MvhaAYJoOWHVG2tsxZV9Z+BCcBLk/+m7XzGikZs67sbnnktU/w== X-Received: by 2002:aa7:c043:: with SMTP id k3mr4546167edo.184.1644328592616; Tue, 08 Feb 2022 05:56:32 -0800 (PST) Received: from jernej-laptop.localnet (89-212-178-211.dynamic.t-2.net. [89.212.178.211]) by smtp.gmail.com with ESMTPSA id t8sm1620679eji.94.2022.02.08.05.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 05:56:32 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Daniel Vetter , David Airlie , Maxime Ripard Subject: Re: [PATCH 18/23] drm/sun4i: layer: Remove redundant zpos initialisation Date: Tue, 08 Feb 2022 14:56:29 +0100 Message-ID: <3469895.R56niFO833@jernej-laptop> In-Reply-To: <20220207163515.1038648-19-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> <20220207163515.1038648-19-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Maxime Ripard , Thomas Zimmermann , Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, Dne ponedeljek, 07. februar 2022 ob 17:35:10 CET je Maxime Ripard napisal(a): > The sun4i KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in sun4i_backend_layer_reset(). > However, the helpers have been adjusted to set it properly at reset, so > this is not needed anymore. > > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Signed-off-by: Maxime Ripard Reviewed-by: Jernej Skrabec Best regards, Jernej