From: Keith Owens <kaos@ocs.com.au>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Andrew Morton <andrewm@uow.edu.au>,
Paul Gortmaker <p_gortmaker@yahoo.com>,
"David S. Miller" <davem@redhat.com>,
"'LKML'" <linux-kernel@vger.kernel.org>,
"'LNML'" <linux-net@vger.kernel.org>
Subject: Re: Locking Between User Context and Soft IRQs in 2.4.0
Date: Mon, 06 Nov 2000 23:58:05 +1100 [thread overview]
Message-ID: <3472.973515485@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Mon, 06 Nov 2000 07:49:00 CDT." <3A06A8BC.CE6F651F@mandrakesoft.com>
On Mon, 06 Nov 2000 07:49:00 -0500,
Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
>Keith Owens wrote:
>> I prefer a requirement that all net drivers upgrade to the new
>> interface, otherwise we have odd drivers using the old interface
>> forever and being at risk of module unload. That is why I coded my
>> patch as returning -ENODEV if there was no dev->open. However I have
>> to accept that just before a 2.4 release is not the best time to have a
>> flag day. Put it down for 2.5.
>
>What is "it" that gets put off until 2.5? Breaking net drivers with an
>interface upgrade, or eliminating this race?
Forcing all network drivers to define a dev->open routine.
>There is absolutely no need to break drivers for this. Not only is it
>needless pain, but doing so is inconsistent -- with struct
>file_operations, I am free to have owner==NULL.
True, but if you set owner==NULL for something that is really in a
module then you are lying to the module layer. See foot, shoot foot.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-06 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-30 14:10 Locking Between User Context and Soft IRQs in 2.4.0 Hen, Shmulik
2000-11-04 9:45 ` Jeff Garzik
2000-11-04 10:19 ` Andi Kleen
2000-11-04 15:36 ` Jeff Garzik
2000-11-04 16:56 ` Andi Kleen
2000-11-04 17:07 ` Jeff Garzik
2000-11-05 0:38 ` Andi Kleen
2000-11-05 1:28 ` Andrew Morton
2000-11-05 1:52 ` Andrew Morton
2000-11-05 2:32 ` Andi Kleen
2000-11-05 3:39 ` Keith Owens
2000-11-05 3:47 ` Keith Owens
2000-11-05 11:45 ` Andrew Morton
2000-11-06 2:20 ` Paul Gortmaker
2000-11-06 9:55 ` Andrew Morton
2000-11-06 10:05 ` Jeff Garzik
2000-11-06 12:37 ` Keith Owens
2000-11-06 12:49 ` Jeff Garzik
2000-11-06 12:58 ` Keith Owens [this message]
2000-11-06 13:09 ` Jeff Garzik
2000-11-06 13:18 ` Keith Owens
2000-11-07 2:23 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3472.973515485@ocs3.ocs-net \
--to=kaos@ocs.com.au \
--cc=andrewm@uow.edu.au \
--cc=davem@redhat.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.