From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 3/8] inet: implement lockless IP_TOS
Date: Thu, 21 Sep 2023 13:10:13 -0600 [thread overview]
Message-ID: <3473bea6-00c8-2949-5029-122b599be9b2@kernel.org> (raw)
In-Reply-To: <20230921133021.1995349-4-edumazet@google.com>
On 9/21/23 7:30 AM, Eric Dumazet wrote:
> Some reads of inet->tos are racy.
>
> Add needed READ_ONCE() annotations and convert IP_TOS option lockless.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/net/ip.h | 1 -
> net/dccp/ipv4.c | 2 +-
> net/ipv4/inet_diag.c | 2 +-
> net/ipv4/ip_output.c | 4 +--
> net/ipv4/ip_sockglue.c | 29 ++++++++-----------
> net/ipv4/tcp_ipv4.c | 9 +++---
> net/mptcp/sockopt.c | 8 ++---
> net/sctp/protocol.c | 4 +--
> .../selftests/net/mptcp/mptcp_connect.sh | 2 +-
> 9 files changed, 28 insertions(+), 33 deletions(-)
>
include/net/route.h dereferences sk tos as well.
net/ipv4/icmp.c has a setting of it
next prev parent reply other threads:[~2023-09-21 19:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 13:30 [PATCH net-next 0/8] inet: more data-race fixes Eric Dumazet
2023-09-21 13:30 ` [PATCH net-next 1/8] inet: implement lockless IP_MULTICAST_TTL Eric Dumazet
2023-09-21 19:03 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 2/8] inet: implement lockless IP_MTU_DISCOVER Eric Dumazet
2023-09-21 19:03 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 3/8] inet: implement lockless IP_TOS Eric Dumazet
2023-09-21 19:10 ` David Ahern [this message]
2023-09-21 19:15 ` Eric Dumazet
2023-09-21 13:30 ` [PATCH net-next 4/8] inet: lockless getsockopt(IP_OPTIONS) Eric Dumazet
2023-09-21 19:12 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 5/8] inet: lockless getsockopt(IP_MTU) Eric Dumazet
2023-09-21 19:13 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 6/8] inet: implement lockless getsockopt(IP_UNICAST_IF) Eric Dumazet
2023-09-21 19:19 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 7/8] inet: lockless IP_PKTOPTIONS implementation Eric Dumazet
2023-09-21 19:23 ` David Ahern
2023-09-21 13:30 ` [PATCH net-next 8/8] inet: implement lockless getsockopt(IP_MULTICAST_IF) Eric Dumazet
2023-09-21 19:24 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3473bea6-00c8-2949-5029-122b599be9b2@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.