From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ira Weiny <ira.weiny@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Alexander Potapenko <glider@google.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Remove a sentence from kmap_local_folio() kdocs
Date: Thu, 05 Jan 2023 13:17:17 +0100 [thread overview]
Message-ID: <3474652.iIbC2pHGDl@suse> (raw)
In-Reply-To: <Y7WP2gyTRqTZWAQZ@casper.infradead.org>
On mercoledì 4 gennaio 2023 15:40:26 CET Matthew Wilcox wrote:
> On Wed, Jan 04, 2023 at 01:18:45PM +0100, Fabio M. De Francesco wrote:
> > In the kdocs of kmap_local_folio() there is a an ambiguous sentence
> > which suggests to use this API "only when really necessary".
>
> Looks like you removed it from kmap_local_page() docs in 72f1c55adf70
> after I copied it in 53c36de0701f. That information should probably
> also be in this changelog.
>
Matthew,
I just added that information in v2 (I didn't know that I should have better
added it - thanks for letting me know about this practice):
https://lore.kernel.org/lkml/20230105120424.30055-1-fmdefrancesco@gmail.com/
>
> > * While it is significantly faster than kmap() for the higmem case it
>
> Also, s/higmem/highmem/ (both in the kmap_local_page() and
> kmap_local_folio() docs)
>
Since these spelling mistakes are un-related to the purpose of the deletion, I
fixed them in a separate patch:
https://lore.kernel.org/lkml/20230105121305.30714-1-fmdefrancesco@gmail.com/
Again thanks for commenting my patch and suggesting improvements.
Fabio
prev parent reply other threads:[~2023-01-05 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 12:18 [PATCH] mm: Remove a sentence from kmap_local_folio() kdocs Fabio M. De Francesco
2023-01-04 14:40 ` Matthew Wilcox
2023-01-05 12:17 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3474652.iIbC2pHGDl@suse \
--to=fmdefrancesco@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=glider@google.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.