From: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, Jakub Kicinski <kuba@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-fsdevel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records
Date: Sat, 01 Mar 2025 13:23:24 +0000 [thread overview]
Message-ID: <3475525.1740835404@warthog.procyon.org.uk> (raw)
In-Reply-To: <3399367.1740753918@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> cell->dynroot_ino = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
> 2, INT_MAX / 2, GFP_KERNEL);
> - if (cell->dynroot_ino < 0)
> + if ((int)cell->dynroot_ino < 0)
> goto error;
That's not right. I need to copy the error into 'ret' before jumping to
error. Probably better to do:
ret = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
2, INT_MAX / 2, GFP_KERNEL);
if (ret < 0)
goto error;
cell->dynroot_ino = ret;
David
prev parent reply other threads:[~2025-03-01 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 8:58 [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records David Howells
2025-02-28 10:31 ` Christian Brauner
2025-02-28 14:22 ` Jakub Kicinski
2025-02-28 14:33 ` David Howells
2025-02-28 14:45 ` David Howells
2025-03-01 13:23 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3475525.1740835404@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.