From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] mlx: fix icc compilation error
Date: Tue, 14 Jun 2016 18:18:05 +0200
Message-ID: <3476277.NVBV5Xgfk2@xps13>
References: <20160614100352.GA14888@bricha3-MOBL3> <2912717.PxuBxaxfu4@xps13>
 <57602A9C.2040002@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id E04E79A9C
 for <dev@dpdk.org>; Tue, 14 Jun 2016 18:18:06 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id k204so130412860wmk.0
 for <dev@dpdk.org>; Tue, 14 Jun 2016 09:18:06 -0700 (PDT)
In-Reply-To: <57602A9C.2040002@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-14 17:02, Ferruh Yigit:
> On 6/14/2016 4:39 PM, Thomas Monjalon wrote:
> > 2016-06-14 16:22, Ferruh Yigit:
> >> Compilation errors:
> >> mlx4:
> >>   CC mlx4.o
> >>   .../dpdk/drivers/net/mlx4/mlx4.c(5409): error #188: enumerated type
> >>   mixed with another type
> >>           priv->intr_handle.type = 0;
> >>                                  ^
> >>
> >> mlx5:
> >>   CC em_rxtx.o
> >> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(282):
> >> error #188: enumerated type mixed with another type
> >>         enum hash_rxq_type type = 0;
> >>                                   ^
> >>
> >> .../dpdk/drivers/net/mlx5/mlx5_rxq.c(622):
> >> error #188: enumerated type mixed with another type
> >>                 if (!priv_allow_flow_type(priv, i)) {
> >>                                                 ^
> >> more same type of error
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Please add a Fixes line.
> > We need to think about the stable branch maintainer's task ;)
> > 
> I wasn't sure to add Fixes line for this patch, because it is not so
> useful reference since patch doesn't really fixes the code, just
> compilation error and touches a few different location that is scope of
> different commits:
> 
> Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
> Fixes: 198a3c339a8f ("mlx5: handle link status interrupts")
> Fixes: 0d2186743d62 ("mlx5: manage all special flow types at once")
> Fixes: 612ad38209f7 ("mlx5: fix hash Rx queue type in RSS mode")
> Fixes: 083c2dd31776 ("mlx5: refactor special flows handling")

Indeed.
Another way to help the maintenance is to give a tag where it was working,
e.g. it has been broken after the release v2.5...