From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv12 2/4] batman-adv: Add multicast optimization support for bridged setups
Date: Sun, 24 Apr 2016 09:07:48 +0200 [thread overview]
Message-ID: <34799063.arva0MJYP7@sven-edge> (raw)
In-Reply-To: <20160419022218.GE17647@otheros>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tuesday 19 April 2016 04:22:18 Linus Lüssing wrote:
[...]
> > Why must there be a special compat-sources/*.c file for these tiny
> > functions?
>
> I think it is necessary because of the missing stubs in 3.16.
> 3.16 has the function declarations in if_bridge.h but without
> function definitions if the kernel is build without bridge
> (snooping) support.
>
> Adding simple inline functions in compat-include/linux/if_bridge.h
> for these functions would yield a compile-time error for the 3.16
> kernel without bridge (snooping) support case: The declaration is
> always there in 3.16's if_bridge.h include which would clash
> with a self-made inline function in our compat-include's
> if_bridge.h.
Couldn't you #define the names to a different name which you then use. An
example for this can be found at
https://git.open-mesh.org/batman-adv.git/blob/HEAD:/compat-include/linux/ethtool.h
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-24 7:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 4:06 [B.A.T.M.A.N.] [PATCHv12 0/4] Multicast optimizations for bridges Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 1/4] batman-adv: Always flood IGMP/MLD reports Linus Lüssing
2016-04-07 13:03 ` Simon Wunderlich
2016-04-07 13:24 ` Sven Eckelmann
2016-04-10 12:07 ` Linus Lüssing
2016-04-10 12:43 ` Linus Lüssing
2016-04-19 2:12 ` Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 2/4] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2016-04-07 13:43 ` Sven Eckelmann
2016-04-07 13:50 ` Sven Eckelmann
2016-04-19 2:22 ` Linus Lüssing
2016-04-24 7:07 ` Sven Eckelmann [this message]
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 3/4] batman-adv: Adding logging of mcast flag changes Linus Lüssing
2016-03-16 4:06 ` [B.A.T.M.A.N.] [PATCHv12 4/4] batman-adv: Add debugfs table for mcast flags Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34799063.arva0MJYP7@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.