All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ben Magistro <koncept1@gmail.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: Link custom libarchive meson support
Date: Wed, 19 Feb 2025 18:42:23 +0100	[thread overview]
Message-ID: <3484257.VLH7GnMWUR@thomas> (raw)
In-Reply-To: <CAKx8PBic6QVBP2ntcke_mxxjjPmAtGmMY4YtSN0gZ5wmjcfTRg@mail.gmail.com>

11/02/2025 19:46, Ben Magistro:
> Will acknowledge this may be more of a meson question and less of a DPDK
> issue but things didn't seem to work as expected and had to tweak the
> config/meson.build to want to start with the DPDK team.
> 
> Our project is cmake based and we use fetch content to pull in our external
> dependencies (eg dpdk, libarchive, etc).  We recently noticed
> (rediscovered) that DPDK was not linking libarchive which causes the OS
> provided DDP for the Intel ICE based cards to be unable to be
> decompressed.  Previously we had some additional items installed that
> provided an uncompressed DDP file.  As our project already builds
> libarchive we did not want to install it at the os level for inclusion into
> DPDK as we may now be mixing versions within our application.
> 
> In our cmake we added -Dpkg_config_path to help meson find our libarchive
> build (it is not installed as it is statically linked into our app).  This
> worked but did not expose the include and link directories or any libs that
> may also need to be linked from the pc file.

I don't understand this part.
It should be sufficient.
Are you saying your .pc file is not correct because not installed?

> We had to make some changes
> to get those added and allow things to compile cleanly.  I can confirm the
> changes here work but feel they should not have been necessary.
> 
> What is the correct way to link/use a custom libarchive (or any dependency
> for that matter) with DPDK?  I've attached the diff for the meson changes
> plus the generated pc file for libarchive that we are telling meson to find
> with the pkg_config_path parameter.

The correct way is to give the path to the .pc file.
Please give more info about what is failing.



  reply	other threads:[~2025-02-19 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 18:46 Link custom libarchive meson support Ben Magistro
2025-02-19 17:42 ` Thomas Monjalon [this message]
2025-02-28 15:47   ` Ben Magistro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3484257.VLH7GnMWUR@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=koncept1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.