From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 08/32] readahead: {MIN,MAX}_RA_PAGES
Date: Sat, 27 May 2006 23:48:57 +0800 [thread overview]
Message-ID: <348745088.79681@ustc.edu.cn> (raw)
Message-ID: <20060527155129.653903854@localhost.localdomain> (raw)
In-Reply-To: 20060527154849.927021763@localhost.localdomain
[-- Attachment #1: readahead-macros-min-max-rapages.patch --]
[-- Type: text/plain, Size: 1569 bytes --]
Define two convenient macros for read-ahead:
- MAX_RA_PAGES: rounded down counterpart of VM_MAX_READAHEAD
- MIN_RA_PAGES: rounded _up_ counterpart of VM_MIN_READAHEAD
Note that the rounded up MIN_RA_PAGES will work flawlessly with _large_
page sizes like 64k.
Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
---
mm/readahead.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
--- linux-2.6.17-rc4-mm3.orig/mm/readahead.c
+++ linux-2.6.17-rc4-mm3/mm/readahead.c
@@ -17,13 +17,21 @@
#include <linux/backing-dev.h>
#include <linux/pagevec.h>
+/*
+ * Convienent macros for min/max read-ahead pages.
+ * Note that MAX_RA_PAGES is rounded down, while MIN_RA_PAGES is rounded up.
+ * The latter is necessary for systems with large page size(i.e. 64k).
+ */
+#define MAX_RA_PAGES (VM_MAX_READAHEAD*1024 / PAGE_CACHE_SIZE)
+#define MIN_RA_PAGES DIV_ROUND_UP(VM_MIN_READAHEAD*1024, PAGE_CACHE_SIZE)
+
void default_unplug_io_fn(struct backing_dev_info *bdi, struct page *page)
{
}
EXPORT_SYMBOL(default_unplug_io_fn);
struct backing_dev_info default_backing_dev_info = {
- .ra_pages = (VM_MAX_READAHEAD * 1024) / PAGE_CACHE_SIZE,
+ .ra_pages = MAX_RA_PAGES,
.state = 0,
.capabilities = BDI_CAP_MAP_COPY,
.unplug_io_fn = default_unplug_io_fn,
@@ -52,7 +60,7 @@ static inline unsigned long get_max_read
static inline unsigned long get_min_readahead(struct file_ra_state *ra)
{
- return (VM_MIN_READAHEAD * 1024) / PAGE_CACHE_SIZE;
+ return MIN_RA_PAGES;
}
static inline void reset_ahead_window(struct file_ra_state *ra)
--
next prev parent reply other threads:[~2006-05-27 15:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 15:48 [PATCH 00/32] Adaptive readahead V14 Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 17:29 ` Michael Tokarev
2006-05-28 12:08 ` Wu Fengguang
2006-05-28 12:08 ` Wu Fengguang
2006-05-28 19:23 ` Michael Tokarev
2006-05-29 3:01 ` Wu Fengguang
2006-05-29 3:01 ` Wu Fengguang
2006-05-30 9:23 ` Jens Axboe
2006-05-30 11:32 ` Wu Fengguang
2006-05-30 11:32 ` Wu Fengguang
2006-05-30 12:29 ` Jens Axboe
2006-05-30 14:34 ` Wu Fengguang
2006-05-30 14:34 ` Wu Fengguang
2006-05-27 15:48 ` [PATCH 01/32] readahead: kconfig options Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:48 ` [PATCH 04/32] mm: introduce PG_readahead Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:48 ` [PATCH 06/32] readahead: delay page release in do_generic_mapping_read() Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:48 ` [PATCH 07/32] readahead: insert cond_resched() calls Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang [this message]
2006-05-27 15:48 ` [PATCH 08/32] readahead: {MIN,MAX}_RA_PAGES Wu Fengguang
2006-05-27 15:48 ` [PATCH 09/32] readahead: events accounting Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:48 ` [PATCH 10/32] readahead: rescue_pages() Wu Fengguang
2006-05-27 15:48 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 11/32] readahead: sysctl parameters Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 14/32] readahead: state based method - routines Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 15/32] readahead: state based method Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 18/32] readahead: initial method - thrashing guard size Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 20/32] readahead: initial method - user recommended size Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 22/32] readahead: backward prefetching method Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 24/32] readahead: thrashing recovery method Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 22:04 ` [PATCH 23/32] readahead: seeking reads method Ingo Oeser
2006-05-27 15:49 ` [PATCH 25/32] readahead: call scheme Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 26/32] readahead: laptop mode Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 27/32] readahead: loop case Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 30/32] readahead: debug radix tree new functions Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 31/32] readahead: debug traces showing accessed file names Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
2006-05-27 15:49 ` [PATCH 32/32] readahead: debug traces showing read patterns Wu Fengguang
2006-05-27 15:49 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348745088.79681@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.