From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF5FC433ED for ; Wed, 12 May 2021 08:33:13 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 54F59611CE for ; Wed, 12 May 2021 08:33:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54F59611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C9DD34B5B1; Wed, 12 May 2021 04:33:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4jduPAa8HYUJ; Wed, 12 May 2021 04:33:09 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AD1834B4DE; Wed, 12 May 2021 04:33:09 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D874B4B37A for ; Wed, 12 May 2021 04:33:07 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1UIcDYrW9B7f for ; Wed, 12 May 2021 04:33:06 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id BC2934B365 for ; Wed, 12 May 2021 04:33:06 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A1D611CE; Wed, 12 May 2021 08:33:05 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lgkIh-000qqq-B4; Wed, 12 May 2021 09:33:03 +0100 MIME-Version: 1.0 Date: Wed, 12 May 2021 09:33:03 +0100 From: Marc Zyngier To: Auger Eric Subject: Re: [PATCH v2 4/5] KVM: selftests: Add exception handling support for aarch64 In-Reply-To: <4e83daa3-3166-eeed-840c-39be71b1124d@redhat.com> References: <20210430232408.2707420-1-ricarkol@google.com> <20210430232408.2707420-5-ricarkol@google.com> <87a6pcumyg.wl-maz@kernel.org> <20915a2f-d07c-2e61-3cce-ff385e98e796@redhat.com> <8a99d57b-0513-557c-79e0-98084799812f@redhat.com> <4e83daa3-3166-eeed-840c-39be71b1124d@redhat.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <348b978aad60db6af7ba9c9ce51bbd87@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, ricarkol@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, drjones@redhat.com, alexandru.elisei@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2021-05-12 09:19, Auger Eric wrote: > Hi Ricardo, > > On 5/12/21 9:27 AM, Ricardo Koller wrote: >> On Fri, May 07, 2021 at 04:08:07PM +0200, Auger Eric wrote: >>> Hi Ricardo, >>> >>> On 5/6/21 9:14 PM, Ricardo Koller wrote: >>>> On Thu, May 06, 2021 at 02:30:17PM +0200, Auger Eric wrote: >>>>> Hi Ricardo, >>>>> >>>> >>>> Hi Eric, >>>> >>>> Thank you very much for the test. >>>> >>>>> On 5/3/21 9:12 PM, Ricardo Koller wrote: >>>>>> On Mon, May 03, 2021 at 11:32:39AM +0100, Marc Zyngier wrote: >>>>>>> On Sat, 01 May 2021 00:24:06 +0100, >>>>>>> Ricardo Koller wrote: >>>>>>>> >>>>>>>> Add the infrastructure needed to enable exception handling in >>>>>>>> aarch64 >>>>>>>> selftests. The exception handling defaults to an >>>>>>>> unhandled-exception >>>>>>>> handler which aborts the test, just like x86. These handlers can >>>>>>>> be >>>>>>>> overridden by calling vm_install_vector_handler(vector) or >>>>>>>> vm_install_exception_handler(vector, ec). The unhandled >>>>>>>> exception >>>>>>>> reporting from the guest is done using the ucall type introduced >>>>>>>> in a >>>>>>>> previous commit, UCALL_UNHANDLED. >>>>>>>> >>>>>>>> The exception handling code is heavily inspired on >>>>>>>> kvm-unit-tests. >>>>> >>>>> running the test on 5.12 I get >>>>> >> >> Hi Eric, >> >> I'm able to reproduce the failure you are seeing on 5.6, specifically >> with kernels older than this commit: >> >> 4942dc6638b0 KVM: arm64: Write arch.mdcr_el2 changes since last >> vcpu_load on VHE >> >> but not yet on v5.12. Could you share the commit of the kernel you are >> testing, please? > > my host is a 5.12 kernel (8404c9fbc84b) Time to compare notes then. What HW are you using? Running VHE or not? Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A122C433B4 for ; Wed, 12 May 2021 08:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 096FC613C4 for ; Wed, 12 May 2021 08:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhELIeO (ORCPT ); Wed, 12 May 2021 04:34:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:47202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbhELIeN (ORCPT ); Wed, 12 May 2021 04:34:13 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5A1D611CE; Wed, 12 May 2021 08:33:05 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lgkIh-000qqq-B4; Wed, 12 May 2021 09:33:03 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 May 2021 09:33:03 +0100 From: Marc Zyngier To: Auger Eric Cc: Ricardo Koller , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, drjones@redhat.com, alexandru.elisei@arm.com Subject: Re: [PATCH v2 4/5] KVM: selftests: Add exception handling support for aarch64 In-Reply-To: <4e83daa3-3166-eeed-840c-39be71b1124d@redhat.com> References: <20210430232408.2707420-1-ricarkol@google.com> <20210430232408.2707420-5-ricarkol@google.com> <87a6pcumyg.wl-maz@kernel.org> <20915a2f-d07c-2e61-3cce-ff385e98e796@redhat.com> <8a99d57b-0513-557c-79e0-98084799812f@redhat.com> <4e83daa3-3166-eeed-840c-39be71b1124d@redhat.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <348b978aad60db6af7ba9c9ce51bbd87@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, ricarkol@google.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, pbonzini@redhat.com, drjones@redhat.com, alexandru.elisei@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021-05-12 09:19, Auger Eric wrote: > Hi Ricardo, > > On 5/12/21 9:27 AM, Ricardo Koller wrote: >> On Fri, May 07, 2021 at 04:08:07PM +0200, Auger Eric wrote: >>> Hi Ricardo, >>> >>> On 5/6/21 9:14 PM, Ricardo Koller wrote: >>>> On Thu, May 06, 2021 at 02:30:17PM +0200, Auger Eric wrote: >>>>> Hi Ricardo, >>>>> >>>> >>>> Hi Eric, >>>> >>>> Thank you very much for the test. >>>> >>>>> On 5/3/21 9:12 PM, Ricardo Koller wrote: >>>>>> On Mon, May 03, 2021 at 11:32:39AM +0100, Marc Zyngier wrote: >>>>>>> On Sat, 01 May 2021 00:24:06 +0100, >>>>>>> Ricardo Koller wrote: >>>>>>>> >>>>>>>> Add the infrastructure needed to enable exception handling in >>>>>>>> aarch64 >>>>>>>> selftests. The exception handling defaults to an >>>>>>>> unhandled-exception >>>>>>>> handler which aborts the test, just like x86. These handlers can >>>>>>>> be >>>>>>>> overridden by calling vm_install_vector_handler(vector) or >>>>>>>> vm_install_exception_handler(vector, ec). The unhandled >>>>>>>> exception >>>>>>>> reporting from the guest is done using the ucall type introduced >>>>>>>> in a >>>>>>>> previous commit, UCALL_UNHANDLED. >>>>>>>> >>>>>>>> The exception handling code is heavily inspired on >>>>>>>> kvm-unit-tests. >>>>> >>>>> running the test on 5.12 I get >>>>> >> >> Hi Eric, >> >> I'm able to reproduce the failure you are seeing on 5.6, specifically >> with kernels older than this commit: >> >> 4942dc6638b0 KVM: arm64: Write arch.mdcr_el2 changes since last >> vcpu_load on VHE >> >> but not yet on v5.12. Could you share the commit of the kernel you are >> testing, please? > > my host is a 5.12 kernel (8404c9fbc84b) Time to compare notes then. What HW are you using? Running VHE or not? Thanks, M. -- Jazz is not dead. It just smells funny...