Re: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence

[Thomas Monjalon <thomas@monjalon.net>]

15/06/2022 10:46, Jakub Palider:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Wednesday, June 15, 2022 8:21 AM
> > To: Jakub Palider <jpalider@marvell.com>
> > Cc: dev@dpdk.org; david.marchand@redhat.com
> > Subject: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > 14/06/2022 00:21, jpalider@marvell.com:
> > > +		SEQ[0] = "Coverity issue";
> > > +		SEQ[1] = "Bugzilla ID";
> > > +		SEQ[2] = "Fixes";
> > > +		SEQ[3] = "Cc";
> > > +		SEQ[4] = "^$";
> > > +		SEQ[5] = "Suggested-by";
> > > +		SEQ[6] = "Reported-by";
> > > +		SEQ[7] = "Signed-off-by";
> > > +		latest = 0;
> > 
> > Do you think you could check that Review, Ack and Test are added after the
> > first Signed-off?
> 
> Ok, thank you for clarification. So any further Signed-offs need not to be in a particular 
> sequence as long as the first one precedes Review/Ack/Test (these 3 in any order).

Yes

> > > +Tag order
> > > +~~~~~~~~~
> > > +
> > > +There is a pattern indicating how certain tags should relate to each other.
> > > +
> > > +Example of proper tag sequence::
> > > +
> > > +     Coverity issue:
> > > +     Bugzilla ID:
> > > +     Fixes:
> > > +     Cc:
> > > +
> > > +     Suggested-by:
> > > +     Reported-by:
> > > +     Signed-off-by:
> > 
> > Given it is an example, you could add Reviewed-by, Acked-by and Tested-by.
> 
> Sure, I will restore it.
> 
> > > +
> > > +Between first and second tag section there is and empty line.
> > > +
> > > +While ``Signed-off-by:`` is an obligatory tag and must exists in each
> > > +commit, all other tags are optional. Any tag, as long as it is in
> > > +proper location to other adjacent tags (if present), may occur multiple
> > times.
> > > +
> > > +Other tags shall be laid out in a chronological order.
> > 
> > Yes, after the first Signed-off-by.
> 
> Side question: what about Sponsored-by, I noticed it appeared just recently?

It is a way to add the name of a company wishing to appear.
There is no constraint on it, it can be anywhere I think.
If it is in chronological order, it looks better before the Signed-off.
I think we should not advertise it here, because real names are more useful.