From: Thomas Monjalon <thomas@monjalon.net>
To: Megha Ajmera <megha.ajmera@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com,
cristian.dumitrescu@intel.com, sham.singh.thakur@intel.com,
david.marchand@redhat.com
Subject: Re: [PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally"
Date: Tue, 15 Mar 2022 12:22:59 +0100 [thread overview]
Message-ID: <3492155.hdfAi7Kttb@thomas> (raw)
In-Reply-To: <20220314122725.106088-1-megha.ajmera@intel.com>
14/03/2022 13:27, Megha Ajmera:
> This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e.
>
> When enabling TC OV unconditionally, it is observed the performance
> drops by ~20% hence reverting this commit.
>
> Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription
> unconditionally")
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
Repeating what was suggested yesterday in a private email.
Sorry Megha, I don't know why you were not Cc'ed by your Intel colleagues.
David and I suggested to drop the code which was enabled
by the compilation flag RTE_SCHED_SUBPORT_TC_OV,
which was kind of dead code before enabling it unconditionally.
This way you maintain the performance of the default compilation,
and you can re-introduce the feature, if proven useful,
in the next release with a runtime option.
next prev parent reply other threads:[~2022-03-15 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:59 [PATCH] Revert "sched: enable traffic class oversubscription unconditionally" Megha Ajmera
2022-03-14 10:32 ` Kevin Traynor
2022-03-14 12:27 ` [PATCH v2] " Megha Ajmera
2022-03-15 11:22 ` Thomas Monjalon [this message]
2022-03-15 17:25 ` Dumitrescu, Cristian
2022-03-15 17:25 ` Singh, Jasvinder
2022-03-15 17:35 ` Thomas Monjalon
2022-03-14 10:47 ` [PATCH] " Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3492155.hdfAi7Kttb@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
--cc=megha.ajmera@intel.com \
--cc=sham.singh.thakur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.