Re: [PATCH] x86/cpufeatures: Free up unused feature bits

[Sohil Mehta <sohil.mehta@intel.com>]

On 11/7/2024 3:36 PM, Dave Hansen wrote:
> On 11/7/24 15:30, Sohil Mehta wrote:
>> Linux defined feature bits X86_FEATURE_P3 and X86_FEATURE_P4 are not
>> used anywhere, neither are they visible to userspace.
>> commit f31d731e4467 ("x86: use X86_FEATURE_NOPL in alternatives") got
>> rid of the last usage. Remove the related mappings and code.
> 
> Hah, not referenced since 2008!  This one seems like a no-brainer.

Thankfully, it wasn't referenced anywhere. For a couple of minutes I was
wondering why all family 6 CPUs are marked as Pentium 3 on 32-bit.

> @@ -628,11 +628,6 @@ static void init_intel(struct cpuinfo_x86 *c)
>  		if (p)
>  			strcpy(c->x86_model_id, p);
>  	}

Here..

> -	if (c->x86 == 6)
> -		set_cpu_cap(c, X86_FEATURE_P3);