From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4991CC433E8 for ; Mon, 20 Jul 2020 08:33:45 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DAE922482 for ; Mon, 20 Jul 2020 08:33:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hwgt3ILE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DAE922482 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A61D4204C6; Mon, 20 Jul 2020 08:33:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1vpUcD7VC8Yk; Mon, 20 Jul 2020 08:33:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id B658E204BF; Mon, 20 Jul 2020 08:33:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94722C0894; Mon, 20 Jul 2020 08:33:41 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5190BC016F for ; Mon, 20 Jul 2020 08:33:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 47B2685C5C for ; Mon, 20 Jul 2020 08:33:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w5ZUaMWeOEaB for ; Mon, 20 Jul 2020 08:33:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by fraxinus.osuosl.org (Postfix) with ESMTPS id CC0BD85758 for ; Mon, 20 Jul 2020 08:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595234017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxZwtU6jCdNzDDA32p8x0Lt0O/6ubHPtsEvyLzyrp7M=; b=Hwgt3ILEcqS0kAhwlxXL4yod/Eiu3/NZY49/JrQl1pYjxKcW9IE3EpnVZZ8g8KngkAa1/Z 1mLeHiCQKW0zvPamyNGBJ31nwgzRyzLlBTSQLstJ0IJKZM99MP+jhq+4RktEtDv96XABra 0HEbo5B66MZ1uuZj0ucNoA+iB/HnsDk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-dz-TmbyxOae8XgGzqkDTYA-1; Mon, 20 Jul 2020 04:33:28 -0400 X-MC-Unique: dz-TmbyxOae8XgGzqkDTYA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFC0D1080; Mon, 20 Jul 2020 08:33:26 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24B435C240; Mon, 20 Jul 2020 08:33:15 +0000 (UTC) Subject: Re: [PATCH v5 04/15] vfio/type1: Report iommu nesting info to userspace To: "Liu, Yi L" , "alex.williamson@redhat.com" , "baolu.lu@linux.intel.com" , "joro@8bytes.org" References: <1594552870-55687-1-git-send-email-yi.l.liu@intel.com> <1594552870-55687-5-git-send-email-yi.l.liu@intel.com> <2eb692fc-a399-8298-4b4b-68adb0357404@redhat.com> From: Auger Eric Message-ID: <34931d94-b63b-e366-3c7f-9fd85c8e982d@redhat.com> Date: Mon, 20 Jul 2020 10:33:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Cc: "jean-philippe@linaro.org" , "Tian, Kevin" , "Raj, Ashok" , "kvm@vger.kernel.org" , "stefanha@gmail.com" , "Tian, Jun J" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Sun, Yi Y" , "Wu, Hao" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" WWksCgpPbiA3LzIwLzIwIDk6NTEgQU0sIExpdSwgWWkgTCB3cm90ZToKPiBIaSBFcmljLAo+IAo+ PiBGcm9tOiBBdWdlciBFcmljIDxlcmljLmF1Z2VyQHJlZGhhdC5jb20+Cj4+IFNlbnQ6IFNhdHVy ZGF5LCBKdWx5IDE4LCAyMDIwIDE6MzQgQU0KPj4KPj4gWWksCj4+Cj4+IE9uIDcvMTIvMjAgMToy MCBQTSwgTGl1IFlpIEwgd3JvdGU6Cj4+PiBUaGlzIHBhdGNoIGV4cG9ydHMgaW9tbXUgbmVzdGlu ZyBjYXBhYmlsaXR5IGluZm8gdG8gdXNlciBzcGFjZSB0aHJvdWdoCj4+PiBWRklPLiBVc2VyIHNw YWNlIGlzIGV4cGVjdGVkIHRvIGNoZWNrIHRoaXMgaW5mbyBmb3Igc3VwcG9ydGVkIHVBUElzIChl LmcuCj4+IGl0IGlzIG5vdCBvbmx5IHRvIGNoZWNrIHRoZSBzdXBwb3J0ZWQgdUFQSVMgYnV0IHJh dGhlciB0byBrbm93IHdoaWNoCj4+IGNhbGxiYWNrcyBpdCBtdXN0IGNhbGwgdXBvbiB2SU9NTVUg ZXZlbnRzIGFuZCB3aGljaCBmZWF0dXJlcyBhcmUKPj4gc3VwcG9ydGVkIGJ5IHRoZSBwaHlzaWNh bCBJT01NVS4KPiAKPiB5ZXMsIHdpbGwgcmVmaW5lIHRoZSBkZXNjcmlwdGlvbiBwZXIgeW91ciBj b21tZW50Lgo+IAo+Pj4gUEFTSUQgYWxsb2MvZnJlZSwgYmluZCBwYWdlIHRhYmxlLCBhbmQgY2Fj aGUgaW52YWxpZGF0aW9uKSBhbmQgdGhlIHZlbmRvcgo+Pj4gc3BlY2lmaWMgZm9ybWF0IGluZm9y bWF0aW9uIGZvciBmaXJzdCBsZXZlbC9zdGFnZSBwYWdlIHRhYmxlIHRoYXQgd2lsbCBiZQo+Pj4g Ym91bmQgdG8uCj4+Pgo+Pj4gVGhlIG5lc3RpbmcgaW5mbyBpcyBhdmFpbGFibGUgb25seSBhZnRl ciB0aGUgbmVzdGluZyBpb21tdSB0eXBlIGlzIHNldAo+Pj4gZm9yIGEgY29udGFpbmVyLgo+PiB0 byBORVNURUQgdHlwZQo+IAo+IHlvdSBtZWFuICJUaGUgbmVzdGluZyBpbmZvIGlzIGF2YWlsYWJs ZSBvbmx5IGFmdGVyIGNvbnRhaW5lciBzZXQgdG8gYmUgTkVTVEVEIHR5cGUuIgo+IAo+IHJpZ2h0 Pwpjb3JyZWN0Cj4gCj4+ICBDdXJyZW50IGltcGxlbWVudGF0aW9uIGltcG9zZXMgb25lIGxpbWl0 YXRpb24gLSBvbmUKPj4+IG5lc3RpbmcgY29udGFpbmVyIHNob3VsZCBpbmNsdWRlIGF0IG1vc3Qg b25lIGdyb3VwLiBUaGUgcGhpbG9zb3BoeSBvZgo+Pj4gdmZpbyBjb250YWluZXIgaXMgaGF2aW5n IGFsbCBncm91cHMvZGV2aWNlcyB3aXRoaW4gdGhlIGNvbnRhaW5lciBzaGFyZQo+Pj4gdGhlIHNh bWUgSU9NTVUgY29udGV4dC4gV2hlbiB2U1ZBIGlzIGVuYWJsZWQsIG9uZSBJT01NVSBjb250ZXh0 IGNvdWxkCj4+PiBpbmNsdWRlIG9uZSAybmQtbGV2ZWwgYWRkcmVzcyBzcGFjZSBhbmQgbXVsdGlw bGUgMXN0LWxldmVsIGFkZHJlc3Mgc3BhY2VzLgo+Pj4gV2hpbGUgdGhlIDJuZC1sZXZlbCBhZGRy ZXNzIHNwYWNlIGlzIHJlYXNvbmFibHkgc2hhcmFibGUgYnkgbXVsdGlwbGUgZ3JvdXBzCj4+PiAs IGJsaW5kbHkgc2hhcmluZyAxc3QtbGV2ZWwgYWRkcmVzcyBzcGFjZXMgYWNyb3NzIGFsbCBncm91 cHMgd2l0aGluIHRoZQo+Pj4gY29udGFpbmVyIG1pZ2h0IGluc3RlYWQgYnJlYWsgdGhlIGd1ZXN0 IGV4cGVjdGF0aW9uLiBJbiB0aGUgZnV0dXJlIHN1Yi8KPj4+IHN1cGVyIGNvbnRhaW5lciBjb25j ZXB0IG1pZ2h0IGJlIGludHJvZHVjZWQgdG8gYWxsb3cgcGFydGlhbCBhZGRyZXNzIHNwYWNlCj4+ PiBzaGFyaW5nIHdpdGhpbiBhbiBJT01NVSBjb250ZXh0LiBCdXQgZm9yIG5vdyBsZXQncyBnbyB3 aXRoIHRoaXMgcmVzdHJpY3Rpb24KPj4+IGJ5IHJlcXVpcmluZyBzaW5nbGV0b24gY29udGFpbmVy IGZvciB1c2luZyBuZXN0aW5nIGlvbW11IGZlYXR1cmVzLiBCZWxvdwo+Pj4gbGluayBoYXMgdGhl IHJlbGF0ZWQgZGlzY3Vzc2lvbiBhYm91dCB0aGlzIGRlY2lzaW9uLgo+Pgo+PiBNYXliZSBhZGQg YSBub3RlIGFib3V0IFNNTVUgcmVsYXRlZCBjaGFuZ2VzIHNwb3R0ZWQgYnkgSmVhbi4KPiAKPiBJ IGd1ZXNzIHlvdSBtZWFuIHRoZSBjb21tZW50cyBKZWFuIGdhdmUgaW4gcGF0Y2ggMy8xNSwgcmln aHQ/IEknbGwKPiBjb3B5IGhpcyBjb21tZW50cyBhbmQgYWxzbyBnaXZlIHRoZSBiZWxvdyBsaW5r IGFzIHdlbGwuCj4gCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcva3ZtLzIwMjAwNzE3MDkwOTAw LkdDNDg1MEBteXJpY2EvCmNvcnJlY3QKClRoYW5rcwoKRXJpYwo+IAo+Pj4KPj4+IGh0dHBzOi8v bGttbC5vcmcvbGttbC8yMDIwLzUvMTUvMTAyOAo+Pj4KPj4+IENjOiBLZXZpbiBUaWFuIDxrZXZp bi50aWFuQGludGVsLmNvbT4KPj4+IENDOiBKYWNvYiBQYW4gPGphY29iLmp1bi5wYW5AbGludXgu aW50ZWwuY29tPgo+Pj4gQ2M6IEFsZXggV2lsbGlhbXNvbiA8YWxleC53aWxsaWFtc29uQHJlZGhh dC5jb20+Cj4+PiBDYzogRXJpYyBBdWdlciA8ZXJpYy5hdWdlckByZWRoYXQuY29tPgo+Pj4gQ2M6 IEplYW4tUGhpbGlwcGUgQnJ1Y2tlciA8amVhbi1waGlsaXBwZUBsaW5hcm8ub3JnPgo+Pj4gQ2M6 IEpvZXJnIFJvZWRlbCA8am9yb0A4Ynl0ZXMub3JnPgo+Pj4gQ2M6IEx1IEJhb2x1IDxiYW9sdS5s dUBsaW51eC5pbnRlbC5jb20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMaXUgWWkgTCA8eWkubC5saXVA aW50ZWwuY29tPgo+Pj4gLS0tCj4+PiB2NCAtPiB2NToKPj4+ICopIGFkZHJlc3MgY29tbWVudHMg ZnJvbSBFcmljIEF1Z2VyLgo+Pj4gKikgcmV0dXJuIHN0cnVjdCBpb21tdV9uZXN0aW5nX2luZm8g Zm9yCj4+IFZGSU9fSU9NTVVfVFlQRTFfSU5GT19DQVBfTkVTVElORyBhcwo+Pj4gICAgY2FwIGlz IG11Y2ggImNoZWFwIiwgaWYgbmVlZHMgZXh0ZW5zaW9uIGluIGZ1dHVyZSwganVzdCBkZWZpbmUg YW5vdGhlciBjYXAuCj4+PiAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9rdm0vMjAyMDA3MDgx MzI5NDcuNWI3ZWU5NTRAeDEuaG9tZS8KPj4+Cj4+PiB2MyAtPiB2NDoKPj4+ICopIGFkZHJlc3Mg Y29tbWVudHMgYWdhaW5zdCB2My4KPj4+Cj4+PiB2MSAtPiB2MjoKPj4+ICopIGFkZGVkIGluIHYy Cj4+PiAtLS0KPj4+ICBkcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIHwgMTAyCj4+ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPj4+ICBpbmNsdWRlL3VhcGkv bGludXgvdmZpby5oICAgICAgIHwgIDE5ICsrKysrKysrCj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCAx MDkgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdmZpby92ZmlvX2lvbW11X3R5cGUxLmMgYi9kcml2ZXJzL3ZmaW8vdmZpb19pb21tdV90 eXBlMS5jCj4+PiBpbmRleCAzYmQ3MGZmLi5lZDgwMTA0IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVy cy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEuYwo+Pj4gKysrIGIvZHJpdmVycy92ZmlvL3ZmaW9faW9t bXVfdHlwZTEuYwo+Pj4gQEAgLTYyLDE4ICs2MiwyMCBAQCBNT0RVTEVfUEFSTV9ERVNDKGRtYV9l bnRyeV9saW1pdCwKPj4+ICAJCSAiTWF4aW11bSBudW1iZXIgb2YgdXNlciBETUEgbWFwcGluZ3Mg cGVyIGNvbnRhaW5lciAoNjU1MzUpLiIpOwo+Pj4KPj4+ICBzdHJ1Y3QgdmZpb19pb21tdSB7Cj4+ PiAtCXN0cnVjdCBsaXN0X2hlYWQJZG9tYWluX2xpc3Q7Cj4+PiAtCXN0cnVjdCBsaXN0X2hlYWQJ aW92YV9saXN0Owo+Pj4gLQlzdHJ1Y3QgdmZpb19kb21haW4JKmV4dGVybmFsX2RvbWFpbjsgLyog ZG9tYWluIGZvciBleHRlcm5hbCB1c2VyICovCj4+PiAtCXN0cnVjdCBtdXRleAkJbG9jazsKPj4+ IC0Jc3RydWN0IHJiX3Jvb3QJCWRtYV9saXN0Owo+Pj4gLQlzdHJ1Y3QgYmxvY2tpbmdfbm90aWZp ZXJfaGVhZCBub3RpZmllcjsKPj4+IC0JdW5zaWduZWQgaW50CQlkbWFfYXZhaWw7Cj4+PiAtCXVp bnQ2NF90CQlwZ3NpemVfYml0bWFwOwo+Pj4gLQlib29sCQkJdjI7Cj4+PiAtCWJvb2wJCQluZXN0 aW5nOwo+Pj4gLQlib29sCQkJZGlydHlfcGFnZV90cmFja2luZzsKPj4+IC0JYm9vbAkJCXBpbm5l ZF9wYWdlX2RpcnR5X3Njb3BlOwo+Pj4gKwlzdHJ1Y3QgbGlzdF9oZWFkCQlkb21haW5fbGlzdDsK Pj4+ICsJc3RydWN0IGxpc3RfaGVhZAkJaW92YV9saXN0Owo+Pj4gKwkvKiBkb21haW4gZm9yIGV4 dGVybmFsIHVzZXIgKi8KPj4+ICsJc3RydWN0IHZmaW9fZG9tYWluCQkqZXh0ZXJuYWxfZG9tYWlu Owo+Pj4gKwlzdHJ1Y3QgbXV0ZXgJCQlsb2NrOwo+Pj4gKwlzdHJ1Y3QgcmJfcm9vdAkJCWRtYV9s aXN0Owo+Pj4gKwlzdHJ1Y3QgYmxvY2tpbmdfbm90aWZpZXJfaGVhZAlub3RpZmllcjsKPj4+ICsJ dW5zaWduZWQgaW50CQkJZG1hX2F2YWlsOwo+Pj4gKwl1aW50NjRfdAkJCXBnc2l6ZV9iaXRtYXA7 Cj4+PiArCWJvb2wJCQkJdjI7Cj4+PiArCWJvb2wJCQkJbmVzdGluZzsKPj4+ICsJYm9vbAkJCQlk aXJ0eV9wYWdlX3RyYWNraW5nOwo+Pj4gKwlib29sCQkJCXBpbm5lZF9wYWdlX2RpcnR5X3Njb3Bl Owo+Pj4gKwlzdHJ1Y3QgaW9tbXVfbmVzdGluZ19pbmZvCSpuZXN0aW5nX2luZm87Cj4+PiAgfTsK Pj4+Cj4+PiAgc3RydWN0IHZmaW9fZG9tYWluIHsKPj4+IEBAIC0xMzAsNiArMTMyLDkgQEAgc3Ry dWN0IHZmaW9fcmVnaW9ucyB7Cj4+PiAgI2RlZmluZSBJU19JT01NVV9DQVBfRE9NQUlOX0lOX0NP TlRBSU5FUihpb21tdSkJXAo+Pj4gIAkJCQkJKCFsaXN0X2VtcHR5KCZpb21tdS0+ZG9tYWluX2xp c3QpKQo+Pj4KPj4+ICsjZGVmaW5lIENPTlRBSU5FUl9IQVNfRE9NQUlOKGlvbW11KQkoKChpb21t dSktPmV4dGVybmFsX2RvbWFpbikgfHwgXAo+Pj4gKwkJCQkJICghbGlzdF9lbXB0eSgmKGlvbW11 KS0+ZG9tYWluX2xpc3QpKSkKPj4+ICsKPj4+ICAjZGVmaW5lIERJUlRZX0JJVE1BUF9CWVRFUyhu KQkoQUxJR04obiwgQklUU19QRVJfVFlQRSh1NjQpKSAvCj4+IEJJVFNfUEVSX0JZVEUpCj4+Pgo+ Pj4gIC8qCj4+PiBAQCAtMTkyOSw2ICsxOTM0LDEzIEBAIHN0YXRpYyB2b2lkIHZmaW9faW9tbXVf aW92YV9pbnNlcnRfY29weShzdHJ1Y3QKPj4gdmZpb19pb21tdSAqaW9tbXUsCj4+Pgo+Pj4gIAls aXN0X3NwbGljZV90YWlsKGlvdmFfY29weSwgaW92YSk7Cj4+PiAgfQo+Pj4gKwo+Pj4gK3N0YXRp YyB2b2lkIHZmaW9faW9tbXVfcmVsZWFzZV9uZXN0aW5nX2luZm8oc3RydWN0IHZmaW9faW9tbXUg KmlvbW11KQo+Pj4gK3sKPj4+ICsJa2ZyZWUoaW9tbXUtPm5lc3RpbmdfaW5mbyk7Cj4+PiArCWlv bW11LT5uZXN0aW5nX2luZm8gPSBOVUxMOwo+Pj4gK30KPj4+ICsKPj4+ICBzdGF0aWMgaW50IHZm aW9faW9tbXVfdHlwZTFfYXR0YWNoX2dyb3VwKHZvaWQgKmlvbW11X2RhdGEsCj4+PiAgCQkJCQkg c3RydWN0IGlvbW11X2dyb3VwICppb21tdV9ncm91cCkKPj4+ICB7Cj4+PiBAQCAtMTk1OSw2ICsx OTcxLDEyIEBAIHN0YXRpYyBpbnQgdmZpb19pb21tdV90eXBlMV9hdHRhY2hfZ3JvdXAodm9pZAo+ PiAqaW9tbXVfZGF0YSwKPj4+ICAJCX0KPj4+ICAJfQo+Pj4KPj4+ICsJLyogTmVzdGluZyB0eXBl IGNvbnRhaW5lciBjYW4gaW5jbHVkZSBvbmx5IG9uZSBncm91cCAqLwo+Pj4gKwlpZiAoaW9tbXUt Pm5lc3RpbmcgJiYgQ09OVEFJTkVSX0hBU19ET01BSU4oaW9tbXUpKSB7Cj4+PiArCQltdXRleF91 bmxvY2soJmlvbW11LT5sb2NrKTsKPj4+ICsJCXJldHVybiAtRUlOVkFMOwo+Pj4gKwl9Cj4+PiAr Cj4+PiAgCWdyb3VwID0ga3phbGxvYyhzaXplb2YoKmdyb3VwKSwgR0ZQX0tFUk5FTCk7Cj4+PiAg CWRvbWFpbiA9IGt6YWxsb2Moc2l6ZW9mKCpkb21haW4pLCBHRlBfS0VSTkVMKTsKPj4+ICAJaWYg KCFncm91cCB8fCAhZG9tYWluKSB7Cj4+PiBAQCAtMjAyOSw2ICsyMDQ3LDMyIEBAIHN0YXRpYyBp bnQgdmZpb19pb21tdV90eXBlMV9hdHRhY2hfZ3JvdXAodm9pZAo+PiAqaW9tbXVfZGF0YSwKPj4+ ICAJaWYgKHJldCkKPj4+ICAJCWdvdG8gb3V0X2RvbWFpbjsKPj4+Cj4+PiArCS8qIE5lc3Rpbmcg Y2FwIGluZm8gaXMgYXZhaWxhYmxlIG9ubHkgYWZ0ZXIgYXR0YWNoaW5nICovCj4+PiArCWlmIChp b21tdS0+bmVzdGluZykgewo+Pj4gKwkJc3RydWN0IGlvbW11X25lc3RpbmdfaW5mbyB0bXAgPSB7 IC5zaXplID0gMCwgfTsKPj4+ICsKPj4+ICsJCS8qIEZpcnN0IGdldCB0aGUgc2l6ZSBvZiB2ZW5k b3Igc3BlY2lmaWMgbmVzdGluZyBpbmZvICovCj4+PiArCQlyZXQgPSBpb21tdV9kb21haW5fZ2V0 X2F0dHIoZG9tYWluLT5kb21haW4sCj4+PiArCQkJCQkgICAgRE9NQUlOX0FUVFJfTkVTVElORywK Pj4+ICsJCQkJCSAgICAmdG1wKTsKPj4+ICsJCWlmIChyZXQpCj4+PiArCQkJZ290byBvdXRfZGV0 YWNoOwo+Pj4gKwo+Pj4gKwkJaW9tbXUtPm5lc3RpbmdfaW5mbyA9IGt6YWxsb2ModG1wLnNpemUs IEdGUF9LRVJORUwpOwo+Pj4gKwkJaWYgKCFpb21tdS0+bmVzdGluZ19pbmZvKSB7Cj4+PiArCQkJ cmV0ID0gLUVOT01FTTsKPj4+ICsJCQlnb3RvIG91dF9kZXRhY2g7Cj4+PiArCQl9Cj4+PiArCj4+ PiArCQkvKiBOb3cgZ2V0IHRoZSBuZXN0aW5nIGluZm8gKi8KPj4+ICsJCWlvbW11LT5uZXN0aW5n X2luZm8tPnNpemUgPSB0bXAuc2l6ZTsKPj4+ICsJCXJldCA9IGlvbW11X2RvbWFpbl9nZXRfYXR0 cihkb21haW4tPmRvbWFpbiwKPj4+ICsJCQkJCSAgICBET01BSU5fQVRUUl9ORVNUSU5HLAo+Pj4g KwkJCQkJICAgIGlvbW11LT5uZXN0aW5nX2luZm8pOwo+Pj4gKwkJaWYgKHJldCkKPj4+ICsJCQln b3RvIG91dF9kZXRhY2g7Cj4gCj4gZ2V0IG5lc3RpbmdfaW5mbyBmYWlsdXJlIHdpbGwgcmVzdWx0 IGluIGdyb3VwX2F0dGFjaCBmYWlsdXJlLlsxXQo+IAo+Pj4gKwl9Cj4+PiArCj4+PiAgCS8qIEdl dCBhcGVydHVyZSBpbmZvICovCj4+PiAgCWlvbW11X2RvbWFpbl9nZXRfYXR0cihkb21haW4tPmRv bWFpbiwgRE9NQUlOX0FUVFJfR0VPTUVUUlksCj4+ICZnZW8pOwo+Pj4KPj4+IEBAIC0yMTM4LDYg KzIxODIsNyBAQCBzdGF0aWMgaW50IHZmaW9faW9tbXVfdHlwZTFfYXR0YWNoX2dyb3VwKHZvaWQK Pj4gKmlvbW11X2RhdGEsCj4+PiAgCXJldHVybiAwOwo+Pj4KPj4+ICBvdXRfZGV0YWNoOgo+Pj4g Kwl2ZmlvX2lvbW11X3JlbGVhc2VfbmVzdGluZ19pbmZvKGlvbW11KTsKPj4+ICAJdmZpb19pb21t dV9kZXRhY2hfZ3JvdXAoZG9tYWluLCBncm91cCk7Cj4+PiAgb3V0X2RvbWFpbjoKPj4+ICAJaW9t bXVfZG9tYWluX2ZyZWUoZG9tYWluLT5kb21haW4pOwo+Pj4gQEAgLTIzMzgsNiArMjM4Myw4IEBA IHN0YXRpYyB2b2lkIHZmaW9faW9tbXVfdHlwZTFfZGV0YWNoX2dyb3VwKHZvaWQKPj4gKmlvbW11 X2RhdGEsCj4+PiAgCQkJCQl2ZmlvX2lvbW11X3VubWFwX3VucGluX2FsbChpb21tdSk7Cj4+PiAg CQkJCWVsc2UKPj4+Cj4+IAl2ZmlvX2lvbW11X3VubWFwX3VucGluX3JlYWNjb3VudChpb21tdSk7 Cj4+PiArCj4+PiArCQkJCXZmaW9faW9tbXVfcmVsZWFzZV9uZXN0aW5nX2luZm8oaW9tbXUpOwo+ Pj4gIAkJCX0KPj4+ICAJCQlpb21tdV9kb21haW5fZnJlZShkb21haW4tPmRvbWFpbik7Cj4+PiAg CQkJbGlzdF9kZWwoJmRvbWFpbi0+bmV4dCk7Cj4+PiBAQCAtMjU0Niw2ICsyNTkzLDMxIEBAIHN0 YXRpYyBpbnQgdmZpb19pb21tdV9taWdyYXRpb25fYnVpbGRfY2FwcyhzdHJ1Y3QKPj4gdmZpb19p b21tdSAqaW9tbXUsCj4+PiAgCXJldHVybiB2ZmlvX2luZm9fYWRkX2NhcGFiaWxpdHkoY2Fwcywg JmNhcF9taWcuaGVhZGVyLCBzaXplb2YoY2FwX21pZykpOwo+Pj4gIH0KPj4+Cj4+PiArc3RhdGlj IGludCB2ZmlvX2lvbW11X2luZm9fYWRkX25lc3RpbmdfY2FwKHN0cnVjdCB2ZmlvX2lvbW11ICpp b21tdSwKPj4+ICsJCQkJCSAgIHN0cnVjdCB2ZmlvX2luZm9fY2FwICpjYXBzKQo+Pj4gK3sKPj4+ ICsJc3RydWN0IHZmaW9faW5mb19jYXBfaGVhZGVyICpoZWFkZXI7Cj4+PiArCXN0cnVjdCB2Zmlv X2lvbW11X3R5cGUxX2luZm9fY2FwX25lc3RpbmcgKm5lc3RpbmdfY2FwOwo+Pj4gKwlzaXplX3Qg c2l6ZTsKPj4+ICsKPj4+ICsJc2l6ZSA9IG9mZnNldG9mKHN0cnVjdCB2ZmlvX2lvbW11X3R5cGUx X2luZm9fY2FwX25lc3RpbmcsIGluZm8pICsKPj4+ICsJCWlvbW11LT5uZXN0aW5nX2luZm8tPnNp emU7Cj4+PiArCj4+PiArCWhlYWRlciA9IHZmaW9faW5mb19jYXBfYWRkKGNhcHMsIHNpemUsCj4+ PiArCQkJCSAgIFZGSU9fSU9NTVVfVFlQRTFfSU5GT19DQVBfTkVTVElORywgMSk7Cj4+PiArCWlm IChJU19FUlIoaGVhZGVyKSkKPj4+ICsJCXJldHVybiBQVFJfRVJSKGhlYWRlcik7Cj4+PiArCj4+ PiArCW5lc3RpbmdfY2FwID0gY29udGFpbmVyX29mKGhlYWRlciwKPj4+ICsJCQkJICAgc3RydWN0 IHZmaW9faW9tbXVfdHlwZTFfaW5mb19jYXBfbmVzdGluZywKPj4+ICsJCQkJICAgaGVhZGVyKTsK Pj4+ICsKPj4+ICsJbWVtY3B5KCZuZXN0aW5nX2NhcC0+aW5mbywgaW9tbXUtPm5lc3RpbmdfaW5m bywKPj4+ICsJICAgICAgIGlvbW11LT5uZXN0aW5nX2luZm8tPnNpemUpOwo+PiB5b3UgbXVzdCBj aGVjayB3aGV0aGVyIG5lc3RpbmdfaW5mbyBpcyBub24gTlVMTCBiZWZvcmUgZG9pbmcgdGhhdC4K PiAKPiBpdCdzIG5vdyB2YWxpZGF0ZWQgaW4gdGhlIGNhbGxlciBvZiB0aGlzIGZ1bmN0aW9uLiA6 LSkKYWggb2sgc29ycnkgSSBtaXNzZWQgdGhhdC4KPiAgCj4+IEJlc2lkZXMgSSBhZ3JlZSB3aXRo IEplYW4gb24gdGhlIGZhY3QgaXQgbWF5IGJlIGJldHRlciB0byBub3QgcmVwb3J0IHRoZQo+PiBj YXBhYmlsaXR5IGlmIG5lc3RlZCBpcyBub3Qgc3VwcG9ydGVkLgo+IAo+IEkgc2VlLiBpbiB0aGlz IHBhdGNoLCBqdXN0IGZldyBsaW5lcyBiZWxvdyBbMl0sIHZmaW8gb25seSByZXBvcnRzIG5lc3Rp bmcKPiBjYXAgd2hlbiBpb21tdS0+bmVzdGluZ19pbmZvIGlzIG5vbi1udWxsLiBzbyBldmVuIGlm IHVzZXJzcGFjZSBzZWxlY3RlZAo+IG5lc3RpbmcgdHlwZSwgaXQgbWF5IGZhaWwgYXQgdGhlIFZG SU9fU0VUX0lPTU1VIHBoYXNlIHNpbmNlIGdyb3VwX2F0dGFjaAo+IHdpbGwgYmUgZmFpbGVkIGZv ciBORVNURUQgdHlwZSBjb250YWluZXIgaWYgaG9zdCBpb21tdSBkb2VzbuKAmXQgc3VwcG9ydAo+ IG5lc3RpbmcuIHRoZSBjb2RlIGlzIG1hcmtlZCBhcyBbMV0gaW4gdGhpcyBlbWFpbC4KT0sgdGhh dCdzIGFscmVhZHkgdGhlcmUgdGhlbi4KClRoYW5rcwoKRXJpYwo+IAo+Pj4gKwo+Pj4gKwlyZXR1 cm4gMDsKPj4+ICt9Cj4+PiArCj4+PiAgc3RhdGljIGludCB2ZmlvX2lvbW11X3R5cGUxX2dldF9p bmZvKHN0cnVjdCB2ZmlvX2lvbW11ICppb21tdSwKPj4+ICAJCQkJICAgICB1bnNpZ25lZCBsb25n IGFyZykKPj4+ICB7Cj4+PiBAQCAtMjU4MSw2ICsyNjUzLDEyIEBAIHN0YXRpYyBpbnQgdmZpb19p b21tdV90eXBlMV9nZXRfaW5mbyhzdHJ1Y3QKPj4gdmZpb19pb21tdSAqaW9tbXUsCj4+PiAgCWlm ICghcmV0KQo+Pj4gIAkJcmV0ID0gdmZpb19pb21tdV9pb3ZhX2J1aWxkX2NhcHMoaW9tbXUsICZj YXBzKTsKPj4+Cj4+PiArCWlmIChpb21tdS0+bmVzdGluZ19pbmZvKSB7Cj4+PiArCQlyZXQgPSB2 ZmlvX2lvbW11X2luZm9fYWRkX25lc3RpbmdfY2FwKGlvbW11LCAmY2Fwcyk7Cj4+PiArCQlpZiAo cmV0KQo+Pj4gKwkJCXJldHVybiByZXQ7Cj4gCj4gaGVyZSBjaGVja3MgbmVzdGluZ19pbmZvIGJl Zm9yZSByZXBvcnRpbmcgbmVzdGluZyBjYXAuIFsyXQo+IAo+Pj4gKwl9Cj4+PiArCj4+PiAgCW11 dGV4X3VubG9jaygmaW9tbXUtPmxvY2spOwo+Pj4KPj4+ICAJaWYgKHJldCkKPj4+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL3VhcGkvbGludXgvdmZpby5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L3ZmaW8u aAo+Pj4gaW5kZXggOTIwNDcwNS4uNDZhNzhhZiAxMDA2NDQKPj4+IC0tLSBhL2luY2x1ZGUvdWFw aS9saW51eC92ZmlvLmgKPj4+ICsrKyBiL2luY2x1ZGUvdWFwaS9saW51eC92ZmlvLmgKPj4+IEBA IC0xNCw2ICsxNCw3IEBACj4+Pgo+Pj4gICNpbmNsdWRlIDxsaW51eC90eXBlcy5oPgo+Pj4gICNp bmNsdWRlIDxsaW51eC9pb2N0bC5oPgo+Pj4gKyNpbmNsdWRlIDxsaW51eC9pb21tdS5oPgo+Pj4K Pj4+ICAjZGVmaW5lIFZGSU9fQVBJX1ZFUlNJT04JMAo+Pj4KPj4+IEBAIC0xMDM5LDYgKzEwNDAs MjQgQEAgc3RydWN0IHZmaW9faW9tbXVfdHlwZTFfaW5mb19jYXBfbWlncmF0aW9uIHsKPj4+ICAJ X191NjQJbWF4X2RpcnR5X2JpdG1hcF9zaXplOwkJLyogaW4gYnl0ZXMgKi8KPj4+ICB9Owo+Pj4K Pj4+ICsvKgo+Pj4gKyAqIFRoZSBuZXN0aW5nIGNhcGFiaWxpdHkgYWxsb3dzIHRvIHJlcG9ydCB0 aGUgcmVsYXRlZCBjYXBhYmlsaXR5Cj4+PiArICogYW5kIGluZm8gZm9yIG5lc3RpbmcgaW9tbXUg dHlwZS4KPj4+ICsgKgo+Pj4gKyAqIFRoZSBzdHJ1Y3R1cmVzIGJlbG93IGRlZmluZSB2ZXJzaW9u IDEgb2YgdGhpcyBjYXBhYmlsaXR5Lgo+Pj4gKyAqCj4+PiArICogVXNlciBzcGFjZSBzZWxlY3Rl ZCBWRklPX1RZUEUxX05FU1RJTkdfSU9NTVUgdHlwZSBzaG91bGQgY2hlY2sKPj4+ICsgKiB0aGlz IGNhcHRvIGdldCBzdXBwb3J0ZWQgZmVhdHVyZXMuCj4+IHMvY2FwdG8vY2FwYWJpbGl0eSB0byBn ZXQKPiAKPiBnb3QgaXQuCj4gCj4gUmVnYXJkcywKPiBZaSBMaXUKPiAKPj4+ICsgKgo+Pj4gKyAq IEBpbmZvOiB0aGUgbmVzdGluZyBpbmZvIHByb3ZpZGVkIGJ5IElPTU1VIGRyaXZlci4KPj4+ICsg Ki8KPj4+ICsjZGVmaW5lIFZGSU9fSU9NTVVfVFlQRTFfSU5GT19DQVBfTkVTVElORyAgMwo+Pj4g Kwo+Pj4gK3N0cnVjdCB2ZmlvX2lvbW11X3R5cGUxX2luZm9fY2FwX25lc3Rpbmcgewo+Pj4gKwlz dHJ1Y3QJdmZpb19pbmZvX2NhcF9oZWFkZXIgaGVhZGVyOwo+Pj4gKwlzdHJ1Y3QgaW9tbXVfbmVz dGluZ19pbmZvIGluZm87Cj4+PiArfTsKPj4+ICsKPj4+ICAjZGVmaW5lIFZGSU9fSU9NTVVfR0VU X0lORk8gX0lPKFZGSU9fVFlQRSwgVkZJT19CQVNFICsgMTIpCj4+Pgo+Pj4gIC8qKgo+Pj4KPj4K Pj4gVGhhbmtzCj4+Cj4+IEVyaWMKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3Vu ZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0 aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F71DC433E7 for ; Mon, 20 Jul 2020 08:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E855022BEF for ; Mon, 20 Jul 2020 08:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e9e23tWO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgGTIdj (ORCPT ); Mon, 20 Jul 2020 04:33:39 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:23241 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725815AbgGTIdj (ORCPT ); Mon, 20 Jul 2020 04:33:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595234016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jxZwtU6jCdNzDDA32p8x0Lt0O/6ubHPtsEvyLzyrp7M=; b=e9e23tWOMyqd8t7wuIjXm0hLNciuJfW3wUsali6Z+Fo8lnEsGbocDbqhkCjUoKoLgj4mM1 +SWWa+L1WKPJLDqO0G8oZis/ejNt+aPP40pPfFpz91CHFJOYAvM99JhfnLZUhR16U3JRJK k1JjuZ5F6Tz45nG3zHOswaF8BPVYQuc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-dz-TmbyxOae8XgGzqkDTYA-1; Mon, 20 Jul 2020 04:33:28 -0400 X-MC-Unique: dz-TmbyxOae8XgGzqkDTYA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFC0D1080; Mon, 20 Jul 2020 08:33:26 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24B435C240; Mon, 20 Jul 2020 08:33:15 +0000 (UTC) Subject: Re: [PATCH v5 04/15] vfio/type1: Report iommu nesting info to userspace To: "Liu, Yi L" , "alex.williamson@redhat.com" , "baolu.lu@linux.intel.com" , "joro@8bytes.org" Cc: "Tian, Kevin" , "jacob.jun.pan@linux.intel.com" , "Raj, Ashok" , "Tian, Jun J" , "Sun, Yi Y" , "jean-philippe@linaro.org" , "peterx@redhat.com" , "Wu, Hao" , "stefanha@gmail.com" , "iommu@lists.linux-foundation.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1594552870-55687-1-git-send-email-yi.l.liu@intel.com> <1594552870-55687-5-git-send-email-yi.l.liu@intel.com> <2eb692fc-a399-8298-4b4b-68adb0357404@redhat.com> From: Auger Eric Message-ID: <34931d94-b63b-e366-3c7f-9fd85c8e982d@redhat.com> Date: Mon, 20 Jul 2020 10:33:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Yi, On 7/20/20 9:51 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Saturday, July 18, 2020 1:34 AM >> >> Yi, >> >> On 7/12/20 1:20 PM, Liu Yi L wrote: >>> This patch exports iommu nesting capability info to user space through >>> VFIO. User space is expected to check this info for supported uAPIs (e.g. >> it is not only to check the supported uAPIS but rather to know which >> callbacks it must call upon vIOMMU events and which features are >> supported by the physical IOMMU. > > yes, will refine the description per your comment. > >>> PASID alloc/free, bind page table, and cache invalidation) and the vendor >>> specific format information for first level/stage page table that will be >>> bound to. >>> >>> The nesting info is available only after the nesting iommu type is set >>> for a container. >> to NESTED type > > you mean "The nesting info is available only after container set to be NESTED type." > > right? correct > >> Current implementation imposes one limitation - one >>> nesting container should include at most one group. The philosophy of >>> vfio container is having all groups/devices within the container share >>> the same IOMMU context. When vSVA is enabled, one IOMMU context could >>> include one 2nd-level address space and multiple 1st-level address spaces. >>> While the 2nd-level address space is reasonably sharable by multiple groups >>> , blindly sharing 1st-level address spaces across all groups within the >>> container might instead break the guest expectation. In the future sub/ >>> super container concept might be introduced to allow partial address space >>> sharing within an IOMMU context. But for now let's go with this restriction >>> by requiring singleton container for using nesting iommu features. Below >>> link has the related discussion about this decision. >> >> Maybe add a note about SMMU related changes spotted by Jean. > > I guess you mean the comments Jean gave in patch 3/15, right? I'll > copy his comments and also give the below link as well. > > https://lore.kernel.org/kvm/20200717090900.GC4850@myrica/ correct Thanks Eric > >>> >>> https://lkml.org/lkml/2020/5/15/1028 >>> >>> Cc: Kevin Tian >>> CC: Jacob Pan >>> Cc: Alex Williamson >>> Cc: Eric Auger >>> Cc: Jean-Philippe Brucker >>> Cc: Joerg Roedel >>> Cc: Lu Baolu >>> Signed-off-by: Liu Yi L >>> --- >>> v4 -> v5: >>> *) address comments from Eric Auger. >>> *) return struct iommu_nesting_info for >> VFIO_IOMMU_TYPE1_INFO_CAP_NESTING as >>> cap is much "cheap", if needs extension in future, just define another cap. >>> https://lore.kernel.org/kvm/20200708132947.5b7ee954@x1.home/ >>> >>> v3 -> v4: >>> *) address comments against v3. >>> >>> v1 -> v2: >>> *) added in v2 >>> --- >>> drivers/vfio/vfio_iommu_type1.c | 102 >> +++++++++++++++++++++++++++++++++++----- >>> include/uapi/linux/vfio.h | 19 ++++++++ >>> 2 files changed, 109 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >>> index 3bd70ff..ed80104 100644 >>> --- a/drivers/vfio/vfio_iommu_type1.c >>> +++ b/drivers/vfio/vfio_iommu_type1.c >>> @@ -62,18 +62,20 @@ MODULE_PARM_DESC(dma_entry_limit, >>> "Maximum number of user DMA mappings per container (65535)."); >>> >>> struct vfio_iommu { >>> - struct list_head domain_list; >>> - struct list_head iova_list; >>> - struct vfio_domain *external_domain; /* domain for external user */ >>> - struct mutex lock; >>> - struct rb_root dma_list; >>> - struct blocking_notifier_head notifier; >>> - unsigned int dma_avail; >>> - uint64_t pgsize_bitmap; >>> - bool v2; >>> - bool nesting; >>> - bool dirty_page_tracking; >>> - bool pinned_page_dirty_scope; >>> + struct list_head domain_list; >>> + struct list_head iova_list; >>> + /* domain for external user */ >>> + struct vfio_domain *external_domain; >>> + struct mutex lock; >>> + struct rb_root dma_list; >>> + struct blocking_notifier_head notifier; >>> + unsigned int dma_avail; >>> + uint64_t pgsize_bitmap; >>> + bool v2; >>> + bool nesting; >>> + bool dirty_page_tracking; >>> + bool pinned_page_dirty_scope; >>> + struct iommu_nesting_info *nesting_info; >>> }; >>> >>> struct vfio_domain { >>> @@ -130,6 +132,9 @@ struct vfio_regions { >>> #define IS_IOMMU_CAP_DOMAIN_IN_CONTAINER(iommu) \ >>> (!list_empty(&iommu->domain_list)) >>> >>> +#define CONTAINER_HAS_DOMAIN(iommu) (((iommu)->external_domain) || \ >>> + (!list_empty(&(iommu)->domain_list))) >>> + >>> #define DIRTY_BITMAP_BYTES(n) (ALIGN(n, BITS_PER_TYPE(u64)) / >> BITS_PER_BYTE) >>> >>> /* >>> @@ -1929,6 +1934,13 @@ static void vfio_iommu_iova_insert_copy(struct >> vfio_iommu *iommu, >>> >>> list_splice_tail(iova_copy, iova); >>> } >>> + >>> +static void vfio_iommu_release_nesting_info(struct vfio_iommu *iommu) >>> +{ >>> + kfree(iommu->nesting_info); >>> + iommu->nesting_info = NULL; >>> +} >>> + >>> static int vfio_iommu_type1_attach_group(void *iommu_data, >>> struct iommu_group *iommu_group) >>> { >>> @@ -1959,6 +1971,12 @@ static int vfio_iommu_type1_attach_group(void >> *iommu_data, >>> } >>> } >>> >>> + /* Nesting type container can include only one group */ >>> + if (iommu->nesting && CONTAINER_HAS_DOMAIN(iommu)) { >>> + mutex_unlock(&iommu->lock); >>> + return -EINVAL; >>> + } >>> + >>> group = kzalloc(sizeof(*group), GFP_KERNEL); >>> domain = kzalloc(sizeof(*domain), GFP_KERNEL); >>> if (!group || !domain) { >>> @@ -2029,6 +2047,32 @@ static int vfio_iommu_type1_attach_group(void >> *iommu_data, >>> if (ret) >>> goto out_domain; >>> >>> + /* Nesting cap info is available only after attaching */ >>> + if (iommu->nesting) { >>> + struct iommu_nesting_info tmp = { .size = 0, }; >>> + >>> + /* First get the size of vendor specific nesting info */ >>> + ret = iommu_domain_get_attr(domain->domain, >>> + DOMAIN_ATTR_NESTING, >>> + &tmp); >>> + if (ret) >>> + goto out_detach; >>> + >>> + iommu->nesting_info = kzalloc(tmp.size, GFP_KERNEL); >>> + if (!iommu->nesting_info) { >>> + ret = -ENOMEM; >>> + goto out_detach; >>> + } >>> + >>> + /* Now get the nesting info */ >>> + iommu->nesting_info->size = tmp.size; >>> + ret = iommu_domain_get_attr(domain->domain, >>> + DOMAIN_ATTR_NESTING, >>> + iommu->nesting_info); >>> + if (ret) >>> + goto out_detach; > > get nesting_info failure will result in group_attach failure.[1] > >>> + } >>> + >>> /* Get aperture info */ >>> iommu_domain_get_attr(domain->domain, DOMAIN_ATTR_GEOMETRY, >> &geo); >>> >>> @@ -2138,6 +2182,7 @@ static int vfio_iommu_type1_attach_group(void >> *iommu_data, >>> return 0; >>> >>> out_detach: >>> + vfio_iommu_release_nesting_info(iommu); >>> vfio_iommu_detach_group(domain, group); >>> out_domain: >>> iommu_domain_free(domain->domain); >>> @@ -2338,6 +2383,8 @@ static void vfio_iommu_type1_detach_group(void >> *iommu_data, >>> vfio_iommu_unmap_unpin_all(iommu); >>> else >>> >> vfio_iommu_unmap_unpin_reaccount(iommu); >>> + >>> + vfio_iommu_release_nesting_info(iommu); >>> } >>> iommu_domain_free(domain->domain); >>> list_del(&domain->next); >>> @@ -2546,6 +2593,31 @@ static int vfio_iommu_migration_build_caps(struct >> vfio_iommu *iommu, >>> return vfio_info_add_capability(caps, &cap_mig.header, sizeof(cap_mig)); >>> } >>> >>> +static int vfio_iommu_info_add_nesting_cap(struct vfio_iommu *iommu, >>> + struct vfio_info_cap *caps) >>> +{ >>> + struct vfio_info_cap_header *header; >>> + struct vfio_iommu_type1_info_cap_nesting *nesting_cap; >>> + size_t size; >>> + >>> + size = offsetof(struct vfio_iommu_type1_info_cap_nesting, info) + >>> + iommu->nesting_info->size; >>> + >>> + header = vfio_info_cap_add(caps, size, >>> + VFIO_IOMMU_TYPE1_INFO_CAP_NESTING, 1); >>> + if (IS_ERR(header)) >>> + return PTR_ERR(header); >>> + >>> + nesting_cap = container_of(header, >>> + struct vfio_iommu_type1_info_cap_nesting, >>> + header); >>> + >>> + memcpy(&nesting_cap->info, iommu->nesting_info, >>> + iommu->nesting_info->size); >> you must check whether nesting_info is non NULL before doing that. > > it's now validated in the caller of this function. :-) ah ok sorry I missed that. > >> Besides I agree with Jean on the fact it may be better to not report the >> capability if nested is not supported. > > I see. in this patch, just few lines below [2], vfio only reports nesting > cap when iommu->nesting_info is non-null. so even if userspace selected > nesting type, it may fail at the VFIO_SET_IOMMU phase since group_attach > will be failed for NESTED type container if host iommu doesn’t support > nesting. the code is marked as [1] in this email. OK that's already there then. Thanks Eric > >>> + >>> + return 0; >>> +} >>> + >>> static int vfio_iommu_type1_get_info(struct vfio_iommu *iommu, >>> unsigned long arg) >>> { >>> @@ -2581,6 +2653,12 @@ static int vfio_iommu_type1_get_info(struct >> vfio_iommu *iommu, >>> if (!ret) >>> ret = vfio_iommu_iova_build_caps(iommu, &caps); >>> >>> + if (iommu->nesting_info) { >>> + ret = vfio_iommu_info_add_nesting_cap(iommu, &caps); >>> + if (ret) >>> + return ret; > > here checks nesting_info before reporting nesting cap. [2] > >>> + } >>> + >>> mutex_unlock(&iommu->lock); >>> >>> if (ret) >>> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >>> index 9204705..46a78af 100644 >>> --- a/include/uapi/linux/vfio.h >>> +++ b/include/uapi/linux/vfio.h >>> @@ -14,6 +14,7 @@ >>> >>> #include >>> #include >>> +#include >>> >>> #define VFIO_API_VERSION 0 >>> >>> @@ -1039,6 +1040,24 @@ struct vfio_iommu_type1_info_cap_migration { >>> __u64 max_dirty_bitmap_size; /* in bytes */ >>> }; >>> >>> +/* >>> + * The nesting capability allows to report the related capability >>> + * and info for nesting iommu type. >>> + * >>> + * The structures below define version 1 of this capability. >>> + * >>> + * User space selected VFIO_TYPE1_NESTING_IOMMU type should check >>> + * this capto get supported features. >> s/capto/capability to get > > got it. > > Regards, > Yi Liu > >>> + * >>> + * @info: the nesting info provided by IOMMU driver. >>> + */ >>> +#define VFIO_IOMMU_TYPE1_INFO_CAP_NESTING 3 >>> + >>> +struct vfio_iommu_type1_info_cap_nesting { >>> + struct vfio_info_cap_header header; >>> + struct iommu_nesting_info info; >>> +}; >>> + >>> #define VFIO_IOMMU_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12) >>> >>> /** >>> >> >> Thanks >> >> Eric >