From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH] eal/x86: don't export internal alignment macro
Date: Wed, 22 Jun 2022 11:32:26 +0200 [thread overview]
Message-ID: <3494576.HovnAMPojK@thomas> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8714C@smartserver.smartshare.dk>
21/06/2022 16:28, Morten Brørup:
> > From: David Marchand [mailto:david.marchand@redhat.com]
> > Sent: Tuesday, 21 June 2022 16.13
> >
> > ALIGNMENT_MASK is only used internally.
> > Besides it lacks a DPDK-related prefix.
> > Hide it from external eyes.
> >
> > Reported-by: Morten Brørup <mb@smartsharesystems.com>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > --- a/lib/eal/x86/include/rte_memcpy.h
> > +++ b/lib/eal/x86/include/rte_memcpy.h
> > +#undef ALIGNMENT_MASK
>
> You could consider also giving another name with a lower risk of collision.
> However, I think the risk is very low, since it can only collide with other headers being included before this header file, so this suffices.
>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
Cc: stable@dpdk.org
Applied, thanks.
prev parent reply other threads:[~2022-06-22 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 14:13 [PATCH] eal/x86: don't export internal alignment macro David Marchand
2022-06-21 14:28 ` Morten Brørup
2022-06-22 9:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3494576.HovnAMPojK@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.