From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91325C433EF for ; Thu, 10 Feb 2022 09:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238411AbiBJJVQ (ORCPT ); Thu, 10 Feb 2022 04:21:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238408AbiBJJVP (ORCPT ); Thu, 10 Feb 2022 04:21:15 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED5AEB4; Thu, 10 Feb 2022 01:21:15 -0800 (PST) Received: from dggeme761-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JvWRK3nKBz9sZY; Thu, 10 Feb 2022 17:19:41 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeme761-chm.china.huawei.com (10.3.19.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Thu, 10 Feb 2022 17:21:13 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2308.021; Thu, 10 Feb 2022 17:21:13 +0800 From: "Gonglei (Arei)" To: zhenwei pi CC: "jasowang@redhat.com" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "helei.sig11@bytedance.com" , "mst@redhat.com" Subject: RE: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service Thread-Topic: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service Thread-Index: AQHYDm47poB50P1RmUal7n5E+2vGlKyMgQ2Q//+Jc4CAAJcu4A== Date: Thu, 10 Feb 2022 09:21:13 +0000 Message-ID: <34ba8701eb86414e826824892e2f0892@huawei.com> References: <20220121022438.1042547-1-pizhenwei@bytedance.com> <20220121022438.1042547-3-pizhenwei@bytedance.com> <15e960491a684b649e5d0179a32848a2@huawei.com> <540f29e4-12ef-3786-bd54-9a94ba6ee7ab@bytedance.com> In-Reply-To: <540f29e4-12ef-3786-bd54-9a94ba6ee7ab@bytedance.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogemhlbndlaSBwaSBbbWFp bHRvOnBpemhlbndlaUBieXRlZGFuY2UuY29tXQ0KPiBTZW50OiBUaHVyc2RheSwgRmVicnVhcnkg MTAsIDIwMjIgNDoxOCBQTQ0KPiBUbzogR29uZ2xlaSAoQXJlaSkgPGFyZWkuZ29uZ2xlaUBodWF3 ZWkuY29tPg0KPiBDYzogamFzb3dhbmdAcmVkaGF0LmNvbTsgdmlydHVhbGl6YXRpb25AbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmc7DQo+IGxpbnV4LWNyeXB0b0B2Z2VyLmtlcm5lbC5vcmc7IGxp bnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+IGhlbGVpLnNpZzExQGJ5dGVkYW5jZS5jb207 IG1zdEByZWRoYXQuY29tDQo+IFN1YmplY3Q6IFJlOiBSRTogW1BBVENIIDIvM10gdmlydGlvLWNy eXB0bzogaW50cm9kdWNlIGFrY2lwaGVyIHNlcnZpY2UNCj4gDQo+ID4+ICAgLyogVGhlIGFjY2Vs ZXJhdG9yIGhhcmR3YXJlIGlzIHJlYWR5ICovICAjZGVmaW5lDQo+ID4+IFZJUlRJT19DUllQVE9f U19IV19SRUFEWSAgKDEgPDwgMCkgQEAgLTQ0Miw2ICs1MjAsNyBAQCBzdHJ1Y3QNCj4gPj4gdmly dGlvX2NyeXB0b19jb25maWcgew0KPiA+PiAgIAlfX2xlMzIgcmVzZXJ2ZTsNCj4gPj4gICAJLyog TWF4aW11bSBzaXplIG9mIGVhY2ggY3J5cHRvIHJlcXVlc3QncyBjb250ZW50ICovDQo+ID4+ICAg CV9fbGU2NCBtYXhfc2l6ZTsNCj4gPj4gKwlfX2xlMzIgYWtjaXBoZXJfYWxnbzsNCj4gPj4gICB9 Ow0KPiA+Pg0KPiA+IFlvdSBjYW4gdXNlIHRoZSByZXNlcnZlIGF0dHJpYnV0ZS4gS2VlcGluZyA2 NC1iaXQgYWxpZ25lZC4NCj4gPg0KPiA+PiAgIHN0cnVjdCB2aXJ0aW9fY3J5cHRvX2luaGRyIHsN Cj4gPj4gLS0NCj4gPj4gMi4yNS4xDQo+ID4NCj4gDQo+IENhbiBJIHVzZSB0aGUgIl9fbGUzMiBy ZXNlcnZlOyIgZmllbGQgZGlyZWN0bHk/DQo+IA0KPiBzdHJ1Y3QgdmlydGlvX2NyeXB0b19jb25m aWcgew0KPiAgICAgICAgICAvKiBTZWUgVklSVElPX0NSWVBUT19PUF8qIGFib3ZlICovDQo+ICAg ICAgICAgIF9fbGUzMiAgc3RhdHVzOw0KPiANCj4gICAgICAgICAgLyoNCj4gICAgICAgICAgICog TWF4aW11bSBudW1iZXIgb2YgZGF0YSBxdWV1ZQ0KPiAgICAgICAgICAgKi8NCj4gICAgICAgICAg X19sZTMyICBtYXhfZGF0YXF1ZXVlczsNCj4gDQo+ICAgICAgICAgIC8qDQo+ICAgICAgICAgICAq IFNwZWNpZmllcyB0aGUgc2VydmljZXMgbWFzayB3aGljaCB0aGUgZGV2aWNlIHN1cHBvcnQsDQo+ ICAgICAgICAgICAqIHNlZSBWSVJUSU9fQ1JZUFRPX1NFUlZJQ0VfKiBhYm92ZQ0KPiAgICAgICAg ICAgKi8NCj4gICAgICAgICAgX19sZTMyIGNyeXB0b19zZXJ2aWNlczsNCj4gDQo+ICAgICAgICAg IC8qIERldGFpbGVkIGFsZ29yaXRobXMgbWFzayAqLw0KPiAgICAgICAgICBfX2xlMzIgY2lwaGVy X2FsZ29fbDsNCj4gICAgICAgICAgX19sZTMyIGNpcGhlcl9hbGdvX2g7DQo+ICAgICAgICAgIF9f bGUzMiBoYXNoX2FsZ287DQo+ICAgICAgICAgIF9fbGUzMiBtYWNfYWxnb19sOw0KPiAgICAgICAg ICBfX2xlMzIgbWFjX2FsZ29faDsNCj4gICAgICAgICAgX19sZTMyIGFlYWRfYWxnbzsNCj4gICAg ICAgICAgLyogTWF4aW11bSBsZW5ndGggb2YgY2lwaGVyIGtleSAqLw0KPiAgICAgICAgICBfX2xl MzIgbWF4X2NpcGhlcl9rZXlfbGVuOw0KPiAgICAgICAgICAvKiBNYXhpbXVtIGxlbmd0aCBvZiBh dXRoZW50aWNhdGVkIGtleSAqLw0KPiAgICAgICAgICBfX2xlMzIgbWF4X2F1dGhfa2V5X2xlbjsN Cj4gICAgICAgICAgX19sZTMyIHJlc2VydmU7ICAgICAgICAgICAgLS0+ICAgIF9fbGUzMiBha2Np cGhlcl9hbGdvOw0KPiAgICAgICAgICAvKiBNYXhpbXVtIHNpemUgb2YgZWFjaCBjcnlwdG8gcmVx dWVzdCdzIGNvbnRlbnQgKi8NCj4gICAgICAgICAgX19sZTY0IG1heF9zaXplOw0KPiB9Ow0KPiAN Cg0KDQpZZXMsIEkgdGhpbmsgc28uIE90aGVyd2lzZSB5b3Ugd2lsbCBhZGQgb3RoZXIgcmVzZXJ2 ZWQgZmllbGQgOigNCg0KUmVnYXJkcywNCi1Hb25nbGVpDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D67BC433F5 for ; Thu, 10 Feb 2022 09:21:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1E64F829FD; Thu, 10 Feb 2022 09:21:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ikcljN5bcYFO; Thu, 10 Feb 2022 09:21:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id AFF18829B6; Thu, 10 Feb 2022 09:21:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 855F1C001A; Thu, 10 Feb 2022 09:21:24 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id AD77DC000B for ; Thu, 10 Feb 2022 09:21:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8CFAA60E6A for ; Thu, 10 Feb 2022 09:21:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L5O6mHZyVpjs for ; Thu, 10 Feb 2022 09:21:19 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7F30160E68 for ; Thu, 10 Feb 2022 09:21:19 +0000 (UTC) Received: from dggeme761-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JvWRK3nKBz9sZY; Thu, 10 Feb 2022 17:19:41 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggeme761-chm.china.huawei.com (10.3.19.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Thu, 10 Feb 2022 17:21:13 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2308.021; Thu, 10 Feb 2022 17:21:13 +0800 To: zhenwei pi Subject: RE: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service Thread-Topic: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service Thread-Index: AQHYDm47poB50P1RmUal7n5E+2vGlKyMgQ2Q//+Jc4CAAJcu4A== Date: Thu, 10 Feb 2022 09:21:13 +0000 Message-ID: <34ba8701eb86414e826824892e2f0892@huawei.com> References: <20220121022438.1042547-1-pizhenwei@bytedance.com> <20220121022438.1042547-3-pizhenwei@bytedance.com> <15e960491a684b649e5d0179a32848a2@huawei.com> <540f29e4-12ef-3786-bd54-9a94ba6ee7ab@bytedance.com> In-Reply-To: <540f29e4-12ef-3786-bd54-9a94ba6ee7ab@bytedance.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: "helei.sig11@bytedance.com" , "mst@redhat.com" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Gonglei \(Arei\) via Virtualization" Reply-To: "Gonglei \(Arei\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" > -----Original Message----- > From: zhenwei pi [mailto:pizhenwei@bytedance.com] > Sent: Thursday, February 10, 2022 4:18 PM > To: Gonglei (Arei) > Cc: jasowang@redhat.com; virtualization@lists.linux-foundation.org; > linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; > helei.sig11@bytedance.com; mst@redhat.com > Subject: Re: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service > > >> /* The accelerator hardware is ready */ #define > >> VIRTIO_CRYPTO_S_HW_READY (1 << 0) @@ -442,6 +520,7 @@ struct > >> virtio_crypto_config { > >> __le32 reserve; > >> /* Maximum size of each crypto request's content */ > >> __le64 max_size; > >> + __le32 akcipher_algo; > >> }; > >> > > You can use the reserve attribute. Keeping 64-bit aligned. > > > >> struct virtio_crypto_inhdr { > >> -- > >> 2.25.1 > > > > Can I use the "__le32 reserve;" field directly? > > struct virtio_crypto_config { > /* See VIRTIO_CRYPTO_OP_* above */ > __le32 status; > > /* > * Maximum number of data queue > */ > __le32 max_dataqueues; > > /* > * Specifies the services mask which the device support, > * see VIRTIO_CRYPTO_SERVICE_* above > */ > __le32 crypto_services; > > /* Detailed algorithms mask */ > __le32 cipher_algo_l; > __le32 cipher_algo_h; > __le32 hash_algo; > __le32 mac_algo_l; > __le32 mac_algo_h; > __le32 aead_algo; > /* Maximum length of cipher key */ > __le32 max_cipher_key_len; > /* Maximum length of authenticated key */ > __le32 max_auth_key_len; > __le32 reserve; --> __le32 akcipher_algo; > /* Maximum size of each crypto request's content */ > __le64 max_size; > }; > Yes, I think so. Otherwise you will add other reserved field :( Regards, -Gonglei _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization