From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36D47C433EF for ; Thu, 10 Mar 2022 10:45:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CCE83611E2; Thu, 10 Mar 2022 10:45:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BsoNkZfqL9fz; Thu, 10 Mar 2022 10:45:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 07D5B611EB; Thu, 10 Mar 2022 10:45:47 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1A3F51BF293 for ; Thu, 10 Mar 2022 10:45:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 16FF940951 for ; Thu, 10 Mar 2022 10:45:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OaLwiun4Qrnr for ; Thu, 10 Mar 2022 10:45:45 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0B1604091B for ; Thu, 10 Mar 2022 10:45:44 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-310-8N1hxeIKM0qIHBgwRBSVmA-1; Thu, 10 Mar 2022 10:45:42 +0000 X-MC-Unique: 8N1hxeIKM0qIHBgwRBSVmA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Thu, 10 Mar 2022 10:45:41 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.028; Thu, 10 Mar 2022 10:45:41 +0000 From: David Laight To: 'Mathieu Mirmont' , "buildroot@buildroot.org" Thread-Topic: [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns Thread-Index: AQHYNGk1T+9nJKOaGEy6uS9IhKyXC6y4bnOA Date: Thu, 10 Mar 2022 10:45:41 +0000 Message-ID: <34cb1e87c9ff49b897ae79c543278d03@AcuMS.aculab.com> References: <20220310101826.GA2353@parad0x.org> In-Reply-To: <20220310101826.GA2353@parad0x.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Subject: Re: [Buildroot] [PATCH 1/1] fs/common.mk: use find instead of shell glob patterns X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" From: Mathieu Mirmont > Sent: 10 March 2022 10:18 > > Different shells can have different behaviours when it comes to > globbing patterns. The dash shell (/bin/sh) on Debian testing switched > to a different fnmatch/glob implementation that results in this new > behaviour: > > Using bash: > $ mkdir /tmp/foo > $ echo /tmp/foo/.[^.]* > /tmp/foo/.[^.]* > > Using dash: > $ mkdir /tmp/foo > $ echo /tmp/foo/.[^.]* > /tmp/foo/.. That is just broken. Does the [^x] pattern work at all? Raise a bug on 'Debian testing' hopefully they'll fix it before it actually gets released anywhere. For this script I'd just ignore errors from rm. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot