From: David Ahern <dsahern@gmail.com>
To: Petr Machata <petrm@nvidia.com>, netdev@vger.kernel.org
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next 11/12] nexthop: Add a callback parameter to rtm_dump_walk_nexthops()
Date: Thu, 28 Jan 2021 20:20:39 -0700 [thread overview]
Message-ID: <34d94e42-42e0-198a-84ff-add87b4d0a2f@gmail.com> (raw)
In-Reply-To: <8f895fa4bb87f623226aaf681faec62da3ce0432.1611836479.git.petrm@nvidia.com>
On 1/28/21 5:49 AM, Petr Machata wrote:
> In order to allow different handling for next-hop tree dumper and for
> bucket dumper, parameterize the next-hop tree walker with a callback. Add
> rtm_dump_nexthop_cb() with just the bits relevant for next-hop tree
> dumping.
>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> ---
> net/ipv4/nexthop.c | 32 ++++++++++++++++++++++----------
> 1 file changed, 22 insertions(+), 10 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2021-01-29 3:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 12:49 [PATCH net-next 00/12] nexthop: Preparations for resilient next-hop groups Petr Machata
2021-01-28 12:49 ` [PATCH net-next 01/12] nexthop: Rename nexthop_free_mpath Petr Machata
2021-01-29 3:05 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 02/12] nexthop: Dispatch nexthop_select_path() by group type Petr Machata
2021-01-29 3:08 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 03/12] nexthop: Introduce to struct nh_grp_entry a per-type union Petr Machata
2021-01-29 3:09 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 04/12] nexthop: Assert the invariant that a NH group is of only one type Petr Machata
2021-01-29 3:10 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 05/12] nexthop: Use enum to encode notification type Petr Machata
2021-01-29 3:12 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 06/12] nexthop: Dispatch notifier init()/fini() by group type Petr Machata
2021-01-29 3:13 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 07/12] nexthop: Extract dump filtering parameters into a single structure Petr Machata
2021-01-29 3:16 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 08/12] nexthop: Extract a common helper for parsing dump attributes Petr Machata
2021-01-29 3:17 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 09/12] nexthop: Strongly-type context of rtm_dump_nexthop() Petr Machata
2021-01-29 3:18 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 10/12] nexthop: Extract a helper for walking the next-hop tree Petr Machata
2021-01-29 3:19 ` David Ahern
2021-01-28 12:49 ` [PATCH net-next 11/12] nexthop: Add a callback parameter to rtm_dump_walk_nexthops() Petr Machata
2021-01-29 3:20 ` David Ahern [this message]
2021-01-28 12:49 ` [PATCH net-next 12/12] nexthop: Extract a helper for validation of get/del RTNL requests Petr Machata
2021-01-29 3:21 ` David Ahern
2021-01-29 3:24 ` [PATCH net-next 00/12] nexthop: Preparations for resilient next-hop groups David Ahern
2021-01-29 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34d94e42-42e0-198a-84ff-add87b4d0a2f@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.