From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH -next] powernv: cpufreq: Fix uninitialized lpstate_idx in gpstates_timer_handler Date: Mon, 14 Nov 2016 22:18:46 +0100 Message-ID: <3500978.xDPxi6xF2C@vostro.rjw.lan> References: <1479124767-20165-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1479124767-20165-1-git-send-email-akshay.adiga@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Akshay Adiga Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ego@linux.vnet.ibm.com List-Id: linux-pm@vger.kernel.org On Monday, November 14, 2016 05:29:27 PM Akshay Adiga wrote: > lpstate_idx remains uninitialized in the case when elapsed_time > is greater than MAX_RAMP_DOWN_TIME. At the end of rampdown > global pstate should be equal to local pstate. > > Fixes: 20b15b766354 ("cpufreq: powernv: Use PMCR to verify global and > localpstate") > Reported-by: Stephen Rothwell > Signed-off-by: Akshay Adiga > --- > drivers/cpufreq/powernv-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index c82304b..c5c5bc3 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -624,6 +624,7 @@ void gpstate_timer_handler(unsigned long data) > > if (gpstates->elapsed_time > MAX_RAMP_DOWN_TIME) { > gpstate_idx = pstate_to_idx(freq_data.pstate_id); > + lpstate_idx = gpstate_idx; > reset_gpstates(policy); > gpstates->highest_lpstate_idx = gpstate_idx; > } else { > Applied. Thanks, Rafael