From: Patrick Boettcher <pboettcher@kernellabs.com>
To: Dave Jones <davej@redhat.com>
Cc: mchehab@redhat.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko
Date: Thu, 05 Sep 2013 09:28:13 +0200 [thread overview]
Message-ID: <3501409.n7PgjBMFjV@dibcom294> (raw)
In-Reply-To: <20130904235917.GC5727@redhat.com>
Hi Dave,
On Wednesday 04 September 2013 19:59:17 Dave Jones wrote:
> This looks like it was cut and pasted from the code above which does
> similar checks on txlen, but someone forgot to change the variable.
This someone would be me.
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
>
> diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c
> b/drivers/media/usb/dvb-usb/technisat-usb2.c index 40832a1..98d24ae
> 100644
> --- a/drivers/media/usb/dvb-usb/technisat-usb2.c
> +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
> @@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device
> *udev, if (rxlen > 62) {
> err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
> device_addr);
> - txlen = 62;
> + rxlen = 62;
> }
>
> b[0] = I2C_SPEED_100KHZ_BIT;
Nice catch.
Mauro, feel free to add my signed-off-line, when integrating
Signed-off-by: Patrick Boettcher <pboettcher@kernellabs.com>
--
Patrick
prev parent reply other threads:[~2013-09-05 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 23:59 dvb-usb/technisat-usb2: Fix cut-n-paste thinko Dave Jones
2013-09-05 7:28 ` Patrick Boettcher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3501409.n7PgjBMFjV@dibcom294 \
--to=pboettcher@kernellabs.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.