From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Qi.Chen@windriver.com
Cc: qingtao.cao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V3 3/3] usersettings.bbclass: add a new bbclass
Date: Thu, 11 Jul 2013 14:07:24 +0100 [thread overview]
Message-ID: <3506531.RcxvtcqNz1@helios> (raw)
In-Reply-To: <6939690.qrXmoo12No@helios>
On Thursday 11 July 2013 13:58:17 Paul Eggleton wrote:
> On Thursday 11 July 2013 19:11:39 Qi.Chen@windriver.com wrote:
> > +IMAGE_INSTALL_append += "${@['', 'base-passwd
> > shadow'][bool(d.getVar('USER_GROUP_SETTINGS', True))]}"
>
> This is a bit ugly. We should avoid using _append += since it is confusing,
> and we have base_conditional for things like this. I'd suggest:
>
> IMAGE_INSTALL_append = "${@base_conditional('USER_GROUP_SETTINGS', '1', '
> base-passwd shadow', '', d)}"
Actually reading this again I've misinterpreted what it's supposed to be
doing. Unfortunately I don't think we have a neat base_ifset() or similar so
perhaps this will need to be left as-is. I still think we should avoid _append
+= however.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-07-11 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 11:11 [PATCH V3 0/3] Add a method for image level user/group configuration Qi.Chen
2013-07-11 11:11 ` [PATCH V3 1/3] userbase.bbclass: add a new bbclass Qi.Chen
2013-07-11 11:11 ` [PATCH V3 2/3] useradd.bbclass: code refactor Qi.Chen
2013-07-11 11:11 ` [PATCH V3 3/3] usersettings.bbclass: add a new bbclass Qi.Chen
2013-07-11 12:58 ` Paul Eggleton
2013-07-11 13:07 ` Paul Eggleton [this message]
2013-07-11 15:02 ` Mark Hatle
2013-07-11 12:49 ` [PATCH V3 0/3] Add a method for image level user/group configuration Paul Eggleton
2013-07-11 16:00 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3506531.RcxvtcqNz1@helios \
--to=paul.eggleton@linux.intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.