From: Thomas Monjalon <thomas@monjalon.net>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le)
Date: Mon, 06 Nov 2023 14:54:04 +0100 [thread overview]
Message-ID: <3512484.V25eIC5XRa@thomas> (raw)
In-Reply-To: <2e4354af-824d-9b1c-b61f-b6501393212e@linux.vnet.ibm.com>
23/10/2023 23:59, David Christensen:
>
> On 10/17/23 5:39 AM, Thomas Monjalon wrote:
> > I feel this function should not be implemented in the common EAL.
> > What about adding a new function in lib/eal/ppc/ ?
> > And add the "return true" for other architectures?
>
> Would it be more appropriate in the lib/eal/common level or
> lib/eal/linux only? I would expect the MMU requirement should apply to
> FreeBSD on ppc64le as well but IBM doesn't support or test FreeBSD
> internally.
Even if you are not testing it, I don't think you should restrict
the code change to Linux.
next prev parent reply other threads:[~2023-11-06 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 22:51 [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le) David Christensen
2023-10-17 12:39 ` Thomas Monjalon
2023-10-23 21:59 ` David Christensen
2023-11-06 13:54 ` Thomas Monjalon [this message]
2023-10-23 23:19 ` [PATCH v2] eal/linux: " David Christensen
2023-10-24 2:02 ` David Christensen
2023-10-24 17:43 ` [PATCH v3] " David Christensen
2023-11-06 13:55 ` Thomas Monjalon
2023-11-30 19:18 ` [PATCH v4] eal: " David Christensen
2024-05-30 16:44 ` [PATCH v5] " David Christensen
2024-06-28 12:10 ` David Marchand
2024-07-10 23:21 ` [PATCH v6] " David Christensen
2024-07-10 23:38 ` [PATCH v7] " David Christensen
2024-07-12 9:03 ` David Marchand
[not found] ` <20240529183222.105731-1-drc@linux.vnet.ibm.com>
2024-06-27 21:11 ` [PATCH v5] " David Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3512484.V25eIC5XRa@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.