Re: [dpdk-dev] [PATCH v4 0/3] add ABI checks

[Thomas Monjalon <thomas@monjalon.net>]

02/02/2020 22:08, David Marchand:
> Here is the current state of the ABI checks.
> 
> libabigail has some issues when mixing dump and so files compiled with
> clang [1], so for now, all checks are done on dumps only.
> libabigail 1.0-rc3 in Xenial reported issues that disappear with the
> version 1.2 in Bionic.
> 
> To avoid getting warnings on internal types like [2], the checks now make
> use of the public headers part of a dpdk installation (patch 2 and 3 to
> prepare for this).
> 
> Some internal rte_hash headers were installed by meson, so patch 1 fixes
> this.
> 
> The most important point, abidiff complains on the rc1 cryptodev changes:
> - Chacha20-Poly1305 AEAD support,
> - ECPM and ECDSA support
> 
> A suppression rule has been put on the internal type rte_cryptodev_ops.
> But other changes are an ABI breakage afaiu. I put suppression rules on
> them so that we can run the checks, but some action must be taken for
> 20.02 if my analysis is confirmed.

The suppression rules for Chacha-Poly are removed,
and Chacha-Poly commits are reverted while merging this series.


> Special thanks to Dodji the libabigail maintainer for helping on this
> topic.
> 
> 1: https://sourceware.org/bugzilla/show_bug.cgi?id=25409
> 2: http://inbox.dpdk.org/dev/CAJFAV8yFKoDZROX9Mkyp7pDMvXw3e7mHwxjfrcjD5ZoFB2tZ8w@mail.gmail.com/


Applied, thanks