From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sven Eckelmann Date: Mon, 24 Dec 2018 19:46:32 +0100 Message-ID: <3515548.IyJqbIalli@sven-edge> In-Reply-To: <20181224174926.20321-1-pakki001@umn.edu> References: <20181224174926.20321-1-pakki001@umn.edu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart140518754.v2Ycy2XqpW"; micalg="pgp-sha512"; protocol="application/pgp-signature" Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org Cc: Aditya Pakki , Marek Lindner , kjlu@umn.edu, Antonio Quartulli , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" --nextPart140518754.v2Ycy2XqpW Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote: > rtnl_link_register() may fail and can impact registering the device. > The fix checks the return value and pushes the error upstream. Regarding the commit message - what is "batman-adv/main"? Shouldn't this be "batman-adv: "? And the device can still be registered without batadv_link_ops - just not using rtnl. Kind regards, Sven --nextPart140518754.v2Ycy2XqpW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlwhKYgACgkQXYcKB8Em e0ZL0RAAxtawbTcwqlL8r79AWaXuiWh9o+J0ZZVRd+9hjfA0RnJpRgf66Q7Itas2 EjXOaPjvEwNXG3fNORRMjvaFrjitPTjahyJiYVjlsF8D09rZkCRBQ2DtkEFKuQFG GvYYbtd0zB1FYEQuA6P7j+TMi9Iocpy+afeVTFdgKzJfRe9n1uiqSiNxvLyTdv8g DpZ054QKXhD2EpJxDT5RF6mJMeWnHqj4DYQ9jWyLk0IYicPYrByIN1QPBlwYYBR7 fHYXGT2g+4IWIOPZa2slbmr/U5FEK8kjAqtfhK98zR+MnsRH2oB+JGONmELzINRb aGcGgw7pDmvVEX+myqFPWI6hPWwvYOyLIeVwW7qdTSMpmZyT1r5znw2hx7TzFwMj jRplEh3kUkP1wVn+D91G9JxAvMxbZyecCv9rLgEnLRk86aqH5e+mKTt/UmM1bcOp zKrw8VnSzC/e6VURdGE1ZTAu3XOerQpD7tW+ZSW39zJ/uZNWM0nxHhHdX4qyW2wu Hn/V11b8uwzzZZ6ZCfq2LLucdNqk2rwQx/a5hYneWsx+3t7tQE2PUo2uLzRRjBhU OQaIdZQZQPwOpXv57xKWUAzZdyt8VRf4qtXFCzxScHtGPd6tuk+aRdUKbj4DgIl9 HRhcp6U5ZIaJijiFbi6gvpAGFtv0lz04jxqSgz3MvaLiTVNLUFk= =8Nd8 -----END PGP SIGNATURE----- --nextPart140518754.v2Ycy2XqpW-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sven Eckelmann Subject: Re: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register Date: Mon, 24 Dec 2018 19:46:32 +0100 Message-ID: <3515548.IyJqbIalli@sven-edge> References: <20181224174926.20321-1-pakki001@umn.edu> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart140518754.v2Ycy2XqpW"; micalg="pgp-sha512"; protocol="application/pgp-signature" Cc: Marek Lindner , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Antonio Quartulli , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Aditya Pakki , kjlu-OJFnDUYgAso@public.gmane.org, "David S. Miller" To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Return-path: In-Reply-To: <20181224174926.20321-1-pakki001-OJFnDUYgAso@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org --nextPart140518754.v2Ycy2XqpW Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote: > rtnl_link_register() may fail and can impact registering the device. > The fix checks the return value and pushes the error upstream. Regarding the commit message - what is "batman-adv/main"? Shouldn't this be "batman-adv: "? And the device can still be registered without batadv_link_ops - just not using rtnl. Kind regards, Sven --nextPart140518754.v2Ycy2XqpW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlwhKYgACgkQXYcKB8Em e0ZL0RAAxtawbTcwqlL8r79AWaXuiWh9o+J0ZZVRd+9hjfA0RnJpRgf66Q7Itas2 EjXOaPjvEwNXG3fNORRMjvaFrjitPTjahyJiYVjlsF8D09rZkCRBQ2DtkEFKuQFG GvYYbtd0zB1FYEQuA6P7j+TMi9Iocpy+afeVTFdgKzJfRe9n1uiqSiNxvLyTdv8g DpZ054QKXhD2EpJxDT5RF6mJMeWnHqj4DYQ9jWyLk0IYicPYrByIN1QPBlwYYBR7 fHYXGT2g+4IWIOPZa2slbmr/U5FEK8kjAqtfhK98zR+MnsRH2oB+JGONmELzINRb aGcGgw7pDmvVEX+myqFPWI6hPWwvYOyLIeVwW7qdTSMpmZyT1r5znw2hx7TzFwMj jRplEh3kUkP1wVn+D91G9JxAvMxbZyecCv9rLgEnLRk86aqH5e+mKTt/UmM1bcOp zKrw8VnSzC/e6VURdGE1ZTAu3XOerQpD7tW+ZSW39zJ/uZNWM0nxHhHdX4qyW2wu Hn/V11b8uwzzZZ6ZCfq2LLucdNqk2rwQx/a5hYneWsx+3t7tQE2PUo2uLzRRjBhU OQaIdZQZQPwOpXv57xKWUAzZdyt8VRf4qtXFCzxScHtGPd6tuk+aRdUKbj4DgIl9 HRhcp6U5ZIaJijiFbi6gvpAGFtv0lz04jxqSgz3MvaLiTVNLUFk= =8Nd8 -----END PGP SIGNATURE----- --nextPart140518754.v2Ycy2XqpW--