From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice
Date: Wed, 17 Jul 2013 21:55:58 +0400 [thread overview]
Message-ID: <3516310.x8V9U5xGG7@icedphoenix> (raw)
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
See screenshots included.
If the center slice is NULL then west or north slice is also NULL so the
height_n or width_w is also NULL. We can count these values from raw (non-
scaled) bitmaps. The values will be the same as before for common cases. And
the bug will be fixed.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
[-- Attachment #2: after-widget-box.png --]
[-- Type: image/png, Size: 292 bytes --]
[-- Attachment #3: grub-widget-box-fix.patch --]
[-- Type: text/x-patch, Size: 628 bytes --]
diff -Naur grub-2.01/grub-core/gfxmenu/widget-box.c grub-box-draw/grub-core/gfxmenu/widget-box.c
--- grub-2.01/grub-core/gfxmenu/widget-box.c 2013-02-25 16:54:27.000000000 +0400
+++ grub-box-draw/grub-core/gfxmenu/widget-box.c 2013-07-17 21:25:10.536077964 +0400
@@ -81,8 +81,8 @@
int height_n;
int width_w;
- height_n = get_height (self->scaled_pixmaps[BOX_PIXMAP_N]);
- width_w = get_width (self->scaled_pixmaps[BOX_PIXMAP_W]);
+ height_n = get_height (self->raw_pixmaps[BOX_PIXMAP_N]);
+ width_w = get_width (self->raw_pixmaps[BOX_PIXMAP_W]);
/* Draw sides. */
blit (self, BOX_PIXMAP_N, x + width_w, y);
[-- Attachment #4: before-widget-box.png --]
[-- Type: image/png, Size: 308 bytes --]
next reply other threads:[~2013-07-17 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 17:55 Vladimir Testov [this message]
2013-07-20 14:18 ` [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice Andrey Borzenkov
2013-07-22 7:36 ` Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3516310.x8V9U5xGG7@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.