From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] compat: fix symbol version support with meson
Date: Sun, 16 Sep 2018 11:14:10 +0200 [thread overview]
Message-ID: <3518182.H5eQSvgRL9@xps> (raw)
In-Reply-To: <1535650263.11823.18.camel@debian.org>
30/08/2018 19:31, Luca Boccassi:
> On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> > For meson builds, the define to enable the symbol version
> > macros in rte_compat.h was missing. This led to symbols being
> > omitted from shared objects. For example, checking rte_distributor.so
> > with objdump and comparing make and meson built versions:
> >
> > $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> > 0000000000001b60 g DF .text 00000000000000a7
> > (DPDK_2.0) rte_distributor_flush
> > 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05
> > rte_distributor_flush
> > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> > 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0
> > rte_distributor_flush
> >
> > Adding in the missing define fixes this.
> >
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> >
> > Reported-by: Luca Boccassi <bluca@debian.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Tested-by: Luca Boccassi <bluca@debian.org>
Cc stable?
next prev parent reply other threads:[~2018-09-16 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:07 [PATCH] compat: fix symbol version support with meson Bruce Richardson
2018-08-30 17:31 ` Luca Boccassi
2018-09-16 9:14 ` Thomas Monjalon [this message]
2018-09-17 8:17 ` Bruce Richardson
2018-09-17 8:18 ` [PATCH v2] " Bruce Richardson
2018-09-17 8:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3518182.H5eQSvgRL9@xps \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.