From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 26 Apr 2018 01:05:06 +0300 Message-ID: <3518575.OAoTTXDygq@avalon> References: <20180425075314.19137-1-philippe.cornu@st.com> <1559016.ZjzeSVB84W@avalon> <20180425171123.xhyoay3nu463btoq@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180425171123.xhyoay3nu463btoq@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , David Airlie , Philippe CORNU , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKT24gV2VkbmVzZGF5LCAyNSBBcHJpbCAyMDE4IDIwOjExOjIzIEVFU1QgUm9iIEhl cnJpbmcgd3JvdGU6Cj4gT24gV2VkLCBBcHIgMjUsIDIwMTggYXQgMDQ6MTc6MjVQTSArMDMwMCwg TGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IE9uIFdlZG5lc2RheSwgMjUgQXByaWwgMjAxOCAx NToyMDowNCBFRVNUIFBoaWxpcHBlIENPUk5VIHdyb3RlOgo+ID4+IE9uIDA0LzI1LzIwMTggMTE6 MDEgQU0sIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+IE9uIFdlZG5lc2RheSwgMjUgQXBy aWwgMjAxOCAxMDo1MzoxMyBFRVNUIFBoaWxpcHBlIENvcm51IHdyb3RlOgo+ID4+Pj4gQWRkIG9w dGlvbmFsIHBvd2VyIHN1cHBsaWVzIHVzaW5nIHRoZSBkZXNjcmlwdGlvbiBmb3VuZCBpbgo+ID4+ Pj4gIlNpSTkwMjJBL1NpSTkwMjRBIEhETUkgVHJhbnNtaXR0ZXIgRGF0YSBTaGVldCAoQXVndXN0 IDIwMTYpIi4KPiA+Pj4+IAo+ID4+Pj4gVGhlcmUgaXMgYSBzaW5nbGUgMXYyIHN1cHBseSB2b2x0 YWdlIG5hbWVkIHZjYzEyIGZyb20gd2hpY2ggY3ZjYzEyCj4gPj4+PiAoZGlnaXRhbCBjb3JlKSBh bmQgYXZjYzEyIChUTURTIGFuYWxvZykgYXJlIGRlcml2ZWQgYmVjYXVzZSBhY2NvcmRpbmcKPiA+ Pj4+IHRvIHRoaXMgZGF0YSBzaGVldDoKPiA+Pj4+ICJjdmNjMTIgYW5kIGF2Y2MxMiBjYW4gYmUg ZGVyaXZlZCBmcm9tIHRoZSBzYW1lIHBvd2VyIHNvdXJjZSIKPiA+Pj4gCj4gPj4+IFNob3VsZG4n dCB0aGUgcG93ZXIgc3VwcGxpZXMgYmUgbWFuZGF0b3J5LCBhcyBleHBsYWluZWQgYnkgTWFyayBp bgo+ID4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwv MjAxOC1BcHJpbC8xNzI0MDAuaHRtbAo+ID4+PiA/Cj4gPj4gCj4gPj4gTGF1cmVudCwKPiA+PiBN YW55IHRoYW5rcyBMYXVyZW50IGZvciB5b3VyIGNvbW1lbnQsIEkgdW5kZXJzdG9vZCB0aGUgbWVy Z2Ugb2YgdGhlIHR3bwo+ID4+IDF2MiBwb3dlciBzdXBwbGllcyBidXQgbWlzc2VkIHRoZSAibWFu ZGF0b3J5IiBwYXJ0Li4uIG1heWJlIGJlY2F1c2UgdGhpcwo+ID4+IHBhdGNoICh3aXRoIG9wdGlv bmFsIHBvd2VyIHN1cHBsaWVzKSBhbHJlYWR5IGdvdCB0aGUgcmV2aWV3ZWQtYnkgZnJvbQo+ID4+ IFJvYiwgSSB0aG91Z2h0IHRoZSBkaXNjdXNzaW9uIHRocmVhZCB5b3UgcG9pbnRlZCBvdXQgd2Fz IGFwcGxpY2FibGUKPiA+PiAib25seSIgdG8gdG90YWxseSBuZXcgZHJpdmVyIGRvY3VtZW50YXRp b24uCj4gPj4gCj4gPj4gU28sIG9uIG15IHNpZGUsIGFzIGEgIm5ldyB1c2VyIiBvZiBzaWk5MDJ4 IElDLCBubyBwcm9ibGVtIHRvIHB1dCB0aGVzZQo+ID4+IHBvd2VyIHN1cHBsaWVzIGFzIG1hbmRh dG9yeSBpbnN0ZWFkIG9mIG9wdGlvbmFsIHByb3BlcnRpZXMgYnV0IEkgd291bGQKPiA+PiBsaWtl IHRvIGJlIHN1cmUgdGhpcyBpcyBhcHBsaWNhYmxlIHRvIGJvdGggb2xkIGFuZCBuZXcgYmluZGlu Z3MgZG9jIDogKQo+ID4gCj4gPiBXZSBvYnZpb3VzbHkgbmVlZCB0byByZXRhaW4gYmFja3dhcmQg Y29tcGF0aWJpbGl0eSwgc28gb24gdGhlIGRyaXZlciBzaWRlCj4gPiB5b3UgbmVlZCB0byB0cmVh dCB0aG9zZSBwb3dlciBzdXBwbGllcyBhcyBvcHRpb25hbC4gRnJvbSBhIERUIGJpbmRpbmdzCj4g PiBwb2ludCBvZiB2aWV3LCBob3dldmVyLCBJIHRoaW5rIHRoZXkgc2hvdWxkIGJlIG1hbmRhdG9y eSBmb3IgbmV3IERULgo+IAo+IFdlIGRvbid0IHJlYWxseSBoYXZlIGEgd2F5IHRvIGRlc2NyaWJl IHRoZXNlIDMgY29uZGl0aW9ucyAocmVxdWlyZWQgZm9yCj4gYWxsLCBvcHRpb25hbCBmb3IgYWxs LCBhbmQgcmVxdWlyZWQgZm9yIG5ldykuIFNvIGdlbmVyYWxseSB3ZSBtYWtlCj4gYWRkaXRpb25z IG9wdGlvbmFsLiBUaGUgZXhjZXB0aW9uIHNvbWV0aW1lcyBpcyBpZiB3ZSB1cGRhdGUgYWxsIHRo ZSBkdHMKPiBmaWxlcy4KCkNhbid0IHdlIGp1c3QgbWFrZSBpdCBtYW5kYXRvcnkgaW4gdGhlIGJp bmRpbmdzLCBhcyBsb25nIGFzIHdlIHRyZWF0IGl0IGFzIApvcHRpb25hbCBpbiBkcml2ZXJzID8K Cj4gPj4gUm9iLAo+ID4+IGNvdWxkIHlvdSBwbGVhc2UgY29uZmlybSB0aGVzZSBwb3dlciBzdXBw bHkgcHJvcGVydGllcyBzaG91bGQgYmUKPiA+PiAibWFuZGF0b3J5Ij8gaWYgeWVzLCBzaG91bGQg d2UgdGhlbiBtb2RpZnkgb3RoZXIgb3B0aW9uYWwgcHJvcGVydGllcyBsaWtlCj4gPj4gdGhlIHJl c2V0LWdwaW9zIHRvbyBpbiB0aGUgZnV0dXJlPwo+ID4gCj4gPiBUaGUgR1BJT3MgcHJvcGVydGll cyBhcmUgZGlmZmVyZW50IGluIG15IG9waW5pb24sIGFzIHRoZXJlJ3Mgbm8KPiA+IHJlcXVpcmVt ZW50IHRvIGNvbm5lY3QgZm9yIGluc3RhbmNlIHRoZSByZXNldCBwaW4gdG8gYSBHUElPIGNvbnRy b2xsYWJsZQo+ID4gYnkgdGhlIFNvQy4gVGhlIHBpbiBjb3VsZCBiZSBoYXJkd2lyZWQgdG8gVkND LCBvciBjb25uZWN0ZWQgdG8gYSBzeXN0ZW0KPiA+IHJlc2V0IHRoYXQgaXMgYXV0b21hdGljYWxs eSBtYW5hZ2VkIHdpdGhvdXQgU29DIGludGVydmVudGlvbi4gVGhlIHBvd2VyCj4gPiBzdXBwbGll cywgaG93ZXZlciwgYXJlIG1hbmRhdG9yeSwgaW4gdGhlIHNlbnNlIHRoYXQgdGhlIGNoaXAgd2ls bCBub3Qgd29yawo+ID4gaWYgeW91IGxlYXZlIHRoZSBwb3dlciBzdXBwbGllcyB1bmNvbm5lY3Rl ZC4KPiAKPiBEVCBvbmx5IG5lZWRzIHRvIGRlc2NyaWJlIHdoYXQgbWF0dGVycyB0byBzL3cuIElm IGEgcmVndWxhdG9yIGlzCj4gZml4ZWQgYW5kIHlvdSBkb24ndCBuZWVkIHRvIGtub3cgaXRzIHZv bHRhZ2UgKG9yIG90aGVyIHJlYWQtb25seQo+IHBhcmFtZXRlcnMpLCB0aGVuIHRoZXJlJ3Mgbm90 IG11Y2ggcG9pbnQgaW4gcHV0dGluZyBpdCBpbiBEVC4KPiAKPiBJJ2QgcHJvYmFibHkgYmFzZSB0 aGlzIG1vcmUgYXQgYSBwbGF0Zm9ybSBsZXZlbCBhbmQgeW91IGVpdGhlciB1c2UKPiByZWd1bGF0 b3IgYmluZGluZyBvciB5b3UgZG9uJ3QuIEl0J3MgcGVyZmVjdGx5IHZhbGlkIHRoYXQgeW91IHdh bnQgdG8gZG8KPiB0aGluZ3MgbGlrZSByZWd1bGF0b3Igc2V0dXAsIHBpbiBjdHJsIGFuZCBtdXhp bmcgc2V0dXAsIGV0Yy4gYWxsIGluCj4gZmlybXdhcmUgYW5kIHRoZSBPUyBkb2Vzbid0IHRvdWNo IGFueSBvZiB0aGF0Lgo+IAo+IFRoYXQncyBhbGwgYSBiaWcgY2FuIG9mIHdvcm1zIHdoaWNoIHdl IHNob3VsZG4ndCBzb2x2ZSBvbiB0aGlzIDIgbGluZQo+IGNoYW5nZS4gSSB0aGluayB0aGlzIGNo YW5nZSBpcyBmaW5lIGFzLWlzLCBzbzoKPiAKPiBSZXZpZXdlZC1ieTogUm9iIEhlcnJpbmcgPHJv YmhAa2VybmVsLm9yZz4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbeDYWE5 (ORCPT ); Wed, 25 Apr 2018 18:04:57 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:48900 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbeDYWEy (ORCPT ); Wed, 25 Apr 2018 18:04:54 -0400 From: Laurent Pinchart To: Rob Herring Cc: Philippe CORNU , Archit Taneja , Andrzej Hajda , David Airlie , Mark Rutland , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE , Benjamin Gaignard , Alexandre TORGUE Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Thu, 26 Apr 2018 01:05:06 +0300 Message-ID: <3518575.OAoTTXDygq@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180425171123.xhyoay3nu463btoq@rob-hp-laptop> References: <20180425075314.19137-1-philippe.cornu@st.com> <1559016.ZjzeSVB84W@avalon> <20180425171123.xhyoay3nu463btoq@rob-hp-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Wednesday, 25 April 2018 20:11:23 EEST Rob Herring wrote: > On Wed, Apr 25, 2018 at 04:17:25PM +0300, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 15:20:04 EEST Philippe CORNU wrote: > >> On 04/25/2018 11:01 AM, Laurent Pinchart wrote: > >>> On Wednesday, 25 April 2018 10:53:13 EEST Philippe Cornu wrote: > >>>> Add optional power supplies using the description found in > >>>> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >>>> > >>>> There is a single 1v2 supply voltage named vcc12 from which cvcc12 > >>>> (digital core) and avcc12 (TMDS analog) are derived because according > >>>> to this data sheet: > >>>> "cvcc12 and avcc12 can be derived from the same power source" > >>> > >>> Shouldn't the power supplies be mandatory, as explained by Mark in > >>> https://lists.freedesktop.org/archives/dri-devel/2018-April/172400.html > >>> ? > >> > >> Laurent, > >> Many thanks Laurent for your comment, I understood the merge of the two > >> 1v2 power supplies but missed the "mandatory" part... maybe because this > >> patch (with optional power supplies) already got the reviewed-by from > >> Rob, I thought the discussion thread you pointed out was applicable > >> "only" to totally new driver documentation. > >> > >> So, on my side, as a "new user" of sii902x IC, no problem to put these > >> power supplies as mandatory instead of optional properties but I would > >> like to be sure this is applicable to both old and new bindings doc : ) > > > > We obviously need to retain backward compatibility, so on the driver side > > you need to treat those power supplies as optional. From a DT bindings > > point of view, however, I think they should be mandatory for new DT. > > We don't really have a way to describe these 3 conditions (required for > all, optional for all, and required for new). So generally we make > additions optional. The exception sometimes is if we update all the dts > files. Can't we just make it mandatory in the bindings, as long as we treat it as optional in drivers ? > >> Rob, > >> could you please confirm these power supply properties should be > >> "mandatory"? if yes, should we then modify other optional properties like > >> the reset-gpios too in the future? > > > > The GPIOs properties are different in my opinion, as there's no > > requirement to connect for instance the reset pin to a GPIO controllable > > by the SoC. The pin could be hardwired to VCC, or connected to a system > > reset that is automatically managed without SoC intervention. The power > > supplies, however, are mandatory, in the sense that the chip will not work > > if you leave the power supplies unconnected. > > DT only needs to describe what matters to s/w. If a regulator is > fixed and you don't need to know its voltage (or other read-only > parameters), then there's not much point in putting it in DT. > > I'd probably base this more at a platform level and you either use > regulator binding or you don't. It's perfectly valid that you want to do > things like regulator setup, pin ctrl and muxing setup, etc. all in > firmware and the OS doesn't touch any of that. > > That's all a big can of worms which we shouldn't solve on this 2 line > change. I think this change is fine as-is, so: > > Reviewed-by: Rob Herring -- Regards, Laurent Pinchart