From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A86C282DD for ; Fri, 10 Jan 2020 19:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B55A2072A for ; Fri, 10 Jan 2020 19:00:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jjcs0Qp5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728638AbgAJTAV (ORCPT ); Fri, 10 Jan 2020 14:00:21 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:51883 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728650AbgAJTAV (ORCPT ); Fri, 10 Jan 2020 14:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578682819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZ3MJlwKsmTahhEKZ7liwmdaP72hxHg0nFRVSSgd63k=; b=Jjcs0Qp5ZzEmoD/tSTHSAnd/k656FWep+sDVev1lFrE1EzmxGpPVsg7Eh6PIdhJUyRe7gF yA4j8Urpoaczuk3Eo4rRhGysvhVd5wDeeGudJNdIRbJQt7Nol0O1JN2Aq856B9tSMSMmO8 Edy64Bw/Ffb04V40Rjk8KwSQ78OqCHA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-JSww2fMSNV2NKcoejt9luw-1; Fri, 10 Jan 2020 14:00:15 -0500 X-MC-Unique: JSww2fMSNV2NKcoejt9luw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4E2B8048F1; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878E35E241; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from zmail24.collab.prod.int.phx2.redhat.com (zmail24.collab.prod.int.phx2.redhat.com [10.5.83.30]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 301E581C72; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Date: Fri, 10 Jan 2020 14:00:10 -0500 (EST) From: Dave Anderson To: James Morse Cc: Bhupesh Sharma , linux-kernel@vger.kernel.org, bhupesh linux , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kexec@lists.infradead.org, Mark Rutland , Will Deacon , Steve Capper , Catalin Marinas , Ard Biesheuvel , Kazuhito Hagio Message-ID: <351975548.1986001.1578682810951.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1575057559-25496-1-git-send-email-bhsharma@redhat.com> <1575057559-25496-3-git-send-email-bhsharma@redhat.com> <63d6e63c-7218-d2dd-8767-4464be83603f@arm.com> Subject: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.10.120.164, 10.4.195.27] Thread-Topic: arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo Thread-Index: ic50YQVuXt31PDeSAHGv7IV2UM9mpA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org ----- Original Message ----- > Hi Bhupesh, >=20 > On 25/12/2019 19:01, Bhupesh Sharma wrote: > > On 12/12/2019 04:02 PM, James Morse wrote: > >> On 29/11/2019 19:59, Bhupesh Sharma wrote: > >>> vabits_actual variable on arm64 indicates the actual VA space size, > >>> and allows a single binary to support both 48-bit and 52-bit VA > >>> spaces. > >>> > >>> If the ARMv8.2-LVA optional feature is present, and we are running > >>> with a 64KB page size; then it is possible to use 52-bits of address > >>> space for both userspace and kernel addresses. However, any kernel > >>> binary that supports 52-bit must also be able to fall back to 48-bit > >>> at early boot time if the hardware feature is not present. > >>> > >>> Since TCR_EL1.T1SZ indicates the size offset of the memory region > >>> addressed by TTBR1_EL1 (and hence can be used for determining the > >>> vabits_actual value) it makes more sense to export the same in > >>> vmcoreinfo rather than vabits_actual variable, as the name of the > >>> variable can change in future kernel versions, but the architectural > >>> constructs like TCR_EL1.T1SZ can be used better to indicate intended > >>> specific fields to user-space. > >>> > >>> User-space utilities like makedumpfile and crash-utility, need to > >>> read/write this value from/to vmcoreinfo > >> > >> (write?) > >=20 > > Yes, also write so that the vmcoreinfo from an (crashing) arm64 system = can > > be used for > > analysis of the root-cause of panic/crash on say an x86_64 host using > > utilities like > > crash-utility/gdb. >=20 > I read this as as "User-space [...] needs to write to vmcoreinfo". >=20 >=20 > >>> for determining if a virtual address lies in the linear map range. > >> > >> I think this is a fragile example. The debugger shouldn't need to know > >> this. > >=20 > > Well that the current user-space utility design, so I am not sure we ca= n > > tweak that too much. > >=20 > >>> The user-space computation for determining whether an address lies in > >>> the linear map range is the same as we have in kernel-space: > >>> > >>> =C2=A0=C2=A0 #define __is_lm_address(addr)=C2=A0=C2=A0=C2=A0 (!(((u64= )addr) & BIT(vabits_actual - > >>> =C2=A0=C2=A0 1))) > >> > >> This was changed with 14c127c957c1 ("arm64: mm: Flip kernel VA space")= . If > >> user-space > >> tools rely on 'knowing' the kernel memory layout, they must have to > >> constantly be fixed > >> and updated. This is a poor argument for adding this to something that > >> ends up as ABI. > >=20 > > See above. The user-space has to rely on some ABI/guaranteed > > hardware-symbols which can be > > used for 'determining' the kernel memory layout. >=20 > I disagree. Everything and anything in the kernel will change. The ABI ru= les apply to > stuff exposed via syscalls and kernel filesystems. It does not apply to k= ernel internals, > like the memory layout we used yesterday. 14c127c957c1 is a case in point= . >=20 > A debugger trying to rely on this sort of thing would have to play catchu= p whenever it > changes. Exactly. That's the whole point. The crash utility and makedumpfile are not in the same league as other user= -space tools. They have always had to "play catchup" precisely because they depend upon k= ernel internals, which constantly change. Dave=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB917C282DD for ; Fri, 10 Jan 2020 23:17:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C9052072E for ; Fri, 10 Jan 2020 23:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NbY9FJVK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C9052072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47vf565nqfzDqjN for ; Sat, 11 Jan 2020 10:16:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=anderson@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NbY9FJVK; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47vdn82P6YzDq75 for ; Sat, 11 Jan 2020 10:03:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578697382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZ3MJlwKsmTahhEKZ7liwmdaP72hxHg0nFRVSSgd63k=; b=NbY9FJVKiYp8SE+0/5Y1OnVHcvNPJ5EaEoMhrACqb4CU2bB6pzrISMFls3NXtGYGgop6N0 hJqiCJzHbJgSVIRxUBW2UE5SVnRbntXsMicFgFVy77aDeYuNCF68+L4u0XTrPoXkJlbtOR inwq5F9cWbFDcjkn0wzh0oirmMd7FPs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-JSww2fMSNV2NKcoejt9luw-1; Fri, 10 Jan 2020 14:00:15 -0500 X-MC-Unique: JSww2fMSNV2NKcoejt9luw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4E2B8048F1; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878E35E241; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from zmail24.collab.prod.int.phx2.redhat.com (zmail24.collab.prod.int.phx2.redhat.com [10.5.83.30]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 301E581C72; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Date: Fri, 10 Jan 2020 14:00:10 -0500 (EST) From: Dave Anderson To: James Morse Message-ID: <351975548.1986001.1578682810951.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1575057559-25496-1-git-send-email-bhsharma@redhat.com> <1575057559-25496-3-git-send-email-bhsharma@redhat.com> <63d6e63c-7218-d2dd-8767-4464be83603f@arm.com> Subject: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.10.120.164, 10.4.195.27] Thread-Topic: arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo Thread-Index: ic50YQVuXt31PDeSAHGv7IV2UM9mpA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mailman-Approved-At: Sat, 11 Jan 2020 10:15:14 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , linux-doc@vger.kernel.org, Will Deacon , Bhupesh Sharma , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Kazuhito Hagio , Catalin Marinas , bhupesh linux , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Steve Capper Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" ----- Original Message ----- > Hi Bhupesh, >=20 > On 25/12/2019 19:01, Bhupesh Sharma wrote: > > On 12/12/2019 04:02 PM, James Morse wrote: > >> On 29/11/2019 19:59, Bhupesh Sharma wrote: > >>> vabits_actual variable on arm64 indicates the actual VA space size, > >>> and allows a single binary to support both 48-bit and 52-bit VA > >>> spaces. > >>> > >>> If the ARMv8.2-LVA optional feature is present, and we are running > >>> with a 64KB page size; then it is possible to use 52-bits of address > >>> space for both userspace and kernel addresses. However, any kernel > >>> binary that supports 52-bit must also be able to fall back to 48-bit > >>> at early boot time if the hardware feature is not present. > >>> > >>> Since TCR_EL1.T1SZ indicates the size offset of the memory region > >>> addressed by TTBR1_EL1 (and hence can be used for determining the > >>> vabits_actual value) it makes more sense to export the same in > >>> vmcoreinfo rather than vabits_actual variable, as the name of the > >>> variable can change in future kernel versions, but the architectural > >>> constructs like TCR_EL1.T1SZ can be used better to indicate intended > >>> specific fields to user-space. > >>> > >>> User-space utilities like makedumpfile and crash-utility, need to > >>> read/write this value from/to vmcoreinfo > >> > >> (write?) > >=20 > > Yes, also write so that the vmcoreinfo from an (crashing) arm64 system = can > > be used for > > analysis of the root-cause of panic/crash on say an x86_64 host using > > utilities like > > crash-utility/gdb. >=20 > I read this as as "User-space [...] needs to write to vmcoreinfo". >=20 >=20 > >>> for determining if a virtual address lies in the linear map range. > >> > >> I think this is a fragile example. The debugger shouldn't need to know > >> this. > >=20 > > Well that the current user-space utility design, so I am not sure we ca= n > > tweak that too much. > >=20 > >>> The user-space computation for determining whether an address lies in > >>> the linear map range is the same as we have in kernel-space: > >>> > >>> =C2=A0=C2=A0 #define __is_lm_address(addr)=C2=A0=C2=A0=C2=A0 (!(((u64= )addr) & BIT(vabits_actual - > >>> =C2=A0=C2=A0 1))) > >> > >> This was changed with 14c127c957c1 ("arm64: mm: Flip kernel VA space")= . If > >> user-space > >> tools rely on 'knowing' the kernel memory layout, they must have to > >> constantly be fixed > >> and updated. This is a poor argument for adding this to something that > >> ends up as ABI. > >=20 > > See above. The user-space has to rely on some ABI/guaranteed > > hardware-symbols which can be > > used for 'determining' the kernel memory layout. >=20 > I disagree. Everything and anything in the kernel will change. The ABI ru= les apply to > stuff exposed via syscalls and kernel filesystems. It does not apply to k= ernel internals, > like the memory layout we used yesterday. 14c127c957c1 is a case in point= . >=20 > A debugger trying to rely on this sort of thing would have to play catchu= p whenever it > changes. Exactly. That's the whole point. The crash utility and makedumpfile are not in the same league as other user= -space tools. They have always had to "play catchup" precisely because they depend upon k= ernel internals, which constantly change. Dave=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0BC6C282DD for ; Fri, 10 Jan 2020 19:02:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 703D8205F4 for ; Fri, 10 Jan 2020 19:02:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KeFhA6hp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A0r0nVS5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 703D8205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References: In-Reply-To:Message-ID:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GtKIqEGMFFGPJnjP3Ot9dAvJwSuCDkr69gEhPpO0mPY=; b=KeFhA6hpfQtMPk u6tH6/6BiktRfT8g/C6mK3fBU7rHCZDM4e7M94Ho3lLXIs05ClnDLQEOr15Nt6720RwNIVtU/vhIK M4jSc3/ATLteqTNwsl14dXpreCJgltlg9vdFy4LMi1I0uIt+OJQQ3cfoBhUaDY3GTIvblzmkrPdKi AW7evg8+OFqDMUY8Uxyp1XUawDFjoAZQAi3iRd9mKIKOumsIVCOLCFmpC8CkqMpNYam66rj+EWETC ZhJ8vFhQehCcjjBDhrbeJABAnVO0klp8Ghlx3TBT7c3wX/2k+ONF14mpnzMCZwbP8lew85wbDDusm L+3YRkFXiVu1KhUMQP+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipzY7-0005sN-NS; Fri, 10 Jan 2020 19:02:23 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipzY3-0005qr-Qe for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 19:02:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578682936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZ3MJlwKsmTahhEKZ7liwmdaP72hxHg0nFRVSSgd63k=; b=A0r0nVS5cUH8/ekZgXdFf+RhkD81CbziZqyfF8mDU/5nZWrWms3rK6Xh+XstQfmBqFGdU7 I0O5a0Yt9IaEkhaRtJuBfjtbwFEuZgy9N+O7RhK8kXfriCzvxr+zsi++pNbLCzlLZMWSb0 qG/lLNxAfXmZIA7xKb77YWB/FqOIiVU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-JSww2fMSNV2NKcoejt9luw-1; Fri, 10 Jan 2020 14:00:15 -0500 X-MC-Unique: JSww2fMSNV2NKcoejt9luw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4E2B8048F1; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878E35E241; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Received: from zmail24.collab.prod.int.phx2.redhat.com (zmail24.collab.prod.int.phx2.redhat.com [10.5.83.30]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 301E581C72; Fri, 10 Jan 2020 19:00:11 +0000 (UTC) Date: Fri, 10 Jan 2020 14:00:10 -0500 (EST) From: Dave Anderson To: James Morse Message-ID: <351975548.1986001.1578682810951.JavaMail.zimbra@redhat.com> In-Reply-To: References: <1575057559-25496-1-git-send-email-bhsharma@redhat.com> <1575057559-25496-3-git-send-email-bhsharma@redhat.com> <63d6e63c-7218-d2dd-8767-4464be83603f@arm.com> Subject: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo MIME-Version: 1.0 X-Originating-IP: [10.10.120.164, 10.4.195.27] Thread-Topic: arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo Thread-Index: ic50YQVuXt31PDeSAHGv7IV2UM9mpA== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_110219_986675_2F9311EF X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ard Biesheuvel , linux-doc@vger.kernel.org, Will Deacon , Bhupesh Sharma , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Kazuhito Hagio , Catalin Marinas , bhupesh linux , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Steve Capper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgotLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tCj4gSGkgQmh1cGVzaCwKPiAKPiBPbiAyNS8x Mi8yMDE5IDE5OjAxLCBCaHVwZXNoIFNoYXJtYSB3cm90ZToKPiA+IE9uIDEyLzEyLzIwMTkgMDQ6 MDIgUE0sIEphbWVzIE1vcnNlIHdyb3RlOgo+ID4+IE9uIDI5LzExLzIwMTkgMTk6NTksIEJodXBl c2ggU2hhcm1hIHdyb3RlOgo+ID4+PiB2YWJpdHNfYWN0dWFsIHZhcmlhYmxlIG9uIGFybTY0IGlu ZGljYXRlcyB0aGUgYWN0dWFsIFZBIHNwYWNlIHNpemUsCj4gPj4+IGFuZCBhbGxvd3MgYSBzaW5n bGUgYmluYXJ5IHRvIHN1cHBvcnQgYm90aCA0OC1iaXQgYW5kIDUyLWJpdCBWQQo+ID4+PiBzcGFj ZXMuCj4gPj4+Cj4gPj4+IElmIHRoZSBBUk12OC4yLUxWQSBvcHRpb25hbCBmZWF0dXJlIGlzIHBy ZXNlbnQsIGFuZCB3ZSBhcmUgcnVubmluZwo+ID4+PiB3aXRoIGEgNjRLQiBwYWdlIHNpemU7IHRo ZW4gaXQgaXMgcG9zc2libGUgdG8gdXNlIDUyLWJpdHMgb2YgYWRkcmVzcwo+ID4+PiBzcGFjZSBm b3IgYm90aCB1c2Vyc3BhY2UgYW5kIGtlcm5lbCBhZGRyZXNzZXMuIEhvd2V2ZXIsIGFueSBrZXJu ZWwKPiA+Pj4gYmluYXJ5IHRoYXQgc3VwcG9ydHMgNTItYml0IG11c3QgYWxzbyBiZSBhYmxlIHRv IGZhbGwgYmFjayB0byA0OC1iaXQKPiA+Pj4gYXQgZWFybHkgYm9vdCB0aW1lIGlmIHRoZSBoYXJk d2FyZSBmZWF0dXJlIGlzIG5vdCBwcmVzZW50Lgo+ID4+Pgo+ID4+PiBTaW5jZSBUQ1JfRUwxLlQx U1ogaW5kaWNhdGVzIHRoZSBzaXplIG9mZnNldCBvZiB0aGUgbWVtb3J5IHJlZ2lvbgo+ID4+PiBh ZGRyZXNzZWQgYnkgVFRCUjFfRUwxIChhbmQgaGVuY2UgY2FuIGJlIHVzZWQgZm9yIGRldGVybWlu aW5nIHRoZQo+ID4+PiB2YWJpdHNfYWN0dWFsIHZhbHVlKSBpdCBtYWtlcyBtb3JlIHNlbnNlIHRv IGV4cG9ydCB0aGUgc2FtZSBpbgo+ID4+PiB2bWNvcmVpbmZvIHJhdGhlciB0aGFuIHZhYml0c19h Y3R1YWwgdmFyaWFibGUsIGFzIHRoZSBuYW1lIG9mIHRoZQo+ID4+PiB2YXJpYWJsZSBjYW4gY2hh bmdlIGluIGZ1dHVyZSBrZXJuZWwgdmVyc2lvbnMsIGJ1dCB0aGUgYXJjaGl0ZWN0dXJhbAo+ID4+ PiBjb25zdHJ1Y3RzIGxpa2UgVENSX0VMMS5UMVNaIGNhbiBiZSB1c2VkIGJldHRlciB0byBpbmRp Y2F0ZSBpbnRlbmRlZAo+ID4+PiBzcGVjaWZpYyBmaWVsZHMgdG8gdXNlci1zcGFjZS4KPiA+Pj4K PiA+Pj4gVXNlci1zcGFjZSB1dGlsaXRpZXMgbGlrZSBtYWtlZHVtcGZpbGUgYW5kIGNyYXNoLXV0 aWxpdHksIG5lZWQgdG8KPiA+Pj4gcmVhZC93cml0ZSB0aGlzIHZhbHVlIGZyb20vdG8gdm1jb3Jl aW5mbwo+ID4+Cj4gPj4gKHdyaXRlPykKPiA+IAo+ID4gWWVzLCBhbHNvIHdyaXRlIHNvIHRoYXQg dGhlIHZtY29yZWluZm8gZnJvbSBhbiAoY3Jhc2hpbmcpIGFybTY0IHN5c3RlbSBjYW4KPiA+IGJl IHVzZWQgZm9yCj4gPiBhbmFseXNpcyBvZiB0aGUgcm9vdC1jYXVzZSBvZiBwYW5pYy9jcmFzaCBv biBzYXkgYW4geDg2XzY0IGhvc3QgdXNpbmcKPiA+IHV0aWxpdGllcyBsaWtlCj4gPiBjcmFzaC11 dGlsaXR5L2dkYi4KPiAKPiBJIHJlYWQgdGhpcyBhcyBhcyAiVXNlci1zcGFjZSBbLi4uXSBuZWVk cyB0byB3cml0ZSB0byB2bWNvcmVpbmZvIi4KPiAKPiAKPiA+Pj4gZm9yIGRldGVybWluaW5nIGlm IGEgdmlydHVhbCBhZGRyZXNzIGxpZXMgaW4gdGhlIGxpbmVhciBtYXAgcmFuZ2UuCj4gPj4KPiA+ PiBJIHRoaW5rIHRoaXMgaXMgYSBmcmFnaWxlIGV4YW1wbGUuIFRoZSBkZWJ1Z2dlciBzaG91bGRu J3QgbmVlZCB0byBrbm93Cj4gPj4gdGhpcy4KPiA+IAo+ID4gV2VsbCB0aGF0IHRoZSBjdXJyZW50 IHVzZXItc3BhY2UgdXRpbGl0eSBkZXNpZ24sIHNvIEkgYW0gbm90IHN1cmUgd2UgY2FuCj4gPiB0 d2VhayB0aGF0IHRvbyBtdWNoLgo+ID4gCj4gPj4+IFRoZSB1c2VyLXNwYWNlIGNvbXB1dGF0aW9u IGZvciBkZXRlcm1pbmluZyB3aGV0aGVyIGFuIGFkZHJlc3MgbGllcyBpbgo+ID4+PiB0aGUgbGlu ZWFyIG1hcCByYW5nZSBpcyB0aGUgc2FtZSBhcyB3ZSBoYXZlIGluIGtlcm5lbC1zcGFjZToKPiA+ Pj4KPiA+Pj4gwqDCoCAjZGVmaW5lIF9faXNfbG1fYWRkcmVzcyhhZGRyKcKgwqDCoCAoISgoKHU2 NClhZGRyKSAmIEJJVCh2YWJpdHNfYWN0dWFsIC0KPiA+Pj4gwqDCoCAxKSkpCj4gPj4KPiA+PiBU aGlzIHdhcyBjaGFuZ2VkIHdpdGggMTRjMTI3Yzk1N2MxICgiYXJtNjQ6IG1tOiBGbGlwIGtlcm5l bCBWQSBzcGFjZSIpLiBJZgo+ID4+IHVzZXItc3BhY2UKPiA+PiB0b29scyByZWx5IG9uICdrbm93 aW5nJyB0aGUga2VybmVsIG1lbW9yeSBsYXlvdXQsIHRoZXkgbXVzdCBoYXZlIHRvCj4gPj4gY29u c3RhbnRseSBiZSBmaXhlZAo+ID4+IGFuZCB1cGRhdGVkLiBUaGlzIGlzIGEgcG9vciBhcmd1bWVu dCBmb3IgYWRkaW5nIHRoaXMgdG8gc29tZXRoaW5nIHRoYXQKPiA+PiBlbmRzIHVwIGFzIEFCSS4K PiA+IAo+ID4gU2VlIGFib3ZlLiBUaGUgdXNlci1zcGFjZSBoYXMgdG8gcmVseSBvbiBzb21lIEFC SS9ndWFyYW50ZWVkCj4gPiBoYXJkd2FyZS1zeW1ib2xzIHdoaWNoIGNhbiBiZQo+ID4gdXNlZCBm b3IgJ2RldGVybWluaW5nJyB0aGUga2VybmVsIG1lbW9yeSBsYXlvdXQuCj4gCj4gSSBkaXNhZ3Jl ZS4gRXZlcnl0aGluZyBhbmQgYW55dGhpbmcgaW4gdGhlIGtlcm5lbCB3aWxsIGNoYW5nZS4gVGhl IEFCSSBydWxlcyBhcHBseSB0bwo+IHN0dWZmIGV4cG9zZWQgdmlhIHN5c2NhbGxzIGFuZCBrZXJu ZWwgZmlsZXN5c3RlbXMuIEl0IGRvZXMgbm90IGFwcGx5IHRvIGtlcm5lbCBpbnRlcm5hbHMsCj4g bGlrZSB0aGUgbWVtb3J5IGxheW91dCB3ZSB1c2VkIHllc3RlcmRheS4gMTRjMTI3Yzk1N2MxIGlz IGEgY2FzZSBpbiBwb2ludC4KPiAKPiBBIGRlYnVnZ2VyIHRyeWluZyB0byByZWx5IG9uIHRoaXMg c29ydCBvZiB0aGluZyB3b3VsZCBoYXZlIHRvIHBsYXkgY2F0Y2h1cCB3aGVuZXZlciBpdAo+IGNo YW5nZXMuCgpFeGFjdGx5LiAgVGhhdCdzIHRoZSB3aG9sZSBwb2ludC4KClRoZSBjcmFzaCB1dGls aXR5IGFuZCBtYWtlZHVtcGZpbGUgYXJlIG5vdCBpbiB0aGUgc2FtZSBsZWFndWUgYXMgb3RoZXIg dXNlci1zcGFjZSB0b29scy4KVGhleSBoYXZlIGFsd2F5cyBoYWQgdG8gInBsYXkgY2F0Y2h1cCIg cHJlY2lzZWx5IGJlY2F1c2UgdGhleSBkZXBlbmQgdXBvbiBrZXJuZWwgaW50ZXJuYWxzLAp3aGlj aCBjb25zdGFudGx5IGNoYW5nZS4KCkRhdmUgCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=