All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: random1@o-o.yi.org, linux-scsi@vger.kernel.org
Subject: Re: aic7xxx dump_card_state not reentrant?
Date: Sat, 17 Aug 2002 13:54:24 -0600	[thread overview]
Message-ID: <3520000.1029614064@aslan.scsiguy.com> (raw)
In-Reply-To: <uwuqp79nn.fsf@o-o.yi.org>

> I'm trying to get suspend and resume working for a 2.4 kernel with
> scsi devices, and I'm running into trouble saving and restoring the
> card state.  One thing that I've discovered in the process of looking
> into this is that the ahc_dump_card_state routine is called at both
> process level and interrupt level.  If I read it correctly, it alters
> the card state while dumping the list of SCBs.  If a sequencer
> interrupt occurs in the meantime, bad stuff happens.  Doesn't it?
> Well, I'm seeing panics in which ahc_dump_card_state is running in
> both contexts "simultaneously."

You must hold the ahc_lock() before calling most routines in the driver.
It is tha ahc_lock() that protects against reentrancy.

--
Justin


  reply	other threads:[~2002-08-17 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-17 16:05 aic7xxx dump_card_state not reentrant? random1
2002-08-17 19:54 ` Justin T. Gibbs [this message]
2002-08-17 23:14   ` sym53c8xx message d sent on bad reselection Daryl Zero
2002-08-17 23:42     ` Daryl Zero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3520000.1029614064@aslan.scsiguy.com \
    --to=gibbs@scsiguy.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=random1@o-o.yi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.