Re: [PATCH] libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions

From: Pankaj Gupta <pagupta@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [PATCH] libnvdimm/region: Update is_nvdimm_sync check to handle volatile regions
Date: Tue, 24 Sep 2019 07:52:58 -0400 (EDT)	[thread overview]
Message-ID: <35214623.2704138.1569325978098.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190924114327.14700-1-aneesh.kumar@linux.ibm.com>


> 
> We should consider volatile regions synchronous so that we are resilient to
> OS crashes. This is needed when we have hypervisor like KVM exporting a
> ramdisk
> as pmem dimms.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
>  drivers/nvdimm/region_devs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
> index ab91890f2486..ef423ba1a711 100644
> --- a/drivers/nvdimm/region_devs.c
> +++ b/drivers/nvdimm/region_devs.c
> @@ -1168,6 +1168,9 @@ EXPORT_SYMBOL_GPL(nvdimm_has_cache);
>  
>  bool is_nvdimm_sync(struct nd_region *nd_region)
>  {
> +	if (is_nd_volatile(&nd_region->dev))
> +		return true;
> +
>  	return is_nd_pmem(&nd_region->dev) &&
>  		!test_bit(ND_REGION_ASYNC, &nd_region->flags);
>  }
> --
> 2.21.0

Reviewed-by: Pankaj Gupta <pagupta@redhat.com>

> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm