From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD57C433F5 for ; Thu, 7 Oct 2021 20:33:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF6A360F9D for ; Thu, 7 Oct 2021 20:33:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF6A360F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89258831B0; Thu, 7 Oct 2021 22:33:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mUyqQVpY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAE2D83531; Thu, 7 Oct 2021 22:33:39 +0200 (CEST) Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92B1C81918 for ; Thu, 7 Oct 2021 22:33:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-oo1-xc34.google.com with SMTP id s4-20020a4aad44000000b002b6aa5b6999so725000oon.2 for ; Thu, 07 Oct 2021 13:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SgUE9zo0Lmyz4zq4mLcyLzz0IVM7X9AV2ylWEQ42Cdw=; b=mUyqQVpYs3jFFs42Qh2kgDDLf3t9itRgF7pfHbZGpWnWwCIibnwlzY0ZQ87mIG3BOI PWIdj9AJPVstfzoUyNg0zLjJXoLtNVTT/4QxM00x8UMKq1of9DV6FH1h480erryP5dI2 JZo374eo3hLUuu6y6nuUwquxPpwtfjZdrLgA0qKPA/r7VRqKDlIKBG4bUHijO7jhn7Nd ZDC4+Mxn4n5AZaQiyF5MEaxPftfxYdqWE9FBkaxoU+Hgp8cmGPt6yYOjKkedSIPkWRSR zqriuqzJLgpARHQUKpp7rdwxvlwCNCXgg2AmzgfkcRHFg2axUcIyD4ISQI6rylA/RrMC SymQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SgUE9zo0Lmyz4zq4mLcyLzz0IVM7X9AV2ylWEQ42Cdw=; b=I+yR/Pg86Gi0IpIdjBZwxOm8uqI43Lc2X0naHe/1gfxUM7/7nnmNgPZD9NPY2S5dOs 4776p0EfGV/xNf3y0Cpu7GZB2rXnVOYqjfR+d3ofgnHB6tF2v+zBOHzWxwdiGBij43uU AjliHkX/Xp3G6jbYSQc9RC+IwbUlYc+MaqrTMFh/Hx4ceG67LwfCJUZgKp1o8ODE1fGi C1VxTOPSJmroQ3PSKaR9MANRPBRJzjoE3MN32NXSIJ2cwIhL+f0onhJix89zv8amlx+i x4/TY5l53OAMOJjcog85pkFexJE+typDqiM30diqXMq9O0sLru5a1tzpUesD7WLKWlxG Np0A== X-Gm-Message-State: AOAM532q5U7dggY9a5aAs59IWBkqyApsGodQRzmZdbAGFWrEZ7boTHSE HU9DgG2OKnfg6THZVRgz8+s= X-Google-Smtp-Source: ABdhPJwe/eEdQcL9C/fzJNLa/8byGj/uD+7II0HLXVgQQCH49WOxLzvdM1X74NztmVmMiix/9tu5Bw== X-Received: by 2002:a4a:2a51:: with SMTP id x17mr4954382oox.21.1633638814028; Thu, 07 Oct 2021 13:33:34 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id e12sm97062otq.4.2021.10.07.13.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 13:33:33 -0700 (PDT) Subject: Re: [PATCH v5 02/29] kconfig: Add tools support to CONFIG_IS_ENABLED() To: Tom Rini Cc: Simon Glass , U-Boot Mailing List , Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Masahiro Yamada References: <20210926014342.127913-3-sjg@chromium.org> <20211007002647.GA11424@bill-the-cat> <20211007025226.GQ31748@bill-the-cat> <20211007134209.GS31748@bill-the-cat> <20211007183045.GV31748@bill-the-cat> <5cb30240-b726-72be-fa68-05ce174218a3@gmail.com> <20211007193943.GW31748@bill-the-cat> From: "Alex G." Message-ID: <35223dc3-4af4-f70d-00d0-14495426be3f@gmail.com> Date: Thu, 7 Oct 2021 15:33:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211007193943.GW31748@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/7/21 2:39 PM, Tom Rini wrote: > On Thu, Oct 07, 2021 at 02:32:42PM -0500, Alex G. wrote: >> >> >> On 10/7/21 1:50 PM, Simon Glass wrote: >>> Hi Tom, >>> >>> On Thu, 7 Oct 2021 at 12:30, Tom Rini wrote: >>>> >>>> On Thu, Oct 07, 2021 at 12:02:24PM -0600, Simon Glass wrote: >>>>> Hi Tom, >>>>> >>>>> On Thu, 7 Oct 2021 at 07:42, Tom Rini wrote: >>>>>> >>>>>> On Thu, Oct 07, 2021 at 07:32:04AM -0600, Simon Glass wrote: >>>>>>> Hi Tom, >>>>>>> >>>>>>> On Wed, 6 Oct 2021 at 20:52, Tom Rini wrote: >>>>>>>> >>>>>>>> On Wed, Oct 06, 2021 at 08:49:13PM -0600, Simon Glass wrote: >>>>>>>>> Hi Tom, >>>>>>>>> >>>>>>>>> On Wed, 6 Oct 2021 at 18:26, Tom Rini wrote: >>>>>>>>>> >>>>>>>>>> On Sat, Sep 25, 2021 at 07:43:15PM -0600, Simon Glass wrote: >>>>>>>>>> >>>>>>>>>>> At present we must separately test for the host build for many options, >>>>>>>>>>> since we force them to be enabled. For example, CONFIG_FIT is always >>>>>>>>>>> enabled in the host tools, even if CONFIG_FIT is not enabled by the >>>>>>>>>>> board itself. >>>>>>>>>>> >>>>>>>>>>> It would be more convenient if we could use, for example, >>>>>>>>>>> CONFIG_IS_ENABLED(FIT) and get CONFIG_HOST_FIT, when building for the >>>>>>>>>>> host. Add support for this. >>>>>>>>>>> >>>>>>>>>>> With this and the tools_build() function, we should be able to remove all >>>>>>>>>>> the #ifdefs currently needed in code that is build by tools and targets. >>>>>>>>>>> >>>>>>>>>>> This will be even nicer when we move to using CONFIG(xxx) everywhere, >>>>>>>>>>> since all the #ifdef and IS_ENABLED/CONFIG_IS_ENABLED stuff will go away. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Simon Glass >>>>>>>>>>> Suggested-by: Rasmus Villemoes # b4f73886 >>>>>>>>>>> Reviewed-by: Alexandru Gagniuc >>>>>>>>>> >>>>>>>>>> The problem here is we don't include automatically >>>>>>>>>> when building host stuff, I believe. This is why doing this breaks >>>>>>>>>> test_mkimage_hashes for me on am335x_evm with: >>>>>>>>>> /tmp/.bm-work/am335x_evm/tools/mkimage -D -I dts -O dtb -i /tmp/.bm-work/am335x_evm -f /home/trini/work/u-boot/u-boot/test/py/tests/vboot//hash-images.its /tmp/.bm-work/am335x_evm/test.fit >>>>>>>>>> *** stack smashing detected ***: terminated >>>>>>>>> >>>>>>>>> Oh dear, and no CI coverage. >>>>>>>>> >>>>>>>>> I was reluctant to include kconfig.h everywhere but perhaps that is >>>>>>>>> the best approach. Will take a look ASAP. >>>>>>>> >>>>>>>> Maybe we need to think a bit harder too about how we structure >>>>>>>> intentionally shared code. >>>>>>>> >>>>>>>> Why not, for example, for these common algorithms, rely on typical >>>>>>>> system headers/libraries in the tooling, which means we validated U-Boot >>>>>>>> vs common reference, rather than just our implementations? >>>>>>> >>>>>>> Do you mean we use openssl for sha1, for example? >>>>>> >>>>>> I guess, yes. Just flat out saying we require openssl for tools, and >>>>>> doing our best to not make compatibility with libressl difficult, seems >>>>>> likely to cause less headaches for people than what we already require >>>>>> in terms of Python. >>>>> >>>>> I'm OK with that, although I do think the problem identified here >>>>> (CONFIG_SHA256 not enabled) is somewhat sideways from that. We already >>>> >>>> OK, I've taken what you posted on IRC and folded that in, continuing >>>> tests now. >>>> >>>>> use separate code paths to run hashing. Perhaps we could make it >>>>> optional? >>>>> >>>>> What about those people that complain about crypto libraries on their systems? >>>> >>>> I'm not sure how big a problem that really is, currently. I guess one >>>> thing would be to make a separate thread on it, and put it in the next >>>> -rc email as well, for people to explain why it would be a hardship. >>>> That in turn, I think, is coming down to modern vs very old openssl >>>> support, rather than having any at all. >>> >>> OK I'll take a look at some point. >>> >>> Or perhaps Alex might like to? >> >> We just got a complain about OpenSSL yesterday [1] >> >> Alex >> >> [1] https://lists.denx.de/pipermail/u-boot/2021-October/462728.html > > Oh goodness, LibreELC is a custom build system... I'll have to chime in > there, thanks. I am in favor of keeping libcrapto separate. We still need our own code for CRC32 and other weak or non-crypto hashes, a tidbit which makes me doubt the wisdom of relying entirely on an external lib. I had to make a similar decision when writing the hashes test. Originally, I was going to use pyCrypto, crcelk, to re-hash everything and compare to mkimage. It turned out to be neither necessarry nor efficient. Alex