From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v6 0/6] Add mipi dsi support for rk3288 Date: Thu, 17 Dec 2015 10:29:53 +0100 Message-ID: <3523259.ZRgH1Shd9Y@diego> References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , treding@nvidia.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgQ2hyaXMsCgpBbSBNaXR0d29jaCwgMTYuIERlemVtYmVyIDIwMTUsIDE4OjEwOjEwIHNjaHJp ZWIgQ2hyaXMgWmhvbmc6Cj4gVGhlIHJrMzI4OCBNSVBJIERTSSBpcyBhIFN5bm9wc3lzIERlc2ln bldhcmUgTUlQSSBEU0kgaG9zdCBjb250cm9sbGVyCj4gSVAuIFRoaXMgc2VyaWVzIGFkZHMgc3Vw cG9ydCBmb3IgYSBTeW5vcHN5cyBEZXNpZ25XYXJlIE1JUEkgRFNJIGhvc3QKPiBjb250cm9sbGVy IERSTSBkcml2ZXIuCj4gCj4gVGhlIE1JUEkgRFNJIGZlYXR1cmUgaXMgdGVzdGVkIG9uIHJrMzI4 OCBldmIgYm9hcmQsIGJhY2twb3J0IHRoZW0gdG8KPiBjaHJvbWUgb3Mga2VybmVsIGNocm9tZV92 My4xNCwgYW5kIGl0IGNhbiBkaXNwbGF5IG5vcm1hbGx5Lgo+IAo+IFRoaXMgcGF0Y2hzZXQgaXMg YmFzZSBvbiB0aGUgcGF0Y2hzZXQgZnJvbSBZaW5nLmxpdUBmcmVlc2NhbGUuY29tLgo+IDxodHRw Oi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL2RyaS1kZXZlbC9tc2c3NzE4MS5odG1sPgo+IAo+IEFj Y29yZGluZyB0byB0aGUgc3VnZ2VzdGlvbiBmcm9tIFRoaWVycnksIEkgaGF2ZSBnZXQgcmlkIG9m IHRoZSBicmlkZ2UsCj4gYW5kIHJlZ2lzdGVyIHRoZSBlbmNvZGVyICYgY29ubmVjdGVyIGluIGRy bS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jLgoKZnJvbSBteSBwb2ludCBpdCBsb29rcyBnb29kIChh bHRob3VnaCBJIGNhbm5vdCByZWFsbHkgc3BlYWsgb24gdGhlIGRybS1yZWxhdGVkIAppbnRlcm5h bHMpLgoKQnV0IEkgZG8gdGhpbmsgd2UnbGwgYmUgZG9pbmcgYXRvbWljIG1vZGVzZXR0aW5nIGNv bnZlcnNpb24gZmlyc3QgKGxhc3QgCnZlcnNpb24gcG9zdGVkIGZyb20gTWFyayB0b2RheSksIHNv IHlvdSBzaG91bGQgcHJvYmFibHkgbWFrZSBzdXJlIHlvdXIgZHNpIApkcml2ZXIgc3RpbGwgd29y a3MgYWZ0ZXIgdGhhdCBjb252ZXJzaW9uIGFuZCBtYWtlIGNoYW5nZXMgaWYgbmVlZGVkLgoKCkhl aWtvCgo+IAo+IAo+IENoYW5nZXMgaW4gdjY6Cj4gLSB1cGRhdGUgdGhlIGRvY3VtZW50LCBzaW5j ZSB0aGUgYnJpZGdlIGRldmljZSBoYXMgYmVlbiBkZWxldGVkLgo+IC0gRG8gbm90IHVzZSBicmlk Z2UgZHJpdmVyIChUaGllcnJ5IFJlZGluZykKPiAtIE9wdGltaXphdGlvbiB0aGUgcGh5IGluaXQg c2VxdWVuY2UKPiAKPiBDaGFuZ2VzIGluIHY1Ogo+IC0gbW9kaWZ5IHRoZSBjbGsgbmFtZSB0byBT Q0xLX01JUElEU0lfMjRNCj4gLSBhZGQgYSBibGFuayBsaW5lIGJlZm9yIGxjZF9lbgo+IAo+IENo YW5nZXMgaW4gdjQ6Cj4gLSB1c2UgY2xrX3JvdW5kX3JhdGUgdG8gY2hlY2sgdGhlIGNsb2NrIHJh dGUgaW4gdm9wX2NydGNfbW9kZV9maXh1cAo+IAo+IENoYW5nZXMgaW4gdjM6Cj4gLSBtb3ZlIGR3 X21pcGlfZHNpX3JvY2tjaGlwLnR4dCB0byBiaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwLwo+IAo+ IENocmlzIFpob25nICg1KToKPiAgIGRybS9yb2NrY2hpcDogcmV0dXJuIGEgdHJ1ZSBjbG9jayBy YXRlIHRvIGFkanVzdGVkX21vZGUKPiAgIERvY3VtZW50YXRpb246IGR0LWJpbmRpbmdzOiBBZGQg YmluZGluZ3MgZm9yIHJrMzI4OCBEVyBNSVBJIERTSSBkcml2ZXIKPiAgIGRybTogcm9ja2NoaXA6 IFN1cHBvcnQgU3lub3BzeXMgRFcgTUlQSSBEU0kKPiAgIEFSTTogZHRzOiByb2NrY2hpcDogYWRk IHJrMzI4OCBtaXBpX2RzaSBub2Rlcwo+ICAgQVJNOiBkdHM6IHJvY2tjaGlwOiBhZGQgc3VwcG9y dCBtaXBpIHBhbmVsIHR2MDgwd3VtLW5sMAo+IAo+IExpdSBZaW5nICgxKToKPiAgIGRybS9kc2k6 IEFkZCBhIGhlbHBlciB0byBnZXQgYml0cyBwZXIgcGl4ZWwgb2YgTUlQSSBEU0kgcGl4ZWwgZm9y bWF0Cj4gCj4gIC4uLi9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dCAg ICAgIHwgICA2MCArCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL3JrMzI4OC1ldmIuZHRzaSAgICAgICAg ICAgICAgICAgIHwgICAyMCArLQo+ICBhcmNoL2FybS9ib290L2R0cy9yazMyODguZHRzaSAgICAg ICAgICAgICAgICAgICAgICB8ICAgMzkgKwo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvS2Nv bmZpZyAgICAgICAgICAgICAgICAgICB8ICAgMTAgKwo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvTWFrZWZpbGUgICAgICAgICAgICAgICAgICB8ICAgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0v cm9ja2NoaXAvZHctbWlwaS1kc2kuYyAgICAgICAgICAgICB8IDEyMDAKPiArKysrKysrKysrKysr KysrKysrKyBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jICAgICAg ICB8ICAKPiAgOCArCj4gIGluY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNCArCj4gIDggZmlsZXMgY2hhbmdlZCwgMTM1MSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NAo+IERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4 dAo+IGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1k c2kuYwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Thu, 17 Dec 2015 10:29:53 +0100 Subject: [PATCH v6 0/6] Add mipi dsi support for rk3288 In-Reply-To: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> Message-ID: <3523259.ZRgH1Shd9Y@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chris, Am Mittwoch, 16. Dezember 2015, 18:10:10 schrieb Chris Zhong: > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > controller DRM driver. > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > chrome os kernel chrome_v3.14, and it can display normally. > > This patchset is base on the patchset from Ying.liu at freescale.com. > > > According to the suggestion from Thierry, I have get rid of the bridge, > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. from my point it looks good (although I cannot really speak on the drm-related internals). But I do think we'll be doing atomic modesetting conversion first (last version posted from Mark today), so you should probably make sure your dsi driver still works after that conversion and make changes if needed. Heiko > > > Changes in v6: > - update the document, since the bridge device has been deleted. > - Do not use bridge driver (Thierry Reding) > - Optimization the phy init sequence > > Changes in v5: > - modify the clk name to SCLK_MIPIDSI_24M > - add a blank line befor lcd_en > > Changes in v4: > - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup > > Changes in v3: > - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ > > Chris Zhong (5): > drm/rockchip: return a true clock rate to adjusted_mode > Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver > drm: rockchip: Support Synopsys DW MIPI DSI > ARM: dts: rockchip: add rk3288 mipi_dsi nodes > ARM: dts: rockchip: add support mipi panel tv080wum-nl0 > > Liu Ying (1): > drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + > arch/arm/boot/dts/rk3288-evb.dtsi | 20 +- > arch/arm/boot/dts/rk3288.dtsi | 39 + > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1200 > ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | > 8 + > include/drm/drm_mipi_dsi.h | 14 + > 8 files changed, 1351 insertions(+), 1 deletion(-) > create mode 100644 > Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755919AbbLQKGQ (ORCPT ); Thu, 17 Dec 2015 05:06:16 -0500 Received: from gloria.sntech.de ([95.129.55.99]:47465 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755837AbbLQKGL (ORCPT ); Thu, 17 Dec 2015 05:06:11 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chris Zhong Cc: linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com, treding@nvidia.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kumar Gala , Ian Campbell , Rob Herring , David Airlie , Pawel Moll , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 0/6] Add mipi dsi support for rk3288 Date: Thu, 17 Dec 2015 10:29:53 +0100 Message-ID: <3523259.ZRgH1Shd9Y@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> References: <1450260616-21160-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, Am Mittwoch, 16. Dezember 2015, 18:10:10 schrieb Chris Zhong: > The rk3288 MIPI DSI is a Synopsys DesignWare MIPI DSI host controller > IP. This series adds support for a Synopsys DesignWare MIPI DSI host > controller DRM driver. > > The MIPI DSI feature is tested on rk3288 evb board, backport them to > chrome os kernel chrome_v3.14, and it can display normally. > > This patchset is base on the patchset from Ying.liu@freescale.com. > > > According to the suggestion from Thierry, I have get rid of the bridge, > and register the encoder & connecter in drm/rockchip/dw-mipi-dsi.c. from my point it looks good (although I cannot really speak on the drm-related internals). But I do think we'll be doing atomic modesetting conversion first (last version posted from Mark today), so you should probably make sure your dsi driver still works after that conversion and make changes if needed. Heiko > > > Changes in v6: > - update the document, since the bridge device has been deleted. > - Do not use bridge driver (Thierry Reding) > - Optimization the phy init sequence > > Changes in v5: > - modify the clk name to SCLK_MIPIDSI_24M > - add a blank line befor lcd_en > > Changes in v4: > - use clk_round_rate to check the clock rate in vop_crtc_mode_fixup > > Changes in v3: > - move dw_mipi_dsi_rockchip.txt to bindings/display/rockchip/ > > Chris Zhong (5): > drm/rockchip: return a true clock rate to adjusted_mode > Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver > drm: rockchip: Support Synopsys DW MIPI DSI > ARM: dts: rockchip: add rk3288 mipi_dsi nodes > ARM: dts: rockchip: add support mipi panel tv080wum-nl0 > > Liu Ying (1): > drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 60 + > arch/arm/boot/dts/rk3288-evb.dtsi | 20 +- > arch/arm/boot/dts/rk3288.dtsi | 39 + > drivers/gpu/drm/rockchip/Kconfig | 10 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 1200 > ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop.c | > 8 + > include/drm/drm_mipi_dsi.h | 14 + > 8 files changed, 1351 insertions(+), 1 deletion(-) > create mode 100644 > Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi.c