From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017FE1327E0 for ; Wed, 17 Apr 2024 10:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713348914; cv=none; b=Sji4x9aBBtXM2PB4IROpX9By12dWzzDa2m+rPBIH3v2oiD5Vbsx+YlIyO6cFhWqa05w+eYgXFsvastLrmvbz7fsEPOO3Vjkuvm5C1qsPjeNdABkSuX2MUusyS4iWcCTfL/iLMsLdLss6ZYfO0BeZd+GHKJK1TeaCgDFrgaHHdxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713348914; c=relaxed/simple; bh=QGWe+amBAZzWV9gRaAbbm3NPOnMa2F/UdNO4TT/URkg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uwpzLtImAZM5VMo0JWKdZ8UjslY/bqXxUL/J0RccQpOLIu9tjJF9vs/Nv9aUVcK1xWBIxy50Hic0gKjTRkj5Ib973wmMNbyhE2miQdZ7M2JoJkbit4p2Syj8/X8Ga0dLPkBTkv4qJDihZ0PFfZPwpVEqbkuEaKNcDGMjAKulgMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rx2Jf-0006pF-HD; Wed, 17 Apr 2024 12:14:59 +0200 Message-ID: <352388ee-a267-4c1f-b968-e1a7709d46ea@pengutronix.de> Date: Wed, 17 Apr 2024 12:14:57 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock Content-Language: en-US To: Marek Vasut , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Conor Dooley , Pengutronix Kernel Team , devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , Paul Elder , imx@lists.linux.dev, Laurent Pinchart , Krzysztof Kozlowski , Fabio Estevam References: <20240416141914.9375-1-marex@denx.de> From: Ahmad Fatoum In-Reply-To: <20240416141914.9375-1-marex@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: imx@lists.linux.dev On 16.04.24 16:19, Marek Vasut wrote: > Configure both CSI2 assigned-clock-rates the same way. > There does not seem to be any reason for keeping the > two CSI2 pixel clock set to different frequencies. > > This also reduces first CSI2 clock from overdrive mode > frequency which is 500 MHz down below the regular mode > frequency of 400 MHz. > > Signed-off-by: Marek Vasut Reviewed-by: Ahmad Fatoum > --- > Cc: Conor Dooley > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Paul Elder > Cc: Pengutronix Kernel Team > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > V2: Align both clock to 266 MHz and update commit message > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 1bb96e96639f2..7883f5c056f4e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1667,7 +1667,7 @@ mipi_csi_0: csi@32e40000 { > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > <&clk IMX8MP_CLK_24M>; > - assigned-clock-rates = <500000000>; > + assigned-clock-rates = <266000000>; > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > status = "disabled"; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A7D3C4345F for ; Wed, 17 Apr 2024 10:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AYoB/xqLQb3zFmheBjwB8IL6EJoDXbT43EJb7dtb0iI=; b=Q6DUg7N7vzV355 Exr+0JBEWoABGjdGNo4vJCER06SnTst44udmVWOHKU1c6mG5FV8P+klPEAV9o7n2OkbZadrQSly+/ T9L80xqL9TiVMb7wGeW2s4acupE40i9CSnwFI/teH4Yn2vcVxd9st9XGxGdN7k692qcbM6L60K8HK URfgyTdq0BEYNVvsMCih7yLSERqnNcFnu5sk9cAyLxQasY5C7aqdDGrD+GdObeyGfXe+B4fUQFPkN nJu4C9HnnNDTJgKUpEV0hVal6zSTxHUNc6I++PLiJmciJHP86n2qGE/KUFiESzXWmtlvHU17sczY3 vSC2zTpGsQ+exDtcSrTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx2Jl-0000000FXH4-37ve; Wed, 17 Apr 2024 10:15:05 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx2Ji-0000000FXDj-2l5d for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 10:15:04 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rx2Jf-0006pF-HD; Wed, 17 Apr 2024 12:14:59 +0200 Message-ID: <352388ee-a267-4c1f-b968-e1a7709d46ea@pengutronix.de> Date: Wed, 17 Apr 2024 12:14:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: imx8mp: Align both CSI2 pixel clock Content-Language: en-US To: Marek Vasut , linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Conor Dooley , Pengutronix Kernel Team , devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , Paul Elder , imx@lists.linux.dev, Laurent Pinchart , Krzysztof Kozlowski , Fabio Estevam References: <20240416141914.9375-1-marex@denx.de> From: Ahmad Fatoum In-Reply-To: <20240416141914.9375-1-marex@denx.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_031502_795108_09EB8C23 X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16.04.24 16:19, Marek Vasut wrote: > Configure both CSI2 assigned-clock-rates the same way. > There does not seem to be any reason for keeping the > two CSI2 pixel clock set to different frequencies. > > This also reduces first CSI2 clock from overdrive mode > frequency which is 500 MHz down below the regular mode > frequency of 400 MHz. > > Signed-off-by: Marek Vasut Reviewed-by: Ahmad Fatoum > --- > Cc: Conor Dooley > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Paul Elder > Cc: Pengutronix Kernel Team > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > V2: Align both clock to 266 MHz and update commit message > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 1bb96e96639f2..7883f5c056f4e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1667,7 +1667,7 @@ mipi_csi_0: csi@32e40000 { > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>; > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>, > <&clk IMX8MP_CLK_24M>; > - assigned-clock-rates = <500000000>; > + assigned-clock-rates = <266000000>; > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>; > status = "disabled"; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel