From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABB13FC7
	for <bpf@vger.kernel.org>; Thu, 25 Sep 2025 00:10:09 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1758759011; cv=none; b=OwYevDx9uZph5k9n7hZXyhBHQ0Mw9OXhcPJdho1gIuZemPVz1JYg+D6fmcGJruI8OYnRcjX3RlYQ44GPZ4vKQXHfobQw9w/J3/fYGPCJaMO2caxNs3kAWlGJeCRJ3jvUYrm5OO+Jrp5rbVzALhPPxogascdLEGsl5eeJdhoXHH0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1758759011; c=relaxed/simple;
	bh=YgaEvb15XATMWEWb8eFnC4+mYJrUt6v4HCkUTqs3tI0=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=Q2ssTRrtaf66TqOvwSrFOvdzYi9zbrMC8XM7e7SgmGO1xFp0tohwzgvxw4uBRWCrLTNjvXFGq2iDdaA1QPdgRsYtGq2U9JIVPkJVBKyVGvI/Rb7Vz8cQwMyFC9hT/u5Kz/LtFu/CQJyHYBctIQzQJEGbqU/XlUrVcDoHONn77vc=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wjKwCQPt; arc=none smtp.client-ip=95.215.58.173
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wjKwCQPt"
Message-ID: <35282ea2-7ccb-450a-aa78-491f2e84cbf3@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1758759006;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AJdDPbXNYlA68LqQTvJeCr8VzpFVGdGvQUcuCZnkd1s=;
	b=wjKwCQPtWTBxhzv7Fct/aG+wbdTmCxS+FOU/Mal75njJ4Udg+RB5uv6O57m/xPemepmwpZ
	tvDqZqedwDHnyQMzhWkPE+ZvhOZcr9dqr0v6Ea7W1MFkW2Lfk0AesFvel1NebLJ91iIIuD
	F3UihIZxxwz9SFeQxI+x40A0pdL6y2s=
Date: Wed, 24 Sep 2025 17:09:52 -0700
Precedence: bulk
X-Mailing-List: bpf@vger.kernel.org
List-Id: <bpf.vger.kernel.org>
List-Subscribe: <mailto:bpf+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:bpf+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Subject: Re: pull-request: bpf-next 2025-09-23
To: Jakub Kicinski <kuba@kernel.org>, Amery Hung <ameryhung@gmail.com>
Cc: David Miller <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>,
 Andrii Nakryiko <andrii@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
 netdev@vger.kernel.org, bpf@vger.kernel.org
References: <20250924050303.2466356-1-martin.lau@linux.dev>
 <20250924151831.66c38c74@kernel.org>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Martin KaFai Lau <martin.lau@linux.dev>
Content-Language: en-US
In-Reply-To: <20250924151831.66c38c74@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT

On 9/24/25 3:18 PM, Jakub Kicinski wrote:
> 74: (15) if r1 == 0x20 goto pc+309 384: frame1: R0=map_value(map=map_xdp_setup,ks=4,vs=4) R1=32 R2=0xfffffeff R3=scalar(smin=0xffffffff80000000,smax=0x7fffffff) R4=16 R5=1 R6=2 R7=ctx() R8=pkt(off=34,r=42) R9=scalar() R10=fp0 fp-336=mmmmmmmm
> ; switch (*val) { @ xdp_native.bpf.c:594
> 384: (b7) r4 = 32                     ; frame1: R4_w=32
> 385: (05) goto pc+1
> 387: (7b) *(u64 *)(r10 -352) = r5     ; frame1: R5=1 R10=fp0 fp-352_w=1
> 388: (1f) r8 -= r9

The "hdr_len = (void *)udph_ptr - data + sizeof(struct udphdr);" calculation 
needs to reload the ctx->data after filter_udphdr(). Amery will send a fix.