From: Marek Vasut <marek.vasut@mailbox.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: linux-clk@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] clk: renesas: cpg-mssr: Read back reset registers to assure values latched
Date: Thu, 18 Sep 2025 15:42:52 +0200 [thread overview]
Message-ID: <353db156-e518-49c8-96ac-bd138ee64a01@mailbox.org> (raw)
In-Reply-To: <CA+V-a8sjPx8U+MB3v-SxErRPqbz4irAgZhCvd5CHY=6uO_VoyQ@mail.gmail.com>
On 9/18/25 1:11 PM, Lad, Prabhakar wrote:
Hello Prabhakar,
>> diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
>> index 65dfaceea71f..7b52e8235984 100644
>> --- a/drivers/clk/renesas/renesas-cpg-mssr.c
>> +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
>> @@ -688,6 +688,7 @@ static int cpg_mssr_reset(struct reset_controller_dev *rcdev,
>>
>> /* Reset module */
>> writel(bitmask, priv->pub.base0 + priv->reset_regs[reg]);
>> + readl(priv->pub.base0 + priv->reset_regs[reg]);
> Fyi on the RZ/T2H and RZ/N2H SoCs which uses the same driver we need
> to read the reset register `7` times and confirm [0] (as mentioned in
> the HW manual). So after reading do we want to confirm the bit is
> set/clear?
This is interesting, I wonder if the readback is something more common
to this reset controller.
Why 7 times ? Is this documented in one of the HW manuals ? Are those
public and can you share a link to them , with the specific chapter or
page I should read about this 7 times read requirement ?
next prev parent reply other threads:[~2025-09-18 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 3:06 [PATCH] clk: renesas: cpg-mssr: Read back reset registers to assure values latched Marek Vasut
2025-09-18 6:08 ` Wolfram Sang
2025-09-18 13:38 ` Marek Vasut
2025-09-18 11:11 ` Lad, Prabhakar
2025-09-18 13:42 ` Marek Vasut [this message]
2025-09-18 15:05 ` Lad, Prabhakar
2025-09-18 23:16 ` Marek Vasut
2025-09-19 8:23 ` Lad, Prabhakar
2025-09-22 11:22 ` Geert Uytterhoeven
2025-09-22 13:57 ` Wolfram Sang
2025-09-22 14:08 ` Geert Uytterhoeven
2025-09-22 14:23 ` Wolfram Sang
2025-09-19 7:21 ` Geert Uytterhoeven
2025-09-19 8:22 ` Lad, Prabhakar
2025-09-19 12:19 ` Marek Vasut
2025-09-22 6:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353db156-e518-49c8-96ac-bd138ee64a01@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mturquette@baylibre.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.