From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal: fix NULL device argument pointer reference
Date: Mon, 22 Oct 2018 12:47:36 +0200 [thread overview]
Message-ID: <3540454.BVlvfsRZ1j@xps> (raw)
In-Reply-To: <1754125.JGkyPi735h@xps>
22/10/2018 09:30, Thomas Monjalon:
> 22/10/2018 08:15, Qi Zhang:
> > dev->devargs is not initialized for PCI device, so use dev->bus to
> > replace dev->devargs->bus to avoid segment fault when hotplug remove
> > a PCI device.
>
> It is not really specific to PCI device.
> The devargs is not initialized if the device is probed by default policy
> (i.e. not in blacklist).
>
> I think we can say that "devargs is not always initialized".
>
> > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Applied with following text:
eal: fix bus name read for removal in multi-process
A crash may appear when removing some PCI devices because
dev->devargs is not always initialized. So use dev->bus instead of
dev->devargs->bus when building devargs string to remove a device.
prev parent reply other threads:[~2018-10-22 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 6:15 [PATCH] eal: fix NULL device argument pointer reference Qi Zhang
2018-10-22 7:30 ` Thomas Monjalon
2018-10-22 10:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3540454.BVlvfsRZ1j@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.