From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Jacopo Mondi Cc: horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU Date: Fri, 06 Apr 2018 16:45:16 +0300 Message-ID: <35431593.B1LTs037XF@avalon> In-Reply-To: <1523020092-25540-6-git-send-email-jacopo+renesas@jmondi.org> References: <1523020092-25540-1-git-send-email-jacopo+renesas@jmondi.org> <1523020092-25540-6-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hi Jacopo, Thank you for the patch. On Friday, 6 April 2018 16:08:10 EEST Jacopo Mondi wrote: > Enable DU for Renesas R-Car V3M Eagle board. > > Signed-off-by: Jacopo Mondi > --- > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 3c5f598..144b847 > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts > @@ -76,6 +76,11 @@ > function = "i2c0"; > }; > > + du_pins: du { > + groups = "du_rgb666", "du_sync", "du_oddf", "du_clk_out"; > + function = "du"; > + }; As far as I can tell the DU parallel output isn't used on the Eagle board, but is used on the Eagle expansion board. I would move this to patch 7/7 in this series. > scif0_pins: scif0 { > groups = "scif0_data"; > function = "scif0"; > @@ -93,3 +98,9 @@ > > status = "okay"; > }; > + > +&du { > + pinctrl-0 = <&du_pins>; > + pinctrl-names = "default"; These two properties should be moved to patch 7/7 too. > + status = "okay"; > +}; There's little use for enabling the DU in DT if you have no output port described. I'd move this to patch 6/7. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU Date: Fri, 06 Apr 2018 16:45:16 +0300 Message-ID: <35431593.B1LTs037XF@avalon> References: <1523020092-25540-1-git-send-email-jacopo+renesas@jmondi.org> <1523020092-25540-6-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1523020092-25540-6-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, geert@linux-m68k.org, niklas.soderlund@ragnatech.se List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDYgQXByaWwg MjAxOCAxNjowODoxMCBFRVNUIEphY29wbyBNb25kaSB3cm90ZToKPiBFbmFibGUgRFUgZm9yIFJl bmVzYXMgUi1DYXIgVjNNIEVhZ2xlIGJvYXJkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphY29wbyBN b25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4KPiAtLS0KPiAgYXJjaC9hcm02NC9ib290 L2R0cy9yZW5lc2FzL3I4YTc3OTcwLWVhZ2xlLmR0cyB8IDExICsrKysrKysrKysrCj4gIDEgZmls ZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQv Ym9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk3MC1lYWdsZS5kdHMKPiBiL2FyY2gvYXJtNjQvYm9vdC9k dHMvcmVuZXNhcy9yOGE3Nzk3MC1lYWdsZS5kdHMgaW5kZXggM2M1ZjU5OC4uMTQ0Yjg0Nwo+IDEw MDY0NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk3MC1lYWdsZS5k dHMKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5NzAtZWFnbGUuZHRz Cj4gQEAgLTc2LDYgKzc2LDExIEBACj4gIAkJZnVuY3Rpb24gPSAiaTJjMCI7Cj4gIAl9Owo+IAo+ ICsJZHVfcGluczogZHUgewo+ICsJCWdyb3VwcyA9ICJkdV9yZ2I2NjYiLCAiZHVfc3luYyIsICJk dV9vZGRmIiwgImR1X2Nsa19vdXQiOwo+ICsJCWZ1bmN0aW9uID0gImR1IjsKPiArCX07CgpBcyBm YXIgYXMgSSBjYW4gdGVsbCB0aGUgRFUgcGFyYWxsZWwgb3V0cHV0IGlzbid0IHVzZWQgb24gdGhl IEVhZ2xlIGJvYXJkLCBidXQgCmlzIHVzZWQgb24gdGhlIEVhZ2xlIGV4cGFuc2lvbiBib2FyZC4g SSB3b3VsZCBtb3ZlIHRoaXMgdG8gcGF0Y2ggNy83IGluIHRoaXMgCnNlcmllcy4KCj4gIAlzY2lm MF9waW5zOiBzY2lmMCB7Cj4gIAkJZ3JvdXBzID0gInNjaWYwX2RhdGEiOwo+ICAJCWZ1bmN0aW9u ID0gInNjaWYwIjsKPiBAQCAtOTMsMyArOTgsOSBAQAo+IAo+ICAJc3RhdHVzID0gIm9rYXkiOwo+ ICB9Owo+ICsKPiArJmR1IHsKPiArCXBpbmN0cmwtMCA9IDwmZHVfcGlucz47Cj4gKwlwaW5jdHJs LW5hbWVzID0gImRlZmF1bHQiOwoKVGhlc2UgdHdvIHByb3BlcnRpZXMgc2hvdWxkIGJlIG1vdmVk IHRvIHBhdGNoIDcvNyB0b28uCgo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ICt9OwoKVGhlcmUncyBs aXR0bGUgdXNlIGZvciBlbmFibGluZyB0aGUgRFUgaW4gRFQgaWYgeW91IGhhdmUgbm8gb3V0cHV0 IHBvcnQgCmRlc2NyaWJlZC4gSSdkIG1vdmUgdGhpcyB0byBwYXRjaCA2LzcuCgotLSAKUmVnYXJk cywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==