From: Thomas Monjalon <thomas@monjalon.net>
To: Yangchao Zhou <zhouyates@gmail.com>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] lpm: skip table entries update if rules found
Date: Fri, 24 Apr 2020 19:17:30 +0200 [thread overview]
Message-ID: <3545193.07ICAnoMbH@thomas> (raw)
In-Reply-To: <7c295dc2-1563-4c46-e592-037368c864b8@intel.com>
21/04/2020 17:44, Medvedkin, Vladimir:
> Hi Yangchao,
>
> Thanks for the patch.
> This might be useful for control plane implementations that don't track
> inserted routes.
> I have just a one nit inlined below. Also, could you do the same for lpm6?
>
> P.S. Please have a look at rte_fib library, there are more optimizations
> compared to lpm library.
>
> Apart from that,
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
[...]
> > /* If rule already exists update its next_hop and return. */
Reduced length of above comment,
> > if (lpm->rules_tbl[rule_index].ip == ip_masked) {
> > +
> > + if (lpm->rules_tbl[rule_index].next_hop == next_hop)
>
>
> Line over 80 characters, please split it by two.
and split above line.
Applied with requested changes, thanks.
prev parent reply other threads:[~2020-04-24 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:48 [dpdk-dev] [PATCH] lpm: skip table entries update if rules found Yangchao Zhou
2020-04-17 14:01 ` Medvedkin, Vladimir
[not found] ` <CABLiTuxTNQYYSCwWRuqqSZy+0JhBqjcE2v5ha+OqWk+YH42+TA@mail.gmail.com>
2020-04-17 15:07 ` Yangchao Zhou
2020-04-17 15:09 ` [dpdk-dev] [PATCH v2] " Yangchao Zhou
2020-04-17 17:26 ` [dpdk-dev] [PATCH v3] " Yangchao Zhou
2020-04-20 2:48 ` [dpdk-dev] [PATCH v4] " Yangchao Zhou
2020-04-21 15:44 ` Medvedkin, Vladimir
2020-04-24 17:17 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3545193.07ICAnoMbH@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.